Commit eb0f5044 authored by Ville Syrjälä's avatar Ville Syrjälä

drm/i915: Don't pass plane to .check_plane()

.check_plane() already gets the plane state, so we can dig out the plane
from there if needed. No need in passing it separately.

Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180828142707.31583-1-ville.syrjala@linux.intel.comReviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
parent ed11e415
...@@ -159,7 +159,7 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_ ...@@ -159,7 +159,7 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_
} }
intel_state->base.visible = false; intel_state->base.visible = false;
ret = intel_plane->check_plane(intel_plane, crtc_state, intel_state); ret = intel_plane->check_plane(crtc_state, intel_state);
if (ret) if (ret)
return ret; return ret;
......
...@@ -9694,8 +9694,7 @@ static bool i845_cursor_size_ok(const struct intel_plane_state *plane_state) ...@@ -9694,8 +9694,7 @@ static bool i845_cursor_size_ok(const struct intel_plane_state *plane_state)
return intel_cursor_size_ok(plane_state) && IS_ALIGNED(width, 64); return intel_cursor_size_ok(plane_state) && IS_ALIGNED(width, 64);
} }
static int i845_check_cursor(struct intel_plane *plane, static int i845_check_cursor(struct intel_crtc_state *crtc_state,
struct intel_crtc_state *crtc_state,
struct intel_plane_state *plane_state) struct intel_plane_state *plane_state)
{ {
const struct drm_framebuffer *fb = plane_state->base.fb; const struct drm_framebuffer *fb = plane_state->base.fb;
...@@ -9885,10 +9884,10 @@ static bool i9xx_cursor_size_ok(const struct intel_plane_state *plane_state) ...@@ -9885,10 +9884,10 @@ static bool i9xx_cursor_size_ok(const struct intel_plane_state *plane_state)
return true; return true;
} }
static int i9xx_check_cursor(struct intel_plane *plane, static int i9xx_check_cursor(struct intel_crtc_state *crtc_state,
struct intel_crtc_state *crtc_state,
struct intel_plane_state *plane_state) struct intel_plane_state *plane_state)
{ {
struct intel_plane *plane = to_intel_plane(plane_state->base.plane);
struct drm_i915_private *dev_priv = to_i915(plane->base.dev); struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
const struct drm_framebuffer *fb = plane_state->base.fb; const struct drm_framebuffer *fb = plane_state->base.fb;
enum pipe pipe = plane->pipe; enum pipe pipe = plane->pipe;
...@@ -13190,10 +13189,10 @@ skl_max_scale(struct intel_crtc *intel_crtc, ...@@ -13190,10 +13189,10 @@ skl_max_scale(struct intel_crtc *intel_crtc,
} }
static int static int
intel_check_primary_plane(struct intel_plane *plane, intel_check_primary_plane(struct intel_crtc_state *crtc_state,
struct intel_crtc_state *crtc_state,
struct intel_plane_state *state) struct intel_plane_state *state)
{ {
struct intel_plane *plane = to_intel_plane(state->base.plane);
struct drm_i915_private *dev_priv = to_i915(plane->base.dev); struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
struct drm_crtc *crtc = state->base.crtc; struct drm_crtc *crtc = state->base.crtc;
int min_scale = DRM_PLANE_HELPER_NO_SCALING; int min_scale = DRM_PLANE_HELPER_NO_SCALING;
......
...@@ -971,9 +971,8 @@ struct intel_plane { ...@@ -971,9 +971,8 @@ struct intel_plane {
void (*disable_plane)(struct intel_plane *plane, void (*disable_plane)(struct intel_plane *plane,
struct intel_crtc *crtc); struct intel_crtc *crtc);
bool (*get_hw_state)(struct intel_plane *plane, enum pipe *pipe); bool (*get_hw_state)(struct intel_plane *plane, enum pipe *pipe);
int (*check_plane)(struct intel_plane *plane, int (*check_plane)(struct intel_crtc_state *crtc_state,
struct intel_crtc_state *crtc_state, struct intel_plane_state *plane_state);
struct intel_plane_state *state);
}; };
struct intel_watermark_params { struct intel_watermark_params {
......
...@@ -959,10 +959,10 @@ g4x_plane_get_hw_state(struct intel_plane *plane, ...@@ -959,10 +959,10 @@ g4x_plane_get_hw_state(struct intel_plane *plane,
} }
static int static int
intel_check_sprite_plane(struct intel_plane *plane, intel_check_sprite_plane(struct intel_crtc_state *crtc_state,
struct intel_crtc_state *crtc_state,
struct intel_plane_state *state) struct intel_plane_state *state)
{ {
struct intel_plane *plane = to_intel_plane(state->base.plane);
struct drm_i915_private *dev_priv = to_i915(plane->base.dev); struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc); struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
struct drm_framebuffer *fb = state->base.fb; struct drm_framebuffer *fb = state->base.fb;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment