Commit eb12ce60 authored by Tejun Heo's avatar Tejun Heo Committed by Ingo Molnar

x86,percpu: fix inverted NUMA test in setup_pcpu_remap()

setup_percpu_remap() is for NUMA machines yet it bailed out with
-EINVAL if pcpu_need_numa().  Fix the inverted condition.

This problem was reported by David Miller and verified by Yinhai Lu.
Reported-by: default avatarDavid Miller <davem@davemloft.net>
Reported-by: default avatarYinghai Lu <yinghai@kernel.org>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
LKML-Reference: <49D30469.8020006@kernel.org>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 0f8f3089
...@@ -162,7 +162,7 @@ static ssize_t __init setup_pcpu_remap(size_t static_size) ...@@ -162,7 +162,7 @@ static ssize_t __init setup_pcpu_remap(size_t static_size)
* If large page isn't supported, there's no benefit in doing * If large page isn't supported, there's no benefit in doing
* this. Also, on non-NUMA, embedding is better. * this. Also, on non-NUMA, embedding is better.
*/ */
if (!cpu_has_pse || pcpu_need_numa()) if (!cpu_has_pse || !pcpu_need_numa())
return -EINVAL; return -EINVAL;
last = NULL; last = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment