Commit eb943696 authored by Tobias Jordan's avatar Tobias Jordan Committed by Vinod Koul

dmaengine: jz4740: disable/unprepare clk if probe fails

in error path of jz4740_dma_probe(), call clk_disable_unprepare() to clean
up.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 25ce6c35 MIPS: jz4740: Remove custom DMA API
Signed-off-by: default avatarTobias Jordan <Tobias.Jordan@elektrobit.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 6f6a23a2
...@@ -555,7 +555,7 @@ static int jz4740_dma_probe(struct platform_device *pdev) ...@@ -555,7 +555,7 @@ static int jz4740_dma_probe(struct platform_device *pdev)
ret = dma_async_device_register(dd); ret = dma_async_device_register(dd);
if (ret) if (ret)
return ret; goto err_clk;
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
ret = request_irq(irq, jz4740_dma_irq, 0, dev_name(&pdev->dev), dmadev); ret = request_irq(irq, jz4740_dma_irq, 0, dev_name(&pdev->dev), dmadev);
...@@ -568,6 +568,8 @@ static int jz4740_dma_probe(struct platform_device *pdev) ...@@ -568,6 +568,8 @@ static int jz4740_dma_probe(struct platform_device *pdev)
err_unregister: err_unregister:
dma_async_device_unregister(dd); dma_async_device_unregister(dd);
err_clk:
clk_disable_unprepare(dmadev->clk);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment