Commit eccd895c authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai

ALSA: firewire-motu: unify stop and release method for duplex streams

>From callbacks for pcm and rawmidi interfaces, the functions to stop
and release duplex streams are called at the same time. This commit
merges the two functions.
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent af26bacc
...@@ -40,7 +40,6 @@ static int midi_close(struct snd_rawmidi_substream *substream) ...@@ -40,7 +40,6 @@ static int midi_close(struct snd_rawmidi_substream *substream)
--motu->substreams_counter; --motu->substreams_counter;
snd_motu_stream_stop_duplex(motu); snd_motu_stream_stop_duplex(motu);
snd_motu_stream_release_duplex(motu);
mutex_unlock(&motu->mutex); mutex_unlock(&motu->mutex);
......
...@@ -224,7 +224,6 @@ static int pcm_hw_free(struct snd_pcm_substream *substream) ...@@ -224,7 +224,6 @@ static int pcm_hw_free(struct snd_pcm_substream *substream)
--motu->substreams_counter; --motu->substreams_counter;
snd_motu_stream_stop_duplex(motu); snd_motu_stream_stop_duplex(motu);
snd_motu_stream_release_duplex(motu);
mutex_unlock(&motu->mutex); mutex_unlock(&motu->mutex);
......
...@@ -200,14 +200,6 @@ int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate) ...@@ -200,14 +200,6 @@ int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate)
return 0; return 0;
} }
void snd_motu_stream_release_duplex(struct snd_motu *motu)
{
if (motu->substreams_counter == 0) {
fw_iso_resources_free(&motu->tx_resources);
fw_iso_resources_free(&motu->rx_resources);
}
}
static int ensure_packet_formats(struct snd_motu *motu) static int ensure_packet_formats(struct snd_motu *motu)
{ {
__be32 reg; __be32 reg;
...@@ -301,8 +293,12 @@ int snd_motu_stream_start_duplex(struct snd_motu *motu) ...@@ -301,8 +293,12 @@ int snd_motu_stream_start_duplex(struct snd_motu *motu)
void snd_motu_stream_stop_duplex(struct snd_motu *motu) void snd_motu_stream_stop_duplex(struct snd_motu *motu)
{ {
if (motu->substreams_counter == 0) if (motu->substreams_counter == 0) {
finish_session(motu); finish_session(motu);
fw_iso_resources_free(&motu->tx_resources);
fw_iso_resources_free(&motu->rx_resources);
}
} }
static int init_stream(struct snd_motu *motu, enum amdtp_stream_direction dir) static int init_stream(struct snd_motu *motu, enum amdtp_stream_direction dir)
......
...@@ -154,7 +154,6 @@ int snd_motu_stream_init_duplex(struct snd_motu *motu); ...@@ -154,7 +154,6 @@ int snd_motu_stream_init_duplex(struct snd_motu *motu);
void snd_motu_stream_destroy_duplex(struct snd_motu *motu); void snd_motu_stream_destroy_duplex(struct snd_motu *motu);
int snd_motu_stream_cache_packet_formats(struct snd_motu *motu); int snd_motu_stream_cache_packet_formats(struct snd_motu *motu);
int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate); int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate);
void snd_motu_stream_release_duplex(struct snd_motu *motu);
int snd_motu_stream_start_duplex(struct snd_motu *motu); int snd_motu_stream_start_duplex(struct snd_motu *motu);
void snd_motu_stream_stop_duplex(struct snd_motu *motu); void snd_motu_stream_stop_duplex(struct snd_motu *motu);
int snd_motu_stream_lock_try(struct snd_motu *motu); int snd_motu_stream_lock_try(struct snd_motu *motu);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment