Commit ecf4d59a authored by zhengbin's avatar zhengbin Committed by Jens Axboe

paride/pf: need to set queue to NULL before put_disk

In pf_init_units, if blk_mq_init_sq_queue fails, need to set queue to
NULL before put_disk, otherwise null-ptr-deref Read will occur.

put_disk
  kobject_put
    disk_release
      blk_put_queue(disk->queue)

Fixes: 77218ddf ("paride: convert pf to blk-mq")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarzhengbin <zhengbin13@huawei.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent c5ef62e6
...@@ -300,8 +300,8 @@ static void __init pf_init_units(void) ...@@ -300,8 +300,8 @@ static void __init pf_init_units(void)
disk->queue = blk_mq_init_sq_queue(&pf->tag_set, &pf_mq_ops, disk->queue = blk_mq_init_sq_queue(&pf->tag_set, &pf_mq_ops,
1, BLK_MQ_F_SHOULD_MERGE); 1, BLK_MQ_F_SHOULD_MERGE);
if (IS_ERR(disk->queue)) { if (IS_ERR(disk->queue)) {
put_disk(disk);
disk->queue = NULL; disk->queue = NULL;
put_disk(disk);
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment