Commit ee920bca authored by Thierry Reding's avatar Thierry Reding

drm/panel: sharp: lq101r1sx01: Respect power timings

Before shutting down the display using the DCS display_off command, wait
for 4 frames according to the datasheet.

Furthermore, after enabling the power supply, the supply voltage needs
around 10 ms to settle. After that, another 120 ms is required before a
DCS exit_sleep_mode command can be sent.

While at it, no longer send the DCS soft_reset command. This is totally
unnecessary because we've just powered up the display, hence it will be
in a reset state already.
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 4569619d
...@@ -116,6 +116,8 @@ static int sharp_panel_unprepare(struct drm_panel *panel) ...@@ -116,6 +116,8 @@ static int sharp_panel_unprepare(struct drm_panel *panel)
if (!sharp->prepared) if (!sharp->prepared)
return 0; return 0;
sharp_wait_frames(sharp, 4);
err = mipi_dsi_dcs_set_display_off(sharp->link1); err = mipi_dsi_dcs_set_display_off(sharp->link1);
if (err < 0) if (err < 0)
dev_err(panel->dev, "failed to set display off: %d\n", err); dev_err(panel->dev, "failed to set display off: %d\n", err);
...@@ -180,15 +182,13 @@ static int sharp_panel_prepare(struct drm_panel *panel) ...@@ -180,15 +182,13 @@ static int sharp_panel_prepare(struct drm_panel *panel)
if (err < 0) if (err < 0)
return err; return err;
usleep_range(10000, 20000); /*
* According to the datasheet, the panel needs around 10 ms to fully
err = mipi_dsi_dcs_soft_reset(sharp->link1); * power up. At least another 120 ms is required before exiting sleep
if (err < 0) { * mode to make sure the panel is ready. Throw in another 20 ms for
dev_err(panel->dev, "soft reset failed: %d\n", err); * good measure.
goto poweroff; */
} msleep(150);
msleep(120);
err = mipi_dsi_dcs_exit_sleep_mode(sharp->link1); err = mipi_dsi_dcs_exit_sleep_mode(sharp->link1);
if (err < 0) { if (err < 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment