Commit eef6d7b8 authored by Vaibhav Bedia's avatar Vaibhav Bedia Committed by Mark Brown

ASoC: Davinci: Call clk_disable() and clk_put() in case of error

In case of any error in probe() function, clk_disable() and clk_put()
should be called if clk_enable() and clk_get() went through.
Signed-off-by: default avatarVaibhav Bedia <vaibhav.bedia@ti.com>
Acked-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent d852f446
...@@ -707,7 +707,7 @@ static int davinci_i2s_probe(struct platform_device *pdev) ...@@ -707,7 +707,7 @@ static int davinci_i2s_probe(struct platform_device *pdev)
if (!res) { if (!res) {
dev_err(&pdev->dev, "no DMA resource\n"); dev_err(&pdev->dev, "no DMA resource\n");
ret = -ENXIO; ret = -ENXIO;
goto err_free_mem; goto err_release_clk;
} }
dev->dma_params[SNDRV_PCM_STREAM_PLAYBACK].channel = res->start; dev->dma_params[SNDRV_PCM_STREAM_PLAYBACK].channel = res->start;
...@@ -715,7 +715,7 @@ static int davinci_i2s_probe(struct platform_device *pdev) ...@@ -715,7 +715,7 @@ static int davinci_i2s_probe(struct platform_device *pdev)
if (!res) { if (!res) {
dev_err(&pdev->dev, "no DMA resource\n"); dev_err(&pdev->dev, "no DMA resource\n");
ret = -ENXIO; ret = -ENXIO;
goto err_free_mem; goto err_release_clk;
} }
dev->dma_params[SNDRV_PCM_STREAM_CAPTURE].channel = res->start; dev->dma_params[SNDRV_PCM_STREAM_CAPTURE].channel = res->start;
dev->dev = &pdev->dev; dev->dev = &pdev->dev;
...@@ -724,10 +724,13 @@ static int davinci_i2s_probe(struct platform_device *pdev) ...@@ -724,10 +724,13 @@ static int davinci_i2s_probe(struct platform_device *pdev)
ret = snd_soc_register_dai(&pdev->dev, &davinci_i2s_dai); ret = snd_soc_register_dai(&pdev->dev, &davinci_i2s_dai);
if (ret != 0) if (ret != 0)
goto err_free_mem; goto err_release_clk;
return 0; return 0;
err_release_clk:
clk_disable(dev->clk);
clk_put(dev->clk);
err_free_mem: err_free_mem:
kfree(dev); kfree(dev);
err_release_region: err_release_region:
......
...@@ -906,7 +906,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) ...@@ -906,7 +906,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (!res) { if (!res) {
dev_err(&pdev->dev, "no DMA resource\n"); dev_err(&pdev->dev, "no DMA resource\n");
ret = -ENODEV; ret = -ENODEV;
goto err_release_region; goto err_release_clk;
} }
dma_data->channel = res->start; dma_data->channel = res->start;
...@@ -921,7 +921,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) ...@@ -921,7 +921,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (!res) { if (!res) {
dev_err(&pdev->dev, "no DMA resource\n"); dev_err(&pdev->dev, "no DMA resource\n");
ret = -ENODEV; ret = -ENODEV;
goto err_release_region; goto err_release_clk;
} }
dma_data->channel = res->start; dma_data->channel = res->start;
...@@ -929,9 +929,12 @@ static int davinci_mcasp_probe(struct platform_device *pdev) ...@@ -929,9 +929,12 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
ret = snd_soc_register_dai(&pdev->dev, &davinci_mcasp_dai[pdata->op_mode]); ret = snd_soc_register_dai(&pdev->dev, &davinci_mcasp_dai[pdata->op_mode]);
if (ret != 0) if (ret != 0)
goto err_release_region; goto err_release_clk;
return 0; return 0;
err_release_clk:
clk_disable(dev->clk);
clk_put(dev->clk);
err_release_region: err_release_region:
release_mem_region(mem->start, resource_size(mem)); release_mem_region(mem->start, resource_size(mem));
err_release_data: err_release_data:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment