Commit f01e0ffd authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab

[media] au0828: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent d3a95091
...@@ -193,7 +193,7 @@ void au0828_card_setup(struct au0828_dev *dev) ...@@ -193,7 +193,7 @@ void au0828_card_setup(struct au0828_dev *dev)
dprintk(1, "%s()\n", __func__); dprintk(1, "%s()\n", __func__);
memcpy(&dev->board, &au0828_boards[dev->boardnr], sizeof(dev->board)); dev->board = au0828_boards[dev->boardnr];
if (dev->i2c_rc == 0) { if (dev->i2c_rc == 0) {
dev->i2c_client.addr = 0xa0 >> 1; dev->i2c_client.addr = 0xa0 >> 1;
......
...@@ -364,12 +364,9 @@ int au0828_i2c_register(struct au0828_dev *dev) ...@@ -364,12 +364,9 @@ int au0828_i2c_register(struct au0828_dev *dev)
{ {
dprintk(1, "%s()\n", __func__); dprintk(1, "%s()\n", __func__);
memcpy(&dev->i2c_adap, &au0828_i2c_adap_template, dev->i2c_adap = au0828_i2c_adap_template;
sizeof(dev->i2c_adap)); dev->i2c_algo = au0828_i2c_algo_template;
memcpy(&dev->i2c_algo, &au0828_i2c_algo_template, dev->i2c_client = au0828_i2c_client_template;
sizeof(dev->i2c_algo));
memcpy(&dev->i2c_client, &au0828_i2c_client_template,
sizeof(dev->i2c_client));
dev->i2c_adap.dev.parent = &dev->usbdev->dev; dev->i2c_adap.dev.parent = &dev->usbdev->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment