Commit f17c8607 authored by Rusty Russell's avatar Rusty Russell Committed by Ingo Molnar

sched: convert sys_sched_getaffinity() to cpumask_var_t.

Impact: stack usage reduction

Dynamically allocating cpumasks (when CONFIG_CPUMASK_OFFSTACK) saves
space in the stack.  cpumask_var_t is just a struct cpumask for
!CONFIG_CPUMASK_OFFSTACK.

Some jiggling here to make sure we always exit at the bottom (so we hit
the free_cpumask_var there).
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent a0e90245
...@@ -5499,19 +5499,24 @@ asmlinkage long sys_sched_getaffinity(pid_t pid, unsigned int len, ...@@ -5499,19 +5499,24 @@ asmlinkage long sys_sched_getaffinity(pid_t pid, unsigned int len,
unsigned long __user *user_mask_ptr) unsigned long __user *user_mask_ptr)
{ {
int ret; int ret;
cpumask_t mask; cpumask_var_t mask;
if (len < sizeof(cpumask_t)) if (len < cpumask_size())
return -EINVAL; return -EINVAL;
ret = sched_getaffinity(pid, &mask); if (!alloc_cpumask_var(&mask, GFP_KERNEL))
if (ret < 0) return -ENOMEM;
return ret;
if (copy_to_user(user_mask_ptr, &mask, sizeof(cpumask_t))) ret = sched_getaffinity(pid, mask);
return -EFAULT; if (ret == 0) {
if (copy_to_user(user_mask_ptr, mask, cpumask_size()))
ret = -EFAULT;
else
ret = cpumask_size();
}
free_cpumask_var(mask);
return sizeof(cpumask_t); return ret;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment