Commit f58a4d51 authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Alexei Starovoitov

samples/bpf: convert xdp_sample_pkts_user to perf_buffer API

Convert xdp_sample_pkts_user to libbpf's perf_buffer API.
Signed-off-by: default avatarAndrii Nakryiko <andriin@fb.com>
Acked-by: default avatarSong Liu <songliubraving@fb.com>
Acked-by: default avatarToke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 898ca681
...@@ -17,14 +17,13 @@ ...@@ -17,14 +17,13 @@
#include <linux/if_link.h> #include <linux/if_link.h>
#include "perf-sys.h" #include "perf-sys.h"
#include "trace_helpers.h"
#define MAX_CPUS 128 #define MAX_CPUS 128
static int pmu_fds[MAX_CPUS], if_idx; static int if_idx;
static struct perf_event_mmap_page *headers[MAX_CPUS];
static char *if_name; static char *if_name;
static __u32 xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST; static __u32 xdp_flags = XDP_FLAGS_UPDATE_IF_NOEXIST;
static __u32 prog_id; static __u32 prog_id;
static struct perf_buffer *pb = NULL;
static int do_attach(int idx, int fd, const char *name) static int do_attach(int idx, int fd, const char *name)
{ {
...@@ -73,7 +72,7 @@ static int do_detach(int idx, const char *name) ...@@ -73,7 +72,7 @@ static int do_detach(int idx, const char *name)
#define SAMPLE_SIZE 64 #define SAMPLE_SIZE 64
static int print_bpf_output(void *data, int size) static void print_bpf_output(void *ctx, int cpu, void *data, __u32 size)
{ {
struct { struct {
__u16 cookie; __u16 cookie;
...@@ -83,45 +82,20 @@ static int print_bpf_output(void *data, int size) ...@@ -83,45 +82,20 @@ static int print_bpf_output(void *data, int size)
int i; int i;
if (e->cookie != 0xdead) { if (e->cookie != 0xdead) {
printf("BUG cookie %x sized %d\n", printf("BUG cookie %x sized %d\n", e->cookie, size);
e->cookie, size); return;
return LIBBPF_PERF_EVENT_ERROR;
} }
printf("Pkt len: %-5d bytes. Ethernet hdr: ", e->pkt_len); printf("Pkt len: %-5d bytes. Ethernet hdr: ", e->pkt_len);
for (i = 0; i < 14 && i < e->pkt_len; i++) for (i = 0; i < 14 && i < e->pkt_len; i++)
printf("%02x ", e->pkt_data[i]); printf("%02x ", e->pkt_data[i]);
printf("\n"); printf("\n");
return LIBBPF_PERF_EVENT_CONT;
}
static void test_bpf_perf_event(int map_fd, int num)
{
struct perf_event_attr attr = {
.sample_type = PERF_SAMPLE_RAW,
.type = PERF_TYPE_SOFTWARE,
.config = PERF_COUNT_SW_BPF_OUTPUT,
.wakeup_events = 1, /* get an fd notification for every event */
};
int i;
for (i = 0; i < num; i++) {
int key = i;
pmu_fds[i] = sys_perf_event_open(&attr, -1/*pid*/, i/*cpu*/,
-1/*group_fd*/, 0);
assert(pmu_fds[i] >= 0);
assert(bpf_map_update_elem(map_fd, &key,
&pmu_fds[i], BPF_ANY) == 0);
ioctl(pmu_fds[i], PERF_EVENT_IOC_ENABLE, 0);
}
} }
static void sig_handler(int signo) static void sig_handler(int signo)
{ {
do_detach(if_idx, if_name); do_detach(if_idx, if_name);
perf_buffer__free(pb);
exit(0); exit(0);
} }
...@@ -140,13 +114,13 @@ int main(int argc, char **argv) ...@@ -140,13 +114,13 @@ int main(int argc, char **argv)
struct bpf_prog_load_attr prog_load_attr = { struct bpf_prog_load_attr prog_load_attr = {
.prog_type = BPF_PROG_TYPE_XDP, .prog_type = BPF_PROG_TYPE_XDP,
}; };
struct perf_buffer_opts pb_opts = {};
const char *optstr = "F"; const char *optstr = "F";
int prog_fd, map_fd, opt; int prog_fd, map_fd, opt;
struct bpf_object *obj; struct bpf_object *obj;
struct bpf_map *map; struct bpf_map *map;
char filename[256]; char filename[256];
int ret, err, i; int ret, err;
int numcpus;
while ((opt = getopt(argc, argv, optstr)) != -1) { while ((opt = getopt(argc, argv, optstr)) != -1) {
switch (opt) { switch (opt) {
...@@ -169,10 +143,6 @@ int main(int argc, char **argv) ...@@ -169,10 +143,6 @@ int main(int argc, char **argv)
return 1; return 1;
} }
numcpus = get_nprocs();
if (numcpus > MAX_CPUS)
numcpus = MAX_CPUS;
snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]); snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]);
prog_load_attr.file = filename; prog_load_attr.file = filename;
...@@ -211,14 +181,17 @@ int main(int argc, char **argv) ...@@ -211,14 +181,17 @@ int main(int argc, char **argv)
return 1; return 1;
} }
test_bpf_perf_event(map_fd, numcpus); pb_opts.sample_cb = print_bpf_output;
pb = perf_buffer__new(map_fd, 8, &pb_opts);
err = libbpf_get_error(pb);
if (err) {
perror("perf_buffer setup failed");
return 1;
}
for (i = 0; i < numcpus; i++) while ((ret = perf_buffer__poll(pb, 1000)) >= 0) {
if (perf_event_mmap_header(pmu_fds[i], &headers[i]) < 0) }
return 1;
ret = perf_event_poller_multi(pmu_fds, headers, numcpus,
print_bpf_output);
kill(0, SIGINT); kill(0, SIGINT);
return ret; return ret;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment