Commit f597a579 authored by YueHaibing's avatar YueHaibing Committed by David Howells

rxrpc: remove redundant variables 'sp' and 'did_discard'

Variables 'sp' and 'did_discard' are being assigned,
but are never used, hence they are redundant and can be removed.

fix following warning:

net/rxrpc/call_event.c:165:25: warning: variable 'sp' set but not used [-Wunused-but-set-variable]
net/rxrpc/conn_client.c:1054:7: warning: variable 'did_discard' set but not used [-Wunused-but-set-variable]
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent e6476c21
...@@ -162,7 +162,6 @@ static void rxrpc_congestion_timeout(struct rxrpc_call *call) ...@@ -162,7 +162,6 @@ static void rxrpc_congestion_timeout(struct rxrpc_call *call)
*/ */
static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j) static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j)
{ {
struct rxrpc_skb_priv *sp;
struct sk_buff *skb; struct sk_buff *skb;
unsigned long resend_at; unsigned long resend_at;
rxrpc_seq_t cursor, seq, top; rxrpc_seq_t cursor, seq, top;
...@@ -207,7 +206,6 @@ static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j) ...@@ -207,7 +206,6 @@ static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j)
skb = call->rxtx_buffer[ix]; skb = call->rxtx_buffer[ix];
rxrpc_see_skb(skb, rxrpc_skb_tx_seen); rxrpc_see_skb(skb, rxrpc_skb_tx_seen);
sp = rxrpc_skb(skb);
if (anno_type == RXRPC_TX_ANNO_UNACK) { if (anno_type == RXRPC_TX_ANNO_UNACK) {
if (ktime_after(skb->tstamp, max_age)) { if (ktime_after(skb->tstamp, max_age)) {
......
...@@ -1051,7 +1051,6 @@ void rxrpc_discard_expired_client_conns(struct work_struct *work) ...@@ -1051,7 +1051,6 @@ void rxrpc_discard_expired_client_conns(struct work_struct *work)
container_of(work, struct rxrpc_net, client_conn_reaper); container_of(work, struct rxrpc_net, client_conn_reaper);
unsigned long expiry, conn_expires_at, now; unsigned long expiry, conn_expires_at, now;
unsigned int nr_conns; unsigned int nr_conns;
bool did_discard = false;
_enter(""); _enter("");
...@@ -1113,7 +1112,6 @@ void rxrpc_discard_expired_client_conns(struct work_struct *work) ...@@ -1113,7 +1112,6 @@ void rxrpc_discard_expired_client_conns(struct work_struct *work)
* If someone re-sets the flag and re-gets the ref, that's fine. * If someone re-sets the flag and re-gets the ref, that's fine.
*/ */
rxrpc_put_connection(conn); rxrpc_put_connection(conn);
did_discard = true;
nr_conns--; nr_conns--;
goto next; goto next;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment