Commit f68e492c authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart (VMware)

platform/x86: fujitsu-laptop: rename call_fext_func() arguments

Rename call_fext_func() arguments so that each argument's name signifies
its role:

  - cmd -> func: sub-function to call (flags, buttons etc.),
  - arg0 -> op: operation to perform (get, set, get capabilities etc.),
  - arg1 -> feature: feature to act on (e.g. which LED), if relevant,
  - arg2 -> state: state to set (e.g. LED on or off), if relevant.

Adjust whitespace to make checkpatch happy.
Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Reviewed-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 17e23555
...@@ -217,13 +217,13 @@ static u32 dbg_level = 0x03; ...@@ -217,13 +217,13 @@ static u32 dbg_level = 0x03;
/* Fujitsu ACPI interface function */ /* Fujitsu ACPI interface function */
static int call_fext_func(int cmd, int arg0, int arg1, int arg2) static int call_fext_func(int func, int op, int feature, int state)
{ {
union acpi_object params[4] = { union acpi_object params[4] = {
{ .integer.type = ACPI_TYPE_INTEGER, .integer.value = cmd }, { .integer.type = ACPI_TYPE_INTEGER, .integer.value = func },
{ .integer.type = ACPI_TYPE_INTEGER, .integer.value = arg0 }, { .integer.type = ACPI_TYPE_INTEGER, .integer.value = op },
{ .integer.type = ACPI_TYPE_INTEGER, .integer.value = arg1 }, { .integer.type = ACPI_TYPE_INTEGER, .integer.value = feature },
{ .integer.type = ACPI_TYPE_INTEGER, .integer.value = arg2 } { .integer.type = ACPI_TYPE_INTEGER, .integer.value = state }
}; };
struct acpi_object_list arg_list = { 4, params }; struct acpi_object_list arg_list = { 4, params };
unsigned long long value; unsigned long long value;
...@@ -236,9 +236,8 @@ static int call_fext_func(int cmd, int arg0, int arg1, int arg2) ...@@ -236,9 +236,8 @@ static int call_fext_func(int cmd, int arg0, int arg1, int arg2)
return -ENODEV; return -ENODEV;
} }
vdbg_printk(FUJLAPTOP_DBG_TRACE, vdbg_printk(FUJLAPTOP_DBG_TRACE, "FUNC 0x%x (args 0x%x, 0x%x, 0x%x) returned 0x%x\n",
"FUNC 0x%x (args 0x%x, 0x%x, 0x%x) returned 0x%x\n", func, op, feature, state, (int)value);
cmd, arg0, arg1, arg2, (int)value);
return value; return value;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment