Commit f8fb3419 authored by Linus Lüssing's avatar Linus Lüssing Committed by Simon Wunderlich

batman-adv: fix multicast-via-unicast transmission with AP isolation

For multicast frames AP isolation is only supposed to be checked on
the receiving nodes and never on the originating one.

Furthermore, the isolation or wifi flag bits should only be intepreted
as such for unicast and never multicast TT entries.

By injecting flags to the multicast TT entry claimed by a single
target node it was verified in tests that this multicast address
becomes unreachable, leading to packet loss.

Omitting the "src" parameter to the batadv_transtable_search() call
successfully skipped the AP isolation check and made the target
reachable again.

Fixes: 1d8ab8d3 ("batman-adv: Modified forwarding behaviour for multicast packets")
Signed-off-by: default avatarLinus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent fc04fdb2
...@@ -814,8 +814,8 @@ static struct batadv_orig_node * ...@@ -814,8 +814,8 @@ static struct batadv_orig_node *
batadv_mcast_forw_tt_node_get(struct batadv_priv *bat_priv, batadv_mcast_forw_tt_node_get(struct batadv_priv *bat_priv,
struct ethhdr *ethhdr) struct ethhdr *ethhdr)
{ {
return batadv_transtable_search(bat_priv, ethhdr->h_source, return batadv_transtable_search(bat_priv, NULL, ethhdr->h_dest,
ethhdr->h_dest, BATADV_NO_FLAGS); BATADV_NO_FLAGS);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment