Commit f9d42491 authored by Roel Kluin's avatar Roel Kluin Committed by Jeff Garzik

pata_bf54x: decrease count first.

When count reaches 0 the postfix decrement still subtracts (to -1),
so bfin_reset_controller() returns as if the busy flag was cleared
while it was not.
Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
Acked-by: default avatarSonic Zhang <sonic.zhang@analog.com>
Signed-off-by: default avatarBryan Wu <cooloney@kernel.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 85afb934
...@@ -1417,7 +1417,7 @@ static int bfin_reset_controller(struct ata_host *host) ...@@ -1417,7 +1417,7 @@ static int bfin_reset_controller(struct ata_host *host)
count = 10000000; count = 10000000;
do { do {
status = read_atapi_register(base, ATA_REG_STATUS); status = read_atapi_register(base, ATA_REG_STATUS);
} while (count-- && (status & ATA_BUSY)); } while (--count && (status & ATA_BUSY));
/* Enable only ATAPI Device interrupt */ /* Enable only ATAPI Device interrupt */
ATAPI_SET_INT_MASK(base, 1); ATAPI_SET_INT_MASK(base, 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment