Commit fa407188 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe

RDMA/rxe: Move rxe_init_av() to rxe_av.c

Move the function rxe_init_av() to rxe_av.c file and use it instead of
calling rxe_av_from_attr() and rxe_av_fill_ip_info(), also remove the
unused rxe_dev parameter from rxe_init_av().
Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent c3c668e7
...@@ -34,6 +34,12 @@ ...@@ -34,6 +34,12 @@
#include "rxe.h" #include "rxe.h"
#include "rxe_loc.h" #include "rxe_loc.h"
void rxe_init_av(struct rdma_ah_attr *attr, struct rxe_av *av)
{
rxe_av_from_attr(rdma_ah_get_port_num(attr), av, attr);
rxe_av_fill_ip_info(av, attr);
}
int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr) int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr)
{ {
struct rxe_port *port; struct rxe_port *port;
......
...@@ -35,6 +35,7 @@ ...@@ -35,6 +35,7 @@
#define RXE_LOC_H #define RXE_LOC_H
/* rxe_av.c */ /* rxe_av.c */
void rxe_init_av(struct rdma_ah_attr *attr, struct rxe_av *av);
int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr); int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr);
......
...@@ -631,14 +631,11 @@ int rxe_qp_from_attr(struct rxe_qp *qp, struct ib_qp_attr *attr, int mask, ...@@ -631,14 +631,11 @@ int rxe_qp_from_attr(struct rxe_qp *qp, struct ib_qp_attr *attr, int mask,
qp->attr.qkey = attr->qkey; qp->attr.qkey = attr->qkey;
if (mask & IB_QP_AV) { if (mask & IB_QP_AV) {
rxe_av_from_attr(attr->port_num, &qp->pri_av, &attr->ah_attr); rxe_init_av(&attr->ah_attr, &qp->pri_av);
rxe_av_fill_ip_info(&qp->pri_av, &attr->ah_attr);
} }
if (mask & IB_QP_ALT_PATH) { if (mask & IB_QP_ALT_PATH) {
rxe_av_from_attr(attr->alt_port_num, &qp->alt_av, rxe_init_av(&attr->alt_ah_attr, &qp->alt_av);
&attr->alt_ah_attr);
rxe_av_fill_ip_info(&qp->alt_av, &attr->alt_ah_attr);
qp->attr.alt_port_num = attr->alt_port_num; qp->attr.alt_port_num = attr->alt_port_num;
qp->attr.alt_pkey_index = attr->alt_pkey_index; qp->attr.alt_pkey_index = attr->alt_pkey_index;
qp->attr.alt_timeout = attr->alt_timeout; qp->attr.alt_timeout = attr->alt_timeout;
......
...@@ -210,13 +210,6 @@ static int rxe_dealloc_pd(struct ib_pd *ibpd) ...@@ -210,13 +210,6 @@ static int rxe_dealloc_pd(struct ib_pd *ibpd)
return 0; return 0;
} }
static void rxe_init_av(struct rxe_dev *rxe, struct rdma_ah_attr *attr,
struct rxe_av *av)
{
rxe_av_from_attr(rdma_ah_get_port_num(attr), av, attr);
rxe_av_fill_ip_info(av, attr);
}
static struct ib_ah *rxe_create_ah(struct ib_pd *ibpd, static struct ib_ah *rxe_create_ah(struct ib_pd *ibpd,
struct rdma_ah_attr *attr, struct rdma_ah_attr *attr,
u32 flags, u32 flags,
...@@ -239,7 +232,7 @@ static struct ib_ah *rxe_create_ah(struct ib_pd *ibpd, ...@@ -239,7 +232,7 @@ static struct ib_ah *rxe_create_ah(struct ib_pd *ibpd,
rxe_add_ref(pd); rxe_add_ref(pd);
ah->pd = pd; ah->pd = pd;
rxe_init_av(rxe, attr, &ah->av); rxe_init_av(attr, &ah->av);
return &ah->ibah; return &ah->ibah;
} }
...@@ -253,7 +246,7 @@ static int rxe_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr) ...@@ -253,7 +246,7 @@ static int rxe_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr)
if (err) if (err)
return err; return err;
rxe_init_av(rxe, attr, &ah->av); rxe_init_av(attr, &ah->av);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment