[ARM PATCH] 2111/1: restrict scope of PXA2xx register definitions

Patch from Nicolas Pitre It's a rather bad idea to have psa-regs.h included all the time. It's rather large and likely to create namespace clashes, as well as slowing down the build unnecessarily. Better include it explicitly where it is actually needed. Signed-off-by: Nicolas Pitre

[ARM PATCH] 2111/1: restrict scope of PXA2xx register definitions
Patch from Nicolas Pitre It's a rather bad idea to have psa-regs.h included all the time. It's rather large and likely to create namespace clashes, as well as slowing down the build unnecessarily. Better include it explicitly where it is actually needed. Signed-off-by: Nicolas Pitre
fb7b0e27 · Nicolas Pitre · Russell King · 82803ae3 · fb7b0e27 · fb7b0e27
Commit fb7b0e27 authored Sep 30, 2004 by Nicolas Pitre Committed by Russell King Sep 30, 2004
24 changed files
--- a/arch/arm/common/sa1111.c
+++ b/arch/arm/common/sa1111.c
@@ -35,6 +35,10 @@

 #include <asm/hardware/sa1111.h>

+#ifdef CONFIG_ARCH_PXA
+#include <asm/arch/pxa-regs.h>
+#endif
+
 extern void __init sa1110_mb_enable(void);

 /*

--- a/arch/arm/mach-pxa/dma.c
+++ b/arch/arm/mach-pxa/dma.c
@@ -23,6 +23,7 @@
 #include <asm/hardware.h>
 #include <asm/dma.h>

+#include <asm/arch/pxa-regs.h>

 static struct dma_channel {
 	char *name;

--- a/arch/arm/mach-pxa/generic.c
+++ b/arch/arm/mach-pxa/generic.c
@@ -30,6 +30,7 @@
 #include <asm/pgtable.h>
 #include <asm/mach/map.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/udc.h>
 #include <asm/arch/pxafb.h>
 #include <asm/arch/mmc.h>

--- a/arch/arm/mach-pxa/idp.c
+++ b/arch/arm/mach-pxa/idp.c
@@ -27,6 +27,7 @@
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/idp.h>

 #include "generic.h"

--- a/arch/arm/mach-pxa/irq.c
+++ b/arch/arm/mach-pxa/irq.c
@@ -20,6 +20,7 @@
 #include <asm/hardware.h>
 #include <asm/irq.h>
 #include <asm/mach/irq.h>
+#include <asm/arch/pxa-regs.h>

 #include "generic.h"


--- a/arch/arm/mach-pxa/leds-lubbock.c
+++ b/arch/arm/mach-pxa/leds-lubbock.c
@@ -17,6 +17,7 @@
 #include <asm/hardware.h>
 #include <asm/leds.h>
 #include <asm/system.h>
+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/lubbock.h>

 #include "leds.h"

--- a/arch/arm/mach-pxa/leds-mainstone.c
+++ b/arch/arm/mach-pxa/leds-mainstone.c
@@ -17,6 +17,7 @@
 #include <asm/leds.h>
 #include <asm/system.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/mainstone.h>

 #include "leds.h"

--- a/arch/arm/mach-pxa/lubbock.c
+++ b/arch/arm/mach-pxa/lubbock.c
@@ -29,6 +29,7 @@
 #include <asm/mach/map.h>
 #include <asm/mach/irq.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/lubbock.h>
 #include <asm/arch/udc.h>
 #include <asm/arch/pxafb.h>

--- a/arch/arm/mach-pxa/mainstone.c
+++ b/arch/arm/mach-pxa/mainstone.c
@@ -31,6 +31,7 @@
 #include <asm/mach/map.h>
 #include <asm/mach/irq.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/mainstone.h>
 #include <asm/arch/pxafb.h>


--- a/arch/arm/mach-pxa/pm.c
+++ b/arch/arm/mach-pxa/pm.c
@@ -19,6 +19,7 @@
 #include <asm/hardware.h>
 #include <asm/memory.h>
 #include <asm/system.h>
+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/lubbock.h>



--- a/arch/arm/mach-pxa/pxa25x.c
+++ b/arch/arm/mach-pxa/pxa25x.c
@@ -22,6 +22,7 @@
 #include <linux/pm.h>

 #include <asm/hardware.h>
+#include <asm/arch/pxa-regs.h>

 #include "generic.h"


--- a/arch/arm/mach-pxa/pxa27x.c
+++ b/arch/arm/mach-pxa/pxa27x.c
@@ -14,6 +14,7 @@
 #include <linux/config.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <asm/arch/pxa-regs.h>
 #include <linux/init.h>
 #include <linux/pm.h>


--- a/arch/arm/mach-pxa/time.c
+++ b/arch/arm/mach-pxa/time.c
@@ -27,6 +27,7 @@
 #include <asm/irq.h>
 #include <asm/mach/irq.h>
 #include <asm/mach/time.h>
+#include <asm/arch/pxa-regs.h>


 static inline unsigned long pxa_get_rtc_time(void)

--- a/drivers/mmc/pxamci.c
+++ b/drivers/mmc/pxamci.c
@@ -33,6 +33,7 @@
 #include <asm/irq.h>
 #include <asm/sizes.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/mmc.h>

 #include "pxamci.h"

--- a/drivers/pcmcia/pxa2xx_base.c
+++ b/drivers/pcmcia/pxa2xx_base.c
@@ -28,6 +28,7 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 #include <asm/system.h>
+#include <asm/arch/pxa-regs.h>

 #include <pcmcia/cs_types.h>
 #include <pcmcia/ss.h>

--- a/drivers/pcmcia/pxa2xx_lubbock.c
+++ b/drivers/pcmcia/pxa2xx_lubbock.c
@@ -25,6 +25,7 @@
 #include <asm/hardware.h>
 #include <asm/hardware/sa1111.h>
 #include <asm/mach-types.h>
+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/lubbock.h>

 #include "sa1111_generic.h"

--- a/drivers/pcmcia/pxa2xx_mainstone.c
+++ b/drivers/pcmcia/pxa2xx_mainstone.c
@@ -24,6 +24,7 @@
 #include <asm/hardware.h>
 #include <asm/irq.h>

+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/mainstone.h>

 #include "soc_common.h"

--- a/drivers/pcmcia/soc_common.c
+++ b/drivers/pcmcia/soc_common.c
@@ -49,6 +49,11 @@

 #include "soc_common.h"

+/* FIXME: platform dependent resource declaration has to move out of this file */
+#ifdef CONFIG_ARCH_PXA
+#include <asm/arch/pxa-regs.h>
+#endif
+
 #ifdef DEBUG

 static int pc_debug;

--- a/drivers/serial/pxa.c
+++ b/drivers/serial/pxa.c
@@ -40,6 +40,7 @@
 #include <asm/io.h>
 #include <asm/hardware.h>
 #include <asm/irq.h>
+#include <asm/arch/pxa-regs.h>

 #if defined(CONFIG_SERIAL_PXA_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
 #define SUPPORT_SYSRQ

--- a/drivers/usb/gadget/pxa2xx_udc.c
+++ b/drivers/usb/gadget/pxa2xx_udc.c
@@ -54,6 +54,7 @@
 #include <asm/mach-types.h>
 #include <asm/unaligned.h>
 #include <asm/hardware.h>
+#include <asm/arch/pxa-regs.h>

 #include <linux/usb_ch9.h>
 #include <linux/usb_gadget.h>

--- a/drivers/video/pxafb.c
+++ b/drivers/video/pxafb.c
@@ -43,6 +43,7 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 #include <asm/uaccess.h>
+#include <asm/arch/pxa-regs.h>
 #include <asm/arch/bitfield.h>
 #include <asm/arch/pxafb.h>


--- a/include/asm-arm/arch-pxa/hardware.h
+++ b/include/asm-arm/arch-pxa/hardware.h
@@ -72,8 +72,6 @@ typedef struct { volatile u32 offset[4096]; } __regbase;

 #endif

-#include "pxa-regs.h"
-
 #ifndef __ASSEMBLY__

 /*

--- a/include/asm-arm/arch-pxa/pxa-regs.h
+++ b/include/asm-arm/arch-pxa/pxa-regs.h
@@ -15,17 +15,6 @@

 #include <linux/config.h>

-// FIXME hack so that SA-1111.h will work [cb]
-
-#ifndef __ASSEMBLY__
-typedef unsigned short  Word16 ;
-typedef unsigned int    Word32 ;
-typedef Word32          Word ;
-typedef Word            Quad [4] ;
-typedef void            *Address ;
-typedef void            (*ExcpHndlr) (void) ;
-#endif
-
 /*
 * PXA Chip selects
 */

--- a/include/asm-arm/arch-pxa/system.h
+++ b/include/asm-arm/arch-pxa/system.h
@@ -11,6 +11,7 @@
 */

 #include "hardware.h"
+#include "pxa-regs.h"

 static inline void arch_idle(void)
 {