Commit fbdab3e7 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen

scsi: aacraid: remove redundant zero check on ret

The check for ret being zero is redundant as a few statements earlier we
break out of the while loop if ret is non-zero.  Thus we can remove the
zero check and also the dead-code non-zero case too.

Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarDave Carroll <david.carroll@microsemi.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 825c6abb
...@@ -2508,8 +2508,7 @@ int aac_command_thread(void *data) ...@@ -2508,8 +2508,7 @@ int aac_command_thread(void *data)
&& (now.tv_usec > (1000000 / HZ))) && (now.tv_usec > (1000000 / HZ)))
difference = (((1000000 - now.tv_usec) * HZ) difference = (((1000000 - now.tv_usec) * HZ)
+ 500000) / 1000000; + 500000) / 1000000;
else if (ret == 0) { else {
if (now.tv_usec > 500000) if (now.tv_usec > 500000)
++now.tv_sec; ++now.tv_sec;
...@@ -2520,9 +2519,6 @@ int aac_command_thread(void *data) ...@@ -2520,9 +2519,6 @@ int aac_command_thread(void *data)
ret = aac_send_hosttime(dev, &now); ret = aac_send_hosttime(dev, &now);
difference = (long)(unsigned)update_interval*HZ; difference = (long)(unsigned)update_interval*HZ;
} else {
/* retry shortly */
difference = 10 * HZ;
} }
next_jiffies = jiffies + difference; next_jiffies = jiffies + difference;
if (time_before(next_check_jiffies,next_jiffies)) if (time_before(next_check_jiffies,next_jiffies))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment