Commit fd45c15f authored by Namhyung Kim's avatar Namhyung Kim Committed by Ingo Molnar

perf: Don't call release_callchain_buffers() if allocation fails

When alloc_callchain_buffers() fails, it frees all of
entries before return. In addition, calling the
release_callchain_buffers() will cause a NULL pointer
dereference since callchain_cpu_entries is not set.
Signed-off-by: default avatarNamhyung Kim <namhyung.kim@lge.com>
Acked-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Link: http://lkml.kernel.org/r/1327021966-27688-1-git-send-email-namhyung.kim@lge.comSigned-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent dcd6c922
...@@ -115,8 +115,6 @@ int get_callchain_buffers(void) ...@@ -115,8 +115,6 @@ int get_callchain_buffers(void)
} }
err = alloc_callchain_buffers(); err = alloc_callchain_buffers();
if (err)
release_callchain_buffers();
exit: exit:
mutex_unlock(&callchain_mutex); mutex_unlock(&callchain_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment