Commit fdd1a810 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

net: atm: clean up a range check

The code works fine but the problem is that check for negatives is a
no-op:

	if (arg < 0)
		i = 0;

The "i" value isn't used.  We immediately overwrite it with:

	i = array_index_nospec(arg, MAX_LEC_ITF);

The array_index_nospec() macro returns zero if "arg" is out of bounds so
this works, but the dead code is confusing and it doesn't look very
intentional.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6ffe0acc
...@@ -726,9 +726,7 @@ static int lecd_attach(struct atm_vcc *vcc, int arg) ...@@ -726,9 +726,7 @@ static int lecd_attach(struct atm_vcc *vcc, int arg)
struct lec_priv *priv; struct lec_priv *priv;
if (arg < 0) if (arg < 0)
i = 0; arg = 0;
else
i = arg;
if (arg >= MAX_LEC_ITF) if (arg >= MAX_LEC_ITF)
return -EINVAL; return -EINVAL;
i = array_index_nospec(arg, MAX_LEC_ITF); i = array_index_nospec(arg, MAX_LEC_ITF);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment