Commit fe39f945 authored by Thomas Meyer's avatar Thomas Meyer Committed by Greg Kroah-Hartman

staging: brcm80211: use kstrdup()

 Use kstrdup rather than duplicating its implementation

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/kstrdup.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 5349d3d8
...@@ -928,7 +928,7 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg) ...@@ -928,7 +928,7 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg)
int i = 0; int i = 0;
char *arg_save = 0, *arg_org = 0; char *arg_save = 0, *arg_org = 0;
arg_save = kmalloc(strlen(arg) + 1, GFP_ATOMIC); arg_save = kstrdup(arg, GFP_ATOMIC);
if (!arg_save) { if (!arg_save) {
BRCMF_ERROR(("%s: kmalloc failed\n", __func__)); BRCMF_ERROR(("%s: kmalloc failed\n", __func__));
goto fail; goto fail;
...@@ -942,8 +942,6 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg) ...@@ -942,8 +942,6 @@ void brcmf_c_pktfilter_offload_set(struct brcmf_pub *drvr, char *arg)
goto fail; goto fail;
} }
strcpy(arg_save, arg);
argv[i] = strsep(&arg_save, " "); argv[i] = strsep(&arg_save, " ");
while (argv[i++]) while (argv[i++])
argv[i] = strsep(&arg_save, " "); argv[i] = strsep(&arg_save, " ");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment