Commit fe955682 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Len Brown

ACPI / EC / PM: Fix names of functions that block/unblock EC transactions

The names of the functions used for blocking/unblocking EC
transactions during suspend/hibernation suggest that the transactions
are suspended and resumed by them, while in fact they are disabled
and enabled.  Rename the functions (and the flag used by them) to
better reflect what they really do.
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent d5a64513
...@@ -79,7 +79,7 @@ enum { ...@@ -79,7 +79,7 @@ enum {
EC_FLAGS_GPE_STORM, /* GPE storm detected */ EC_FLAGS_GPE_STORM, /* GPE storm detected */
EC_FLAGS_HANDLERS_INSTALLED, /* Handlers for GPE and EC_FLAGS_HANDLERS_INSTALLED, /* Handlers for GPE and
* OpReg are installed */ * OpReg are installed */
EC_FLAGS_FROZEN, /* Transactions are suspended */ EC_FLAGS_BLOCKED, /* Transactions are blocked */
}; };
/* If we find an EC via the ECDT, we need to keep a ptr to its context */ /* If we find an EC via the ECDT, we need to keep a ptr to its context */
...@@ -293,7 +293,7 @@ static int acpi_ec_transaction(struct acpi_ec *ec, struct transaction *t) ...@@ -293,7 +293,7 @@ static int acpi_ec_transaction(struct acpi_ec *ec, struct transaction *t)
if (t->rdata) if (t->rdata)
memset(t->rdata, 0, t->rlen); memset(t->rdata, 0, t->rlen);
mutex_lock(&ec->lock); mutex_lock(&ec->lock);
if (test_bit(EC_FLAGS_FROZEN, &ec->flags)) { if (test_bit(EC_FLAGS_BLOCKED, &ec->flags)) {
status = -EINVAL; status = -EINVAL;
goto unlock; goto unlock;
} }
...@@ -459,7 +459,7 @@ int ec_transaction(u8 command, ...@@ -459,7 +459,7 @@ int ec_transaction(u8 command,
EXPORT_SYMBOL(ec_transaction); EXPORT_SYMBOL(ec_transaction);
void acpi_ec_suspend_transactions(void) void acpi_ec_block_transactions(void)
{ {
struct acpi_ec *ec = first_ec; struct acpi_ec *ec = first_ec;
...@@ -468,11 +468,11 @@ void acpi_ec_suspend_transactions(void) ...@@ -468,11 +468,11 @@ void acpi_ec_suspend_transactions(void)
mutex_lock(&ec->lock); mutex_lock(&ec->lock);
/* Prevent transactions from being carried out */ /* Prevent transactions from being carried out */
set_bit(EC_FLAGS_FROZEN, &ec->flags); set_bit(EC_FLAGS_BLOCKED, &ec->flags);
mutex_unlock(&ec->lock); mutex_unlock(&ec->lock);
} }
void acpi_ec_resume_transactions(void) void acpi_ec_unblock_transactions(void)
{ {
struct acpi_ec *ec = first_ec; struct acpi_ec *ec = first_ec;
...@@ -481,18 +481,18 @@ void acpi_ec_resume_transactions(void) ...@@ -481,18 +481,18 @@ void acpi_ec_resume_transactions(void)
mutex_lock(&ec->lock); mutex_lock(&ec->lock);
/* Allow transactions to be carried out again */ /* Allow transactions to be carried out again */
clear_bit(EC_FLAGS_FROZEN, &ec->flags); clear_bit(EC_FLAGS_BLOCKED, &ec->flags);
mutex_unlock(&ec->lock); mutex_unlock(&ec->lock);
} }
void acpi_ec_resume_transactions_early(void) void acpi_ec_unblock_transactions_early(void)
{ {
/* /*
* Allow transactions to happen again (this function is called from * Allow transactions to happen again (this function is called from
* atomic context during wakeup, so we don't need to acquire the mutex). * atomic context during wakeup, so we don't need to acquire the mutex).
*/ */
if (first_ec) if (first_ec)
clear_bit(EC_FLAGS_FROZEN, &first_ec->flags); clear_bit(EC_FLAGS_BLOCKED, &first_ec->flags);
} }
static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data) static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
......
...@@ -49,9 +49,9 @@ void acpi_early_processor_set_pdc(void); ...@@ -49,9 +49,9 @@ void acpi_early_processor_set_pdc(void);
int acpi_ec_init(void); int acpi_ec_init(void);
int acpi_ec_ecdt_probe(void); int acpi_ec_ecdt_probe(void);
int acpi_boot_ec_enable(void); int acpi_boot_ec_enable(void);
void acpi_ec_suspend_transactions(void); void acpi_ec_block_transactions(void);
void acpi_ec_resume_transactions(void); void acpi_ec_unblock_transactions(void);
void acpi_ec_resume_transactions_early(void); void acpi_ec_unblock_transactions_early(void);
/*-------------------------------------------------------------------------- /*--------------------------------------------------------------------------
Suspend/Resume Suspend/Resume
......
...@@ -116,7 +116,7 @@ static int acpi_pm_freeze(void) ...@@ -116,7 +116,7 @@ static int acpi_pm_freeze(void)
{ {
acpi_disable_all_gpes(); acpi_disable_all_gpes();
acpi_os_wait_events_complete(NULL); acpi_os_wait_events_complete(NULL);
acpi_ec_suspend_transactions(); acpi_ec_block_transactions();
return 0; return 0;
} }
...@@ -279,7 +279,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) ...@@ -279,7 +279,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state)
*/ */
acpi_disable_all_gpes(); acpi_disable_all_gpes();
/* Allow EC transactions to happen. */ /* Allow EC transactions to happen. */
acpi_ec_resume_transactions_early(); acpi_ec_unblock_transactions_early();
local_irq_restore(flags); local_irq_restore(flags);
printk(KERN_DEBUG "Back to C!\n"); printk(KERN_DEBUG "Back to C!\n");
...@@ -293,7 +293,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) ...@@ -293,7 +293,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state)
static void acpi_suspend_finish(void) static void acpi_suspend_finish(void)
{ {
acpi_ec_resume_transactions(); acpi_ec_unblock_transactions();
acpi_pm_finish(); acpi_pm_finish();
} }
...@@ -597,7 +597,7 @@ static int acpi_hibernation_enter(void) ...@@ -597,7 +597,7 @@ static int acpi_hibernation_enter(void)
static void acpi_hibernation_finish(void) static void acpi_hibernation_finish(void)
{ {
hibernate_nvs_free(); hibernate_nvs_free();
acpi_ec_resume_transactions(); acpi_ec_unblock_transactions();
acpi_pm_finish(); acpi_pm_finish();
} }
...@@ -619,12 +619,12 @@ static void acpi_hibernation_leave(void) ...@@ -619,12 +619,12 @@ static void acpi_hibernation_leave(void)
/* Restore the NVS memory area */ /* Restore the NVS memory area */
hibernate_nvs_restore(); hibernate_nvs_restore();
/* Allow EC transactions to happen. */ /* Allow EC transactions to happen. */
acpi_ec_resume_transactions_early(); acpi_ec_unblock_transactions_early();
} }
static void acpi_pm_thaw(void) static void acpi_pm_thaw(void)
{ {
acpi_ec_resume_transactions(); acpi_ec_unblock_transactions();
acpi_enable_all_runtime_gpes(); acpi_enable_all_runtime_gpes();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment