Commit fefe1ed1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Ingo Molnar

iommu: Fix off by one in dmar_get_fault_reason()

fault_reason - 0x20 == ARRAY_SIZE(irq_remap_fault_reasons) is
one past the end of the array.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>
Cc: Youquan Song <youquan.song@intel.com>
Cc: walter harms <wharms@bfs.de>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: <stable@kernel.org>
Link: http://lkml.kernel.org/r/20120513170938.GA4280@elgon.mountainSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent c558df4a
...@@ -1057,8 +1057,8 @@ static const char *irq_remap_fault_reasons[] = ...@@ -1057,8 +1057,8 @@ static const char *irq_remap_fault_reasons[] =
const char *dmar_get_fault_reason(u8 fault_reason, int *fault_type) const char *dmar_get_fault_reason(u8 fault_reason, int *fault_type)
{ {
if (fault_reason >= 0x20 && (fault_reason <= 0x20 + if (fault_reason >= 0x20 && (fault_reason - 0x20 <
ARRAY_SIZE(irq_remap_fault_reasons))) { ARRAY_SIZE(irq_remap_fault_reasons))) {
*fault_type = INTR_REMAP; *fault_type = INTR_REMAP;
return irq_remap_fault_reasons[fault_reason - 0x20]; return irq_remap_fault_reasons[fault_reason - 0x20];
} else if (fault_reason < ARRAY_SIZE(dma_remap_fault_reasons)) { } else if (fault_reason < ARRAY_SIZE(dma_remap_fault_reasons)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment