- 17 Sep, 2012 40 commits
-
-
Daniel Cotey authored
first chunk, straighten up the pointer notation Signed-off-by:
Daniel Cotey <puff65537@bansheeslibrary.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Daniel Cotey authored
checkpatch fixups Signed-off-by:
-
Daniel Cotey authored
Finish trailing spaces in libbp_sd.h Signed-off-by:
-
Daniel Cotey authored
Whack all the line ending spaces so checkpatch.pl is happy. Signed-off-by:
-
Daniel Cotey authored
Remove trailing spaces, second chunk Signed-off-by:
-
Daniel Cotey authored
Remove trailing spaces, first chunk Signed-off-by:
-
Daniel Cotey authored
twelfth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
eleventh chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
tenth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
ninth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
eighth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
seventh chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
sixth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
fifth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
fourth chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
third chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
second chunk of bp_mod.h's cleanup Signed-off-by:
-
Daniel Cotey authored
first chunk of bp_mod.h's cleanup Signed-off-by:
-
Ben Hutchings authored
softsynth_read() reads a character at a time from the init string; when it finds the null terminator it sets the initialized flag but then repeats the last character. Additionally, if the read() buffer is not big enough for the init string, the next read() will start reading from the beginning again. So the caller may never progress to reading anything else. Replace the simple initialized flag with the current position in the init string, carried over between calls. Switch to reading real data once this reaches the null terminator. (This assumes that the length of the init string can't change, which seems to be the case. Really, the string and position belong together in a per-file private struct.) Tested-by:
Samuel Thibault <sthibault@debian.org> Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
Devendra Naga authored
we should be using the NULL macro, not 0 to compare against a pointer value, and also remove braces around the single if conditional after the create_proc_entry Signed-off-by:
Devendra Naga <devendra.aaru@gmail.com> Signed-off-by:
-
Devendra Naga authored
replace some of the c99 comments to the structures with c88 comment style no code change is done here. Signed-off-by:
-
Dan Carpenter authored
The main problem with the hand rolled code was that there weren't any range checks so you could corrupt memory by writing too much data to the proc file. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
If you tried to cat more than 255 characters (the last character is for the terminator) to these proc files then it would corrupt kernel memory. Signed-off-by:
-
Ian Abbott authored
Rename the standard `init_module()` and `cleanup_module()` functions and make them static. Use `module_init()` and `module_exit()` to mark the renamed functions as the module init and exit functions. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:
-
Ian Abbott authored
All the drivers that use the "mite" module now allocate a `struct mite_struct` dynamically instead of searching the `mite_devices` list populated during initialization of the "mite" module. Remove the list of devices and the function that prints available NI devices on the list (`mite_list_devices()`). The list node and `used` members in `struct mite_struct` are now redundant, so remove them. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
This driver's comedi `detach` handler (`ni_670x_detach()`) calls `free_irq()` but the driver doesn't call `request_irq()` anywhere. Remove the spurious call. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
Allocate `struct mite_device` dynamically instead of searching for one on the `mite_devices` list constructed by the "mite" module. Signed-off-by:
-
Ian Abbott authored
Add `mite_alloc()` to allow drivers to allocate and initialize a `struct mite_struct` dynamically and export it. Add `mite_free()`, which is currently just an inline wrapper for `kfree()`. Signed-off-by:
-
Ian Abbott authored
Replace the `printk()` calls in this module with `dev_...()` calls where possible or `pr_...()` calls otherwise. Rework the normally ifdefed out (by the `DEBUG_MITE` macro) `mite_dump_regs()` to dump register offsets instead of remapped addresses. Signed-off-by:
-
Ian Abbott authored
The static inline functions `MITE_IODWBSR_1_WSIZE_bits()` and `CR_RL()` in "mite.h" work out a base-2 logarithm using a `while` loop. Change them to use `ilog2()`. Also change `CR_RL()` to clamp the maximum value instead of printing an error. Signed-off-by:
-
Ian Abbott authored
The `mite_alloc_ring()` and `mite_free_ring()` static inline functions in "mite.h" are reasonably large. Transfer them to "mite.c" and export them. Signed-off-by:
-
Ian Abbott authored
Declare some non-exported functions in "mite.c" `static` and remove their declarations from "mite.h". Signed-off-by:
-
Ian Abbott authored
Convert this PCI driver to use the comedi `attach_pci` callback instead of the `attach` callback for PCI auto-configuration. There is no need to support manual attachment of PCI devices supported by this driver, so remove the `attach` callback altogether. Note that this driver still uses the list of PCI "mite" devices created by the "mite" module. This will be dealt with by a later patch once dynamic allocation of "mite" structures has been implemented. Signed-off-by:
-
Ian Abbott authored
Add a semi-colon after the macro call `module_comedi_pci_driver(ni_pcimio_driver, ni_pcimio_pci_driver)`. It compiles with or without the semicolon but it ought to have it. Signed-off-by:
-
