- 09 Jul, 2014 32 commits
-
-
Eli Billauer authored
Duplicate code in this function was moved into a new function, xilly_get_dma_buffers(). There is no change in functionality. Signed-off-by:
Eli Billauer <eli.billauer@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Eli Billauer authored
Data arriving from the hardware is verified prior to its use. The lack of this check has never been reported to cause a problem, but it's necessary nevertheless. Signed-off-by:
-
Tobias Klauser authored
Instead of using an own copy of struct net_device_stats in struct et131x_adapter, use stats from struct net_device. Signed-off-by:
Tobias Klauser <tklauser@distanz.ch> Signed-off-by:
-
Dan Carpenter authored
We're holding a spinlock here so we can't do sleeping allocations. The call tree is: rtw_sta_flush() <-- takes spin_lock_bh(&pstapriv->asoc_list_lock); --> ap_free_sta() --> rtw_clearstakey_cmd() Originally these calls were rtw_zmalloc() and then we switched them to kzalloc() in fadbe0cd ('staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()') and that made the bugs show up for my static checker. The original code was buggy as well but my static checker couldn't parse it. Signed-off-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Anton Protopopov authored
Added a check of the return value of the kobject_set_name function. Signed-off-by:
Anton Protopopov <a.s.protopopov@gmail.com> Signed-off-by:
-
Andrey Utkin authored
kmalloc() result check was lacking. Fixing that required also changing card_send_command() return type from void to int, and checking its return code everywhere. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78561Reported-by:
Maksymilian Arciemowicz <max@cert.cx> Signed-off-by:
Andrey Utkin <andrey.krieger.utkin@gmail.com> Signed-off-by:
-
Himangi Saraogi authored
This patch introduces the use of managed interfaces like devm_kzalloc, devm_ioremap, dmam_alloc_coherent, devm_request_irq and does away with the calls to functions to free the allocated memory in the probe and remove functions. Also, the labels are removed in the probe function. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Pawel Lebioda authored
Fix the following warning reported by checkpatch.pl: WARNING: Possible unnecessary 'out of memory' message 811: FILE: drivers/staging/nvec/nvec.c:811 Signed-off-by:
Pawel Lebioda <pawel.lebioda89@gmail.com> Acked-by:
Marc Dietrich <marvin24@gmx.de> Reviewed-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
-
Pawel Lebioda authored
Fix the following warning reported by checkpatch.pl: WARNING: else is not generally useful after a break or return 235: FILE: drivers/staging/nvec/nvec.c:235 Signed-off-by:
-
Pawel Lebioda authored
This patch fixes coding style warnings reported by checkpatch.pl: "Missing a blank line after declarations". Signed-off-by:
-
Daeseok Youn authored
The brd is allocated by kzalloc() in dgnc_found_board() so do not need to set 0 to member variable. Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Daeseok Youn authored
dgnc_tty_ioctl() cannot reach the end of function. Signed-off-by:
-
Daeseok Youn authored
The "un->un_open_count" is unsigned variable, so it cannot be less than zero. Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
-
Daeseok Youn authored
The brd is already checked by earlier function in dgap_init_one(). Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
-
Daeseok Youn authored
dgap_dl_wait and kme_wait are not used in dgap. Signed-off-by:
-
Daeseok Youn authored
The dgap_init_pci() calls only pci_register_driver(). It doesn't need to make a function for that. Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch warning: WARNING: void function return statements are not generally useful Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch.pl error: ERROR: "foo* bar" should be "foo *bar" Signed-off-by:
-
Matt Kurz authored
Fix checkpatch.pl warnings due to missing blank line after declarations Signed-off-by:
Matt Kurz <matt@ninezulu.com> Signed-off-by:
-
Tobias Klauser authored
Instead of using an own copy of struct net_device_stats in struct wlandevice, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev->stats, which is the default in dev_get_stats(). Furthermore, convert prefix increment of stats counters to the more common postfix increment idiom. Signed-off-by:
-
Tobias Klauser authored
The memory for struct net_device private data is allocated using kzalloc/vzalloc in alloc_netdev_mqs, thus there is no need to zero it again in the driver. Signed-off-by:
-
Tobias Klauser authored
Instead of using an own copy of struct net_device_stats in struct nic, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev->stats, which is the default in dev_get_stats(). Signed-off-by:
-
Ben Chan authored
The descriptions are provided by GCT Semiconductor, Inc. Signed-off-by:
Ben Chan <benchan@chromium.org> Signed-off-by:
-
Michalis Pappas authored
Remove code surrounded by otherwise unused #define LOOPBACK_TEST Signed-off-by:
Michalis Pappas <mpappas@fastmail.fm> Signed-off-by:
-
Ben Chan authored
This patch cleans up the endianness conversions in the gdm72xx driver: - Directly use the generic byte-reordering macros for endianness conversion instead of some custom-defined macros. - Convert values on the constant side instead of the variable side when appropriate. - Add endianness annotations. Signed-off-by:
-
Ben Chan authored
Signed-off-by:
-
Sachin Kamat authored
‘strict_strtol’ is deprecated. Use kstrtol instead. Fixes the following build error: drivers/staging/emxx_udc/emxx_udc.c:3288:3: error: implicit declaration of function ‘strict_strtol’ Signed-off-by:
Sachin Kamat <sachin.kamat@samsung.com> Signed-off-by:
-
Andrey Utkin authored
The issue is discovered by static checker. The proposed change (0x000c0 -> 0x000c) is likely correct because: 1. 16-bit `map` holds value coming from struct ieee80211_vht_mcs_info.tx_mcs_map, which is described so: "TX MCS map 2 bits for each stream, total 8 streams". The changed code refers to case of 2 TX streams, and 0x000c mask filters two bits related to the second stream. Some codelines below 0x0003 mask is used to test first stream. 2. Mask 0x000c is used 3 more times in that place. 3. Specifying 5 digits of hex value is uncommon, especially while working with `u16` variable. So likely the trailing zero is a typo. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78041Reported-by:
David Binderman <dcb314@hotmail.com> Signed-off-by:
-
Emil Goode authored
We need to make sure the struct rtllib_device pointer ieee is not NULL after the goto rx_dropped label since it is dereferenced there. Signed-off-by:
Emil Goode <emilgoode@gmail.com> Signed-off-by:
-
- 08 Jul, 2014 8 commits
-
-
Anil Belur authored
- this replaces jiffies comparision with safer function using time_after_eq() Signed-off-by:
Anil Belur <askb23@gmail.com> Signed-off-by:
-
Rasmus Villemoes authored
struct rtl_stats is rather huge (152 bytes), and since rtl92ee_rx_command_packet() does not modify it, it might as well be passed by const reference. Reported by Coverity: CID 1222131 Signed-off-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by:
-
Rasmus Villemoes authored
struct rtl_stats is rather huge (152 bytes), and since rtl8812ae_rx_command_packet_handler() does not modify it, it might as well be passed by const reference. Reported by Coverity: CID 1167285 Signed-off-by:
-
Fabian Frederick authored
use macro definition Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Josh Triplett <josh@joshtriplett.org> Cc: devel@driverdev.osuosl.org Signed-off-by:
Fabian Frederick <fabf@skynet.be> Signed-off-by:
-
Fabian Frederick authored
lprocfs_stats_seq_sops is only used in static int lprocfs_stats_seq_open with seq_open as const struct seq_operations * Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Peng Tao <bergwolf@gmail.com> Cc: devel@driverdev.osuosl.org Signed-off-by:
-
Aaro Koskinen authored
wHubCharacteristics gets wrong value on big-endian CPUs. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Return transferred bytes only when transfer was successful. Signed-off-by:
-
Aaro Koskinen authored
On data toggle error, we don't know if and how many bytes were successfully transferred by DMA. We should just fail the transaction instead of trying a retry. Signed-off-by:
-
