- 14 Feb, 2017 6 commits
-
-
Bogdan Purcareata authored
Compiling the fsl-mc bus driver will yield a couple of static analysis errors: warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. warning: symbol 'its_fsl_mc_msi_init' was not declared. warning: symbol 'its_fsl_mc_msi_cleanup' was not declared. Since these are properly declared, but the header is not included, add it in the source files. This way the symbol is properly exported. Signed-off-by:
Bogdan Purcareata <bogdan.purcareata@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Karthik Nayak authored
The struct 'ni_private' holds the variable 'serial_number' which post assignment is never used. Remove the variable and code pertaining to obtaining its value. As a side note, this also fixes the following sparse error: drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int Signed-off-by:
Karthik Nayak <Karthik.188@gmail.com> Signed-off-by:
-
Saber Rezvani authored
Fix the checkpatch.pl issue: CHECK: usleep_range is preferred over udelay Signed-off-by:
Saber Rezvani <irsaber@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Saber Rezvani authored
Fix the checkpatch.pl issue: CHECK: usleep_range is preferred over udelay Signed-off-by:
-
Saber Rezvani authored
Fix the checkpatch.pl issue: CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by:
-
Saber Rezvani authored
Fix the checkpatch.pl issue: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by:
-
- 12 Feb, 2017 34 commits
-
-
Jacob Zachariah authored
Fix multiple checkpatch.pl warnings WARNING: function definition argument '..' should also have an identifier name Signed-off-by:
Jacob Zachariah <jacob.zac316@gmail.com> Signed-off-by:
-
Ran Algawi authored
Fixed a coding style issue, where an octal value was needed insted of decimal. Signed-off-by:
Ran Algawi <ran.algawi@gmail.com> Signed-off-by:
-
simran singhal authored
This patch fixes following checkpatch.pl warnings: WARNING:do not add new typedefs. All the related files have been modified. Signed-off-by:
simran singhal <singhalsimran0@gmail.com> Signed-off-by:
-
Arushi Singhal authored
This patch fixes the issue by aligning the * on each line in block comments. Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by:
-
simran singhal authored
Removing unnecessary parentheses from an expression of the form &(x). Issue found by checkpatch. Signed-off-by:
-
simran singhal authored
This fixes the following checkpatch.pl warnings: WARNING: printk() should include KERN_ facility level Signed-off-by:
-
simran singhal authored
Fix 'void function return statements are not generally useful' checkpatch.pl warnings. Signed-off-by:
-
simran singhal authored
Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: -
simran singhal authored
Remove comparison to true and false in if statement. Problem found usingcheckpatch.pl. CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by:
-
simran singhal authored
This patch fixes the checkpatch issue: CHECK: No space is necessary after a cast Signed-off-by:
-
simran singhal authored
This patch replace explicit NULL comparison with ! or unmark operator to simplify code. Reported by checkpatch.pl for comparison to NULL could be written "!XXX" or "XXX". Signed-off-by:
-
simran singhal authored
This patch remove useless function ieee80211_ccmp_null. Signed-off-by:
-
simran singhal authored
This fixes all checkpatch form of this from the Lustre tree: CHECK: braces {} should be used on all arms of this statement Signed-off-by: -
simran singhal authored
Checkpatch recommended changes. Signed-off-by:
-
simran singhal authored
This patch modifies the assignments into single assignments. Signed-off-by:
-
simran singhal authored
This patch fixes the checkpatch warning by removing unnecessary space after a cast. CHECK: No space is necessary after a cast Signed-off-by:
-
simran singhal authored
This patch fixes the checkpatch warning by removing multiple blank lines. CHECK: Please don't use multiple blank lines Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
Derek Robson <robsonde@gmail.com> Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments. Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed style of block comments Found using checkpatch Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8712/rtl871x_mlme.c drivers/staging/rtl8712/rtl871x_mlme.c:1653:46: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_mlme.c:1653:46: expected unsigned int [unsigned] [usertype] DSConfig drivers/staging/rtl8712/rtl871x_mlme.c:1653:46: got restricted __le32 [usertype] <noident> drivers/staging/rtl8712/rtl871x_mlme.c:1656:56: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_mlme.c:1656:56: expected unsigned int [unsigned] [usertype] ATIMWindow drivers/staging/rtl8712/rtl871x_mlme.c:1656:56: got restricted __le32 [usertype] <noident> drivers/staging/rtl8712/rtl871x_mlme.c:1712:35: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_mlme.c:1712:35: expected restricted __le16 [addressable] [usertype] cap_info drivers/staging/rtl8712/rtl871x_mlme.c:1712:35: got int Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8712/rtl871x_ioctl_linux.c drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1422:46: warning: restricted __le16 degrades to integer drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1424:46: warning: restricted __le16 degrades to integer Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8712/rtl871x_recv.c drivers/staging/rtl8712/rtl871x_recv.c:657:21: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_recv.c:657:21: expected unsigned short [unsigned] [assigned] [usertype] len drivers/staging/rtl8712/rtl871x_recv.c:657:21: got restricted __be16 [usertype] <noident> Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8712/rtl871x_xmit.c drivers/staging/rtl8712/rtl871x_xmit.c:350:44: warning: restricted __le32 degrades to integer drivers/staging/rtl8712/rtl871x_xmit.c:491:23: warning: incorrect type in initializer (different base types) drivers/staging/rtl8712/rtl871x_xmit.c:491:23: expected unsigned short [usertype] *fctrl drivers/staging/rtl8712/rtl871x_xmit.c:491:23: got restricted __le16 *<noident> drivers/staging/rtl8712/rtl871x_xmit.c:580:36: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_xmit.c:580:36: expected unsigned short [unsigned] [short] [usertype] <noident> drivers/staging/rtl8712/rtl871x_xmit.c:580:36: got restricted __be16 [usertype] <noident> Signed-off-by:
-
Larry Finger authored
Although the driver works on big-endian hardware, Sparse generates a lot of warnings. Many of these are the result of incorrect coding of these macros. Signed-off-by:
-
Larry Finger authored
The headers describing a number of network packets do not have the correct endian settings for several types of data. Signed-off-by:
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8712/rtl8712_xmit.c drivers/staging/rtl8712/rtl8712_xmit.c:564:42: warning: cast from restricted __le32 drivers/staging/rtl8712/rtl8712_xmit.c:569:42: warning: cast from restricted __le32 drivers/staging/rtl8712/rtl8712_xmit.c:571:42: warning: cast from restricted __le32 Each of these cases is transferring a quantity that is little-endian. There is no need for conversion. Signed-off-by:
-
