- 17 Feb, 2017 40 commits
-
-
Jeff Mahoney authored
We don't need to pass a root to flush_space since it always uses the fs_root. Signed-off-by:
Jeff Mahoney <jeffm@suse.com> Signed-off-by:
David Sterba <dsterba@suse.com>
-
Jeff Mahoney authored
Outside of interactions with qgroups, the roots passed in extent-tree.c are usually passed to ensure that we don't do refcounts on log trees or to get the allocation profile for an allocation request. Otherwise, it operates on the extent root. This patch converts some more routines in extent-tree.c that are always called with the extent root to accept an fs_info instead. Signed-off-by:
-
Qu Wenruo authored
Just as Filipe pointed out, the most time consuming parts of qgroup are btrfs_qgroup_account_extents() and btrfs_qgroup_prepare_account_extents(). Which both call btrfs_find_all_roots() to get old_roots and new_roots ulist. What makes things worse is, we're calling that expensive btrfs_find_all_roots() at transaction committing time with TRANS_STATE_COMMIT_DOING, which will blocks all incoming transaction. Such behavior is necessary for @new_roots search as current btrfs_find_all_roots() can't do it correctly so we do call it just before switch commit roots. However for @old_roots search, it's not necessary as such search is based on commit_root, so it will always be correct and we can move it out of transaction committing. This patch moves the @old_roots search part out of commit_transaction(), so in theory we can half the time qgroup time consumption at commit_transaction(). But please note that, this won't speedup qgroup overall, the total time consumption is still the same, just reduce the performance stall. Cc: Filipe Manana <fdmanana@suse.com> Signed-off-by:
Qu Wenruo <quwenruo@cn.fujitsu.com> Reviewed-by:
Filipe Manana <fdmanana@suse.com> Signed-off-by:
-
David Sterba authored
Never used. Reviewed-by:
Liu Bo <bo.li.liu@oracle.com> Signed-off-by:
-
David Sterba authored
Both unused after the call to update_cache_item has been moved to __btrfs_wait_cache_io. Reviewed-by:
-
David Sterba authored
bitmap_list is unused since the io_ctl framework. Reviewed-by:
-
David Sterba authored
Unused since the helper has been split, eb used in the caller. Reviewed-by:
-
David Sterba authored
Never used. Reviewed-by:
-
David Sterba authored
After the page locking has been reworked, we get all pages prepared via cmp_pages. Reviewed-by:
-
David Sterba authored
Never used. Reviewed-by:
-
David Sterba authored
Never used. Reviewed-by:
-
David Sterba authored
The name parameters have never been used, as the name is passed via the dentry. Reviewed-by:
-
David Sterba authored
The 'device' used to be added in that function, but now it's done by the caller. Reviewed-by:
-
David Sterba authored
We grab fs_info from other parameters. Reviewed-by:
-
David Sterba authored
Never used for anything meaningful since we have our own superblock filler. Reviewed-by:
-
David Sterba authored
The 'tree' was used to call locking hook that does not exist anymore. Reviewed-by:
-
David Sterba authored
Never used. Reviewed-by:
-
David Sterba authored
The logic has been updated in "Btrfs: make mapping->writeback_index point to the last written page" (a9132667) and page is not needed anymore. Reviewed-by:
-
David Sterba authored
This used to hold number of maximum pages to allocate, but this is now limited by BIO_MAX_PAGES. The local are now unused and removed as well. Reviewed-by:
-
David Sterba authored
Not needed. Reviewed-by:
-
David Sterba authored
Never needed. Reviewed-by:
-
David Sterba authored
None of the checks need to know the ro/rw status as they're all not changing the superblock. Moreover, we can access the sb flags directly if we'd need to decide by the ro/rw status. Reviewed-by:
-
David Sterba authored
Added but never used. Reviewed-by:
-
David Sterba authored
Unused since qgroup refactoring that split data and metadata accounting, the btrfs_qgroup_free helper. Reviewed-by:
-
David Sterba authored
Unused since long ago. Reviewed-by:
-
David Sterba authored
Unused since long ago. Reviewed-by:
-
David Sterba authored
write_all_supers and write_ctree_super are almost equal, the parameter 'trans' is unused so we can drop it and have just one helper. Reviewed-by:
-
David Sterba authored
The barriers are handled by the caller. Reviewed-by:
-
David Sterba authored
Never used. Reviewed-by:
-
David Sterba authored
Added but never needed. Reviewed-by:
-
David Sterba authored
Added but never used. Reviewed-by:
-
David Sterba authored
Never used in that function. Reviewed-by:
-
David Sterba authored
Change the name so it matches the naming we already use eg. for btrfs_path. Suggested-by:
-
David Sterba authored
There was never need for RCU protection around reading nodesize or other fairly constant filesystem data. Signed-off-by: -
David Sterba authored
The helper name is not too helpful and is just wrapping a simple call. Signed-off-by: -
David Sterba authored
The quota status used to be tracked as a variable, so the mutex was needed (until "Btrfs: add a flags field to btrfs_fs_info" afcdd129). Since the status is a bit modified atomically and we don't hold the mutex beyond the check, we can drop it. Signed-off-by:
-
David Sterba authored
Status of quotas should be the first check in btrfs_qgroup_account_extent and we can return immediatelly, no need to do no-op ulist frees. Signed-off-by: -
David Sterba authored
We can embed range_changed to the extent changeset to address following problems: - no need to allocate ulist dynamically, we also get rid of the GFP_NOFS for free - fix lack of allocation failure checking in btrfs_qgroup_reserve_data The stack consuption where extent_changeset is used slightly increases: before: 16 after: 16 - 8 (for pointer) + 32 (sizeof ulist) = 40 Which is bearable. Reviewed-by:
-
David Sterba authored
Make ulist_fini externally visible so the ulist API is complete. Signed-off-by: -
David Sterba authored
Internal helper. Signed-off-by:
-
