- 07 May, 2018 40 commits
-
-
Stefan Wahren authored
Since there is no vchiq function listed by "make checkstack" anymore, we can remove the stack hog issue from the TODO. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Stefan Wahren authored
This removes an unnecessary break which has been reported by checkpatch.pl. Signed-off-by:
-
Stefan Wahren authored
This removing an unnecessary return which has been reported by checkpatch.pl. Signed-off-by:
-
Stefan Wahren authored
This fixes a whitespace issue reported by checkpatch: ERROR: code indent should use tabs where possible Signed-off-by:
-
Stefan Wahren authored
The definition of USE_VCHIQ_ARM and VCOS_VERIFY_BKPTS isn't really necessary so remove them. Signed-off-by:
-
Stefan Wahren authored
The chance to mixup i and j is very high. So rename variable j to a more explaining one. Signed-off-by:
-
Stefan Wahren authored
In order to make the code easier to review, move the second abort criterion into the loop and the incrementation into a separate line. Signed-off-by:
-
Stefan Wahren authored
The kernel would like to have all stack VLA usage removed[1]. The array here is fixed (declared with a const variable) but it appears like a VLA to the compiler. Also, currently we are putting 768 bytes on the stack. This function is only called on the error path so performance is not critical, let's just allocate the memory instead of using the stack. This saves stack space and removes the VLA build warning. kmalloc a buffer for dumping state instead of using the stack. [1]: https://lkml.org/lkml/2018/3/7/621Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Stefan Wahren authored
We better use the real loop limit in the warning about "too many active services". Another benefit is than we don't have to care about the format string in the following change. Signed-off-by:
-
Samuel Thibault authored
For software speech syntheses to be able to manage concurrent audio card access, they need to know when speakup stops emitting text to be spoken because the console has switched to graphical mode. This introduces a PAUSE command to do so. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
Nathan Chancellor authored
This satisfies a checkpatch.pl warning and is the preferred method for notating the license due to its lack of ambiguity. Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
This commit changes types for local variables declared in hostif_phy_information_confirm function to use the preferred one 'u8' and 'u32'. Its values are get using get_byte and get_dword functions which returns 'u8' and 'u32' so it makes sense. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'result_code' is declared as unsigned int in hostif_bss_scan_confirm function. Its value is got calling get_dword which returns an 'u32' so change its type to u32 which is preferred Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'connect_code' is declared as unsigned short in hostif_connect_indication function. Its value is got calling get_word which returns an 'u16' so change its type to u16 which is preferred. Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'auth_type' is declared as unsigned short in hostif_data_indication function. Its value is got calling get_word which returns an 'u16' so change its type to u16 which is preferred. Signed-off-by:
-
Sergio Paracuellos authored
Local variable 'event' is declared as unsigned short in hostif_event_check function. Its value is got calling get_word which returns an 'u16' so change its type to u16 which is preferred. Signed-off-by:
-
Sergio Paracuellos authored
This commit simplify conditional paths in LOCAL_EEPROM_SUM case inside hostif_mib_get_confirm function. It change logic to handle invalid values first and assign good ones at the end if it is the case. Signed-off-by:
-
Sergio Paracuellos authored
This commit changes custom implementation of CIRC_CNT_TO_END. Just use the linux kernel header one to simplify code. Signed-off-by:
-
Sergio Paracuellos authored
This commit refactor a bit ks_get_wireless_stats using ternary operator for return code. It also change a comment to use preferred style. Signed-off-by:
-
Sergio Paracuellos authored
This commit refactors ks_wlan_set_mlme function changing switch-case block for more simple if paths improving readability. Signed-off-by:
-
Sergio Paracuellos authored
Handle invalid values first and assign good ones at the end if it is the case. This makes code simplier. Signed-off-by:
-
Sergio Paracuellos authored
This commit refactors ks_wlan_set_sleep_mode function avoiding to use switch-case statement ans using simple if logic to handle invalid values first. This simplifies data paths as well as improves readability. Signed-off-by:
-
Sergio Paracuellos authored
Instead of use memcpy for copying ethernet addresses, use ether_addr_copy that do the same. Signed-off-by:
-
Sergio Paracuellos authored
Use ether_addr_copy to copy ethernet address instad of using memcpy in ks_wlan_set_mac_address function. Signed-off-by:
-
Sergio Paracuellos authored
This commit refactor hostif_sme_power_mgmt_set avoiding to use switch-case statement and simplifying data paths. This improves readability. Signed-off-by:
-
Sergio Paracuellos authored
Parameters for hostif_power_mgmt_request are declared as unsigned long and then are forced to be change to be u32. Also the caller declares explicitly unsigned long parameters just to assign them and pass into the function. Change types for those to be u32 instead so no conversion is needed at all and code gets more clear. Signed-off-by:
-
Sergio Paracuellos authored
This commit make use of two introduced local variables to make more readable code of hostif_sme_set_rsn function. It just assign those local variables in different cases where are needed and extract common code to assign them at the end. Signed-off-by:
-
Sergio Paracuellos authored
Add blank line after definitions in hostif_aplist_init function to fix a checkpatch script complain about that. Signed-off-by:
-
Sergio Paracuellos authored
Fix some checkpatch complains about long lines in some parts of the code. It also fix some lines where spaces instead of tabs were inserted. Signed-off-by:
-
Sergio Paracuellos authored
In all functions related with requests to the device the same patter in used and is also adding a comment to make clear the intention of the code. Just factor out the pattern into a new send_request_to_device function to improve readability and make clear code intention. Signed-off-by:
-
Sergio Paracuellos authored
WLAN_EID_DS_PARAMS case inside switch case is just doing nothing and it is located inside other cases. There is a place inside the switch with other don't do anything cases are located. Move this to that place. Signed-off-by:
-
Sergio Paracuellos authored
This commit make use of ether_addr_copy to copy ethernet address instead of copy it using memcpy. Signed-off-by:
-
Sergio Paracuellos authored
Use ether_addr_copy kernel function to copy an ethernet address instead of a simple memcpy with ETH_ALEN size. Signed-off-by:
-
Sergio Paracuellos authored
Field rsn_enabled included in wpa_status struct is declared as unsigned int but it is only be set using 0 and 1 values and in conditional if code is just being used as a boolean. Change its type to be a boolean. Signed-off-by:
-
Sergio Paracuellos authored
Comments which say the same as the code are not useful at all so just remove them. Signed-off-by:
-
Sergio Paracuellos authored
This commit avoid two checkpatch script complains about two long lines. Signed-off-by:
-
Sergio Paracuellos authored
In ks_wlan_translate_scan function there are two preprocessor definitions: - RSN_INFO_ELEM_ID - GENERIC_INFO_ELEM_ID These can be moved to common ks_wlan.h because they can be used in get_current_ap function instead of use hardcoded values. GENERIC_INFO_ELEM_ID has been renamed to WPA_INFO_ELEM_ID which is more clear. Signed-off-by: -
Sergio Paracuellos authored
Instead of use memcpy to copy ethernet addresses use ether_addr_copy created for that. Signed-off-by:
-
Sergio Paracuellos authored
New three functions have been created to centralice and simplify calls related with set MIB requests: - hostif_mib_set_request_int - hostif_mib_set_request_bool - hostif_mib_set_request_ostring Using these in different calls simplify functions related with this mainly when types are bool and int because no more conversions are needed in the caller functions. Those conversion details are now located in the new helpers improving a lot readability. Calls in hostif_sme_set_wep function has change also some if's to check invalid value first avoiding one level indentation. Signed-off-by: -
Sergio Paracuellos authored
This commit changes parameter types to use enum mib_attribute, enum mib_data_type and size_t for size instead of unsigned short. It also reorder them in a more sense way. Code is updated in different calls to use new parameters order using 'size' auxiliar local variables in some of them to improve readability a bit. Signed-off-by:
-
