1. 23 Dec, 2016 7 commits
    • Al Viro's avatar
      sg_write()/bsg_write() is not fit to be called under KERNEL_DS · 128394ef
      Al Viro authored
      Both damn things interpret userland pointers embedded into the payload;
      worse, they are actually traversing those.  Leaving aside the bad
      API design, this is very much _not_ safe to call with KERNEL_DS.
      Bail out early if that happens.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      128394ef
    • Jeff Layton's avatar
      ufs: fix function declaration for ufs_truncate_blocks · f698cccb
      Jeff Layton authored
      sparse says:
      
          fs/ufs/inode.c:1195:6: warning: symbol 'ufs_truncate_blocks' was not declared. Should it be static?
      
      Note that the forward declaration in the file is already marked static.
      Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      f698cccb
    • Aleksa Sarai's avatar
      fs: exec: apply CLOEXEC before changing dumpable task flags · 613cc2b6
      Aleksa Sarai authored
      If you have a process that has set itself to be non-dumpable, and it
      then undergoes exec(2), any CLOEXEC file descriptors it has open are
      "exposed" during a race window between the dumpable flags of the process
      being reset for exec(2) and CLOEXEC being applied to the file
      descriptors. This can be exploited by a process by attempting to access
      /proc/<pid>/fd/... during this window, without requiring CAP_SYS_PTRACE.
      
      The race in question is after set_dumpable has been (for get_link,
      though the trace is basically the same for readlink):
      
      [vfs]
      -> proc_pid_link_inode_operations.get_link
         -> proc_pid_get_link
            -> proc_fd_access_allowed
               -> ptrace_may_access(task, PTRACE_MODE_READ_FSCREDS);
      
      Which will return 0, during the race window and CLOEXEC file descriptors
      will still be open during this window because do_close_on_exec has not
      been called yet. As a result, the ordering of these calls should be
      reversed to avoid this race window.
      
      This is of particular concern to container runtimes, where joining a
      PID namespace with file descriptors referring to the host filesystem
      can result in security issues (since PRCTL_SET_DUMPABLE doesn't protect
      against access of CLOEXEC file descriptors -- file descriptors which may
      reference filesystem objects the container shouldn't have access to).
      
      Cc: dev@opencontainers.org
      Cc: <stable@vger.kernel.org> # v3.2+
      Reported-by: default avatarMichael Crosby <crosbymichael@gmail.com>
      Signed-off-by: default avatarAleksa Sarai <asarai@suse.de>
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      613cc2b6
    • Tomasz Majchrzak's avatar
      seq_file: reset iterator to first record for zero offset · e522751d
      Tomasz Majchrzak authored
      If kernfs file is empty on a first read, successive read operations
      using the same file descriptor will return no data, even when data is
      available. Default kernfs 'seq_next' implementation advances iterator
      position even when next object is not there. Kernfs 'seq_start' for
      following requests will not return iterator as position is already on
      the second object.
      
      This defect doesn't allow to monitor badblocks sysfs files from MD raid.
      They are initially empty but if data appears at some stage, userspace is
      not able to read it.
      Signed-off-by: default avatarTomasz Majchrzak <tomasz.majchrzak@intel.com>
      Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      e522751d
    • Darrick J. Wong's avatar
      vfs: fix isize/pos/len checks for reflink & dedupe · 22725ce4
      Darrick J. Wong authored
      Strengthen the checking of pos/len vs. i_size, clarify the return values
      for the clone prep function, and remove pointless code.
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      22725ce4
    • Al Viro's avatar
      [iov_iter] fix iterate_all_kinds() on empty iterators · 33844e66
      Al Viro authored
      Problem similar to ones dealt with in "fold checks into iterate_and_advance()"
      and followups, except that in this case we really want to do nothing when
      asked for zero-length operation - unlike zero-length iterate_and_advance(),
      zero-length iterate_all_kinds() has no side effects, and callers are simpler
      that way.
      
      That got exposed when copy_from_iter_full() had been used by tipc, which
      builds an msghdr with zero payload and (now) feeds it to a primitive
      based on iterate_all_kinds() instead of iterate_and_advance().
      Reported-by: default avatarJon Maloy <jon.maloy@ericsson.com>
      Tested-by: default avatarJon Maloy <jon.maloy@ericsson.com>
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      33844e66
    • Al Viro's avatar
      move aio compat to fs/aio.c · c00d2c7e
      Al Viro authored
      ... and fix the minor buglet in compat io_submit() - native one
      kills ioctx as cleanup when put_user() fails.  Get rid of
      bogus compat_... in !CONFIG_AIO case, while we are at it - they
      should simply fail with ENOSYS, same as for native counterparts.
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      c00d2c7e
  2. 19 Dec, 2016 10 commits
    • Linus Torvalds's avatar
      Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs · e93b1cc8
      Linus Torvalds authored
      Pull quota, fsnotify and ext2 updates from Jan Kara:
       "Changes to locking of some quota operations from dedicated quota mutex
        to s_umount semaphore, a fsnotify fix and a simple ext2 fix"
      
      * 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
        quota: Fix bogus warning in dquot_disable()
        fsnotify: Fix possible use-after-free in inode iteration on umount
        ext2: reject inodes with negative size
        quota: Remove dqonoff_mutex
        ocfs2: Use s_umount for quota recovery protection
        quota: Remove dqonoff_mutex from dquot_scan_active()
        ocfs2: Protect periodic quota syncing with s_umount semaphore
        quota: Use s_umount protection for quota operations
        quota: Hold s_umount in exclusive mode when enabling / disabling quotas
        fs: Provide function to get superblock with exclusive s_umount
      e93b1cc8
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 45d36906
      Linus Torvalds authored
      Pull KVM fixes from Paolo Bonzini:
       "Early fixes for x86.
      
        Instead of the (botched) revert, the lockdep/might_sleep splat has a
        real fix provided by Andrea"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        kvm: nVMX: Allow L1 to intercept software exceptions (#BP and #OF)
        kvm: take srcu lock around kvm_steal_time_set_preempted()
        kvm: fix schedule in atomic in kvm_steal_time_set_preempted()
        KVM: hyperv: fix locking of struct kvm_hv fields
        KVM: x86: Expose Intel AVX512IFMA/AVX512VBMI/SHA features to guest.
        kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
      45d36906
    • Linus Torvalds's avatar
      Merge branch 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging · f1e91324
      Linus Torvalds authored
      Pull dmi fix from Jean Delvare.
      
      * 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging:
        firmware: dmi_scan: Always show system identification string
      f1e91324
    • Linus Torvalds's avatar
      Merge tag 'mfd-for-linus-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd · ac5a28b0
      Linus Torvalds authored
      Pull MFD updates from Lee Jones:
       "New Device Support
         - Add support for Ricoh RC5T619 PMIC to rn5t618
         - Add support for PM8821 PMIC to qcom-pm8xxx
      
        New Functionality:
         - Add support for GPIO to lpc_ich
         - Add support for GPADC to sun4i
         - Add ability for rk808 to shutdown
      
        Fix-ups:
         - Simplify/strip unnecessary code; tps65218, palmas, tps65217
         - Device Tree binding updates; tps65218, altera-a10sr
         - Provide/export device ID info; tps65218, axp20x-i2c, hi655x-pmic,
           fsl-imx25-tsadc, intel_soc_pmic_bxtwc
         - Use MFD API instead of of_platform_populate(); tps65218
         - Generalise name-space; pm8xxx
         - Supply/edit regmap configuration; axp20x, cs47l24-tables, axp20x
         - Enable compile testing; max77620, max77686, exynos-lpass,
           abx500-core
         - Coding style issues; wm8994-core, wm5102-tables
         - Supply endian support; syscon
         - Remove module support; ab3100-core, ab8500-debugfs, ab8500-gpadc,
           abx500-core
      
        Bug Fixes:
         - Fix ordering issues; wm8994
         - Fix dependencies (build-time/run-time); exynos_lpass, sun4i-gpadc
         - Fix compiler warnings; sun4i-gpadc
         - Fix leaks; mfd-core
         - Fix page fault during module unload; tps65217"
      
      * tag 'mfd-for-linus-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd: (49 commits)
        mfd: tps65217: Support an interrupt pin as the system wakeup
        mfd: tps65217: Make an interrupt handler simpler
        mfd: tps65217: Update register interrupt mask bits instead of writing operation
        mfd: tps65217: Specify the IRQ name
        mfd: tps65217: Fix page fault on unloading modules
        mfd: palmas: Remove redundant check in palmas_power_off
        mfd: arizona: Disable IRQs during driver remove
        mfd: pm8xxx: add support to pm8821
        mfd: intel-lpss: Try to enable Memory-Write-Invalidate
        mfd: rn5t618: Add Ricoh RC5T619 PMIC support
        mfd: axp20x: Add address extension registers for AXP806 regmap
        mfd: intel_soc_pmic_bxtwc: Fix a typo in MODULE_DEVICE_TABLE()
        mfd: core: Fix device reference leak in mfd_clone_cell
        mfd: bcm590xx: Simplify a test
        mfd: sun4i-gpadc: Select regmap-irq
        mfd: abx500-core: drop unused MODULE_ tags from non-modular code
        mfd: ab8500: make sysctrl explicitly non-modular
        mfd: ab8500-gpadc: Make it explicitly non-modular
        mfd: ab8500-debugfs: Make it explicitly non-modular
        mfd: ab8500-core: Make it explicitly non-modular
        ...
      ac5a28b0
    • Jim Mattson's avatar
      kvm: nVMX: Allow L1 to intercept software exceptions (#BP and #OF) · ef85b673
      Jim Mattson authored
      When L2 exits to L0 due to "exception or NMI", software exceptions
      (#BP and #OF) for which L1 has requested an intercept should be
      handled by L1 rather than L0. Previously, only hardware exceptions
      were forwarded to L1.
      Signed-off-by: default avatarJim Mattson <jmattson@google.com>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      ef85b673
    • Andrea Arcangeli's avatar
      kvm: take srcu lock around kvm_steal_time_set_preempted() · cc0d907c
      Andrea Arcangeli authored
      kvm_memslots() will be called by kvm_write_guest_offset_cached() so
      take the srcu lock.
      Signed-off-by: default avatarAndrea Arcangeli <aarcange@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      cc0d907c
    • Andrea Arcangeli's avatar
      kvm: fix schedule in atomic in kvm_steal_time_set_preempted() · 931f261b
      Andrea Arcangeli authored
      kvm_steal_time_set_preempted() isn't disabling the pagefaults before
      calling __copy_to_user and the kernel debug notices.
      Signed-off-by: default avatarAndrea Arcangeli <aarcange@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      931f261b
    • Jan Kara's avatar
      quota: Fix bogus warning in dquot_disable() · 2700e606
      Jan Kara authored
      dquot_disable() was warning when sb_has_quota_loaded() was true when
      invalidating page cache for quota files. The thinking behind this
      warning was that we must have raced with somebody else turning quotas on
      and this should not happen because all places modifying quota state must
      hold s_umount exclusively now. However sb_has_quota_loaded() can be also
      true at this point when we are just suspending quotas on remount
      read-only. Just restore the behavior to situation before commit
      c3b00446 ("quota: Remove dqonoff_mutex") which introduced the
      warning.
      
      The code in dquot_disable() can be further simplified with the new
      locking of quota state changes however let's leave that to a separate
      commit that can get more testing exposure.
      
      Fixes: c3b00446Signed-off-by: default avatarJan Kara <jack@suse.cz>
      2700e606
    • Kefeng Wang's avatar
      firmware: dmi_scan: Always show system identification string · d4af49f8
      Kefeng Wang authored
      Let's keep consistent when print dmi_ids_string between SMBIOS 2.x
      and SMBIOS 3.x, and always show the system identification string,
      like Vendor, Product/Board name and BIOS infos.
      Signed-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      d4af49f8
    • Linus Torvalds's avatar
      Merge tag 'rtc-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux · b0b3a37b
      Linus Torvalds authored
      Pull RTC updates from Alexandre Belloni:
        "Subsystem:
         - non-modular drivers are now explicitly non-modular
      
        New driver:
          - Epson Toyocom rtc-7301sf/dg
      
        Drivers:
         - cmos: reject unsupported alarm values wrt the RTC capabilities
         - ds1307: ACPI support
         - jz4740: DT support, jz4780 handling, can now be used as a system
           power controller
         - mcp795: many fixes, in particular proper month handling
         - twl: driver is now DT only"
      
      * tag 'rtc-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux: (31 commits)
        rtc: mcp795: Fix whitespace and indentation.
        rtc: mcp795: Prefer using the BIT() macro.
        rtc: mcp795: fix month write resetting date to 1.
        rtc: mcp795: fix time range difference between linux and RTC chip.
        rtc: mcp795: fix bitmask value for leap year (LP).
        rtc: mcp795: use bcd2bin/bin2bcd.
        rtc: add support for EPSON TOYOCOM RTC-7301SF/DG
        rtc: ds1307: Add ACPI support
        rtc: imxdi: (trivial) fix a typo
        rtc: ds1374: Merge conditional + WARN_ON()
        rtc: twl: make driver DT only
        rtc: twl: kill static variables
        rtc: fix typos in Kconfig
        rtc: jz4740: make the driver builtin only
        rtc: jz4740: remove unused EXPORT_SYMBOL
        Documentation: bindings: fix twl-rtc documentation
        rtc: Enable compile testing for Maxim and Samsung drivers
        MIPS: jz4740: Remove obsolete code
        MIPS: qi_lb60: Probe RTC driver from DT and use it as power controller
        MIPS: jz4740: DTS: Probe the jz4740-rtc driver from devicetree
        ...
      b0b3a37b
  3. 18 Dec, 2016 23 commits
    • Emil Bartczak's avatar
      rtc: mcp795: Fix whitespace and indentation. · d3e59259
      Emil Bartczak authored
      Fix whitespace and indentation errors and the following
      checkpatch warnings:
      - line 15: Block comments use a trailing */ on a separate line
      - line 256: Line over 80 characters
      No code change.
      Signed-off-by: default avatarEmil Bartczak <emilbart@gmail.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      d3e59259
    • Emil Bartczak's avatar
      rtc: mcp795: Prefer using the BIT() macro. · a2b42997
      Emil Bartczak authored
      This patch doesn't change the code but replaces all bitmask values
      with the BIT(x) macro.
      Signed-off-by: default avatarEmil Bartczak <emilbart@gmail.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      a2b42997
    • Emil Bartczak's avatar
      rtc: mcp795: fix month write resetting date to 1. · 43d0b10f
      Emil Bartczak authored
      According to Microchip errata some combinations of date and month
      values may result in the date being reset to 1, even if the date
      is also written with the month (for example 31-07 or 31-08).
      As a workaround avoid writing date and month values within the same
      Write command. Instead, terminate the Write command after loading
      the date and begin a new command to write the month. In addition,
      disable the oscillator before loading the new values. This is done
      by ensuring both the ST and EXTOSC bits are cleared and waiting for
      the OSCON bit to clear.
      Signed-off-by: default avatarEmil Bartczak <emilbart@gmail.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      43d0b10f
    • Emil Bartczak's avatar
      rtc: mcp795: fix time range difference between linux and RTC chip. · 26eeefd5
      Emil Bartczak authored
      In linux rtc_time struct, tm_mon range is 0~11, while in RTC HW REG,
      month range is 1~12. This patch adjusts difference of them.
      Signed-off-by: default avatarEmil Bartczak <emilbart@gmail.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      26eeefd5
    • Emil Bartczak's avatar
      rtc: mcp795: fix bitmask value for leap year (LP). · e72765c6
      Emil Bartczak authored
      According the datasheet the leap year is a fifth bit in month register.
      Signed-off-by: default avatarEmil Bartczak <emilbart@gmail.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      e72765c6
    • Emil Bartczak's avatar
      rtc: mcp795: use bcd2bin/bin2bcd. · bcf18d88
      Emil Bartczak authored
      Change rtc-mcp795.c to use the bcd2bin/bin2bcd functions.
      This change fixes the wrong conversion of month value
      from binary to BCD (missing right shift operation for 10 month).
      Signed-off-by: default avatarEmil Bartczak <emilbart@gmail.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      bcf18d88
    • Akinobu Mita's avatar
      rtc: add support for EPSON TOYOCOM RTC-7301SF/DG · 0b6a8f5c
      Akinobu Mita authored
      This adds support for EPSON TOYOCOM RTC-7301SF/DG which has parallel
      interface compatible with SRAM.
      
      This driver supports basic clock, calendar and alarm functionality.
      
      Tested with Microblaze linux running on Artix7 FPGA board with my own
      custom IP for RTC-7301.
      Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
      Acked-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      0b6a8f5c
    • Tin Huynh's avatar
      rtc: ds1307: Add ACPI support · 9c19b893
      Tin Huynh authored
      This patch enables ACPI support for rtc-ds1307 driver.
      Signed-off-by: default avatarTin Huynh <tnhuynh@apm.com>
      Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
      9c19b893
    • Linus Torvalds's avatar
      Merge tag 'libnvdimm-for-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm · 3be134e5
      Linus Torvalds authored
      Pull libnvdimm updates from Dan Williams:
       "The libnvdimm pull request is relatively small this time around due to
        some development topics being deferred to 4.11.
      
        As for this pull request the bulk of it has been in -next for several
        releases leading to one late fix being added (commit 868f036f
        ("libnvdimm: fix mishandled nvdimm_clear_poison() return value")). It
        has received a build success notification from the 0day-kbuild robot
        and passes the latest libnvdimm unit tests.
      
        Summary:
      
         - Dynamic label support: To date namespace label support has been
           limited to disambiguating cases where PMEM (direct load/store) and
           BLK (mmio aperture) accessed-capacity alias on the same DIMM. Since
           4.9 added support for multiple namespaces per PMEM-region there is
           value to support namespace labels even in the non-aliasing case.
           The presence of a valid namespace index block force-enables label
           support when the kernel would otherwise rely on region boundaries,
           and permits the region to be sub-divided.
      
         - Handle media errors in namespace metadata: Complement the error
           handling for media errors in namespace data areas with support for
           clearing errors on writes, and downgrading potential machine-check
           exceptions to simple i/o errors on read.
      
         - Device-DAX region attributes: Add 'align', 'id', and 'size' as
           attributes for device-dax regions. In particular this enables
           userspace tooling to generically size memory mapping and i/o
           operations. Prevent userspace from growing assumptions /
           dependencies about the parent device topology for a dax region. A
           libnvdimm namespace may not always be the parent device of a dax
           region.
      
         - Various cleanups and small fixes"
      
      * tag 'libnvdimm-for-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm:
        dax: add region 'id', 'size', and 'align' attributes
        libnvdimm: fix mishandled nvdimm_clear_poison() return value
        libnvdimm: replace mutex_is_locked() warnings with lockdep_assert_held
        libnvdimm, pfn: fix align attribute
        libnvdimm, e820: use module_platform_driver
        libnvdimm, namespace: use octal for permissions
        libnvdimm, namespace: avoid multiple sector calculations
        libnvdimm: remove else after return in nsio_rw_bytes()
        libnvdimm, namespace: fix the type of name variable
        libnvdimm: use consistent naming for request_mem_region()
        nvdimm: use the right length of "pmem"
        libnvdimm: check and clear poison before writing to pmem
        tools/testing/nvdimm: dynamic label support
        libnvdimm: allow a platform to force enable label support
        libnvdimm: use generic iostat interfaces
      3be134e5
    • Linus Torvalds's avatar
      Merge tag 'platform-drivers-x86-v4.10-2' of... · 8421c604
      Linus Torvalds authored
      Merge tag 'platform-drivers-x86-v4.10-2' of git://git.infradead.org/users/dvhart/linux-platform-drivers-x86
      
      Pull more x86 platform driver updates from Darren Hart:
       "Move and add registration for the mlx-platform driver. Introduce
        button and lid drivers for the surface3 (different from the
        surface3-pro). Add BXT PMIC TMU support. Add Y700 to existing
        ideapad-laptop quirk.
      
        Summary:
      
        ideapad-laptop:
         - Add Y700 15-ACZ to no_hw_rfkill DMI list
      
        surface3_button:
         - Introduce button support for the Surface 3
      
        surface3-wmi:
         - Add custom surface3 platform device for controlling LID
         - Balance locking on error path
      
        mlx-platform:
         - Add mlxcpld-hotplug driver registration
         - Fix semicolon.cocci warnings
         - Move module from arch/x86
      
        platform/x86:
         - Add Whiskey Cove PMIC TMU support"
      
      * tag 'platform-drivers-x86-v4.10-2' of git://git.infradead.org/users/dvhart/linux-platform-drivers-x86:
        platform/x86: surface3-wmi: Balance locking on error path
        platform/x86: Add Whiskey Cove PMIC TMU support
        platform/x86: ideapad-laptop: Add Y700 15-ACZ to no_hw_rfkill DMI list
        platform/x86: Introduce button support for the Surface 3
        platform/x86: Add custom surface3 platform device for controlling LID
        platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration
        platform/x86: mlx-platform: Fix semicolon.cocci warnings
        platform/x86: mlx-platform: Move module from arch/x86
      8421c604
    • Andy Shevchenko's avatar
      platform/x86: surface3-wmi: Balance locking on error path · 83da6b59
      Andy Shevchenko authored
      There is a possibility that lock will be left acquired.
      Consolidate error path under out_free_unlock label.
      Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
      Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
      83da6b59
    • Nilesh Bacchewar's avatar
      platform/x86: Add Whiskey Cove PMIC TMU support · 957ae509
      Nilesh Bacchewar authored
      This adds TMU (Time Management Unit) support for Intel BXT platform.
      It enables the alarm wake-up functionality in the TMU unit of Whiskey Cove
      PMIC.
      Signed-off-by: default avatarNilesh Bacchewar <nilesh.bacchewar@intel.com>
      Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
      [andy: resolve merge conflict in Kconfig]
      Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
      957ae509
    • Linus Torvalds's avatar
      Merge branch 'x86-timers-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · f7dd3b17
      Linus Torvalds authored
      Pull timer updates from Thomas Gleixner:
       "This is the last functional update from the tip tree for 4.10. It got
        delayed due to a newly reported and anlyzed variant of BIOS bug and
        the resulting wreckage:
      
         - Seperation of TSC being marked realiable and the fact that the
           platform provides the TSC frequency via CPUID/MSRs and making use
           for it for GOLDMONT.
      
         - TSC adjust MSR validation and sanitizing:
      
           The TSC adjust MSR contains the offset to the hardware counter. The
           sum of the adjust MSR and the counter is the TSC value which is
           read via RDTSC.
      
           On at least two machines from different vendors the BIOS sets the
           TSC adjust MSR to negative values. This happens on cold and warm
           boot. While on cold boot the offset is a few milliseconds, on warm
           boot it basically compensates the power on time of the system. The
           BIOSes are not even using the adjust MSR to set all CPUs in the
           package to the same offset. The offsets are different which renders
           the TSC unusable,
      
           What's worse is that the TSC deadline timer has a HW feature^Wbug.
           It malfunctions when the TSC adjust value is negative or greater
           equal 0x80000000 resulting in silent boot failures, hard lockups or
           non firing timers. This looks like some hardware internal 32/64bit
           issue with a sign extension problem. Intel has been silent so far
           on the issue.
      
           The update contains sanity checks and keeps the adjust register
           within working limits and in sync on the package.
      
           As it looks like this disease is spreading via BIOS crapware, we
           need to address this urgently as the boot failures are hard to
           debug for users"
      
      * 'x86-timers-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/tsc: Limit the adjust value further
        x86/tsc: Annotate printouts as firmware bug
        x86/tsc: Force TSC_ADJUST register to value >= zero
        x86/tsc: Validate TSC_ADJUST after resume
        x86/tsc: Validate cpumask pointer before accessing it
        x86/tsc: Fix broken CONFIG_X86_TSC=n build
        x86/tsc: Try to adjust TSC if sync test fails
        x86/tsc: Prepare warp test for TSC adjustment
        x86/tsc: Move sync cleanup to a safe place
        x86/tsc: Sync test only for the first cpu in a package
        x86/tsc: Verify TSC_ADJUST from idle
        x86/tsc: Store and check TSC ADJUST MSR
        x86/tsc: Detect random warps
        x86/tsc: Use X86_FEATURE_TSC_ADJUST in detect_art()
        x86/tsc: Finalize the split of the TSC_RELIABLE flag
        x86/tsc: Set TSC_KNOWN_FREQ and TSC_RELIABLE flags on Intel Atom SoCs
        x86/tsc: Mark Intel ATOM_GOLDMONT TSC reliable
        x86/tsc: Mark TSC frequency determined by CPUID as known
        x86/tsc: Add X86_FEATURE_TSC_KNOWN_FREQ flag
      f7dd3b17
    • Linus Torvalds's avatar
      Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 1bbb05f5
      Linus Torvalds authored
      Pull x86 fixes and cleanups from Thomas Gleixner:
       "This set of updates contains:
      
         - Robustification for the logical package managment. Cures the AMD
           and virtualization issues.
      
         - Put the correct start_cpu() return address on the stack of the idle
           task.
      
         - Fixups for the fallout of the nodeid <-> cpuid persistent mapping
           modifciations
      
         - Move the x86/MPX specific mm_struct member to the arch specific
           mm_context where it belongs
      
         - Cleanups for C89 struct initializers and useless function
           arguments"
      
      * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/floppy: Use designated initializers
        x86/mpx: Move bd_addr to mm_context_t
        x86/mm: Drop unused argument 'removed' from sync_global_pgds()
        ACPI/NUMA: Do not map pxm to node when NUMA is turned off
        x86/acpi: Use proper macro for invalid node
        x86/smpboot: Prevent false positive out of bounds cpumask access warning
        x86/boot/64: Push correct start_cpu() return address
        x86/boot/64: Use 'push' instead of 'call' in start_cpu()
        x86/smpboot: Make logical package management more robust
      1bbb05f5
    • Linus Torvalds's avatar
      Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 451bb1a6
      Linus Torvalds authored
      Pull timer fix from Thomas Gleixner:
       "Prevent NULL pointer dereferencing in the tick broadcast code. Old
        bug, which got unearthed by the hotplug ordering problem"
      
      * 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        tick/broadcast: Prevent NULL pointer dereference
      451bb1a6
    • Linus Torvalds's avatar
      Merge branch 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 98da295b
      Linus Torvalds authored
      Pull SMP hotplug fixes from Thomas Gleixner:
       "Two fixlets for cpu hotplug:
      
         - Fix a subtle ordering problem with the dummy timer. This happened
           to work before the conversion by chance due to initcall ordering.
      
         - Fix the function comment for __cpuhp_setup_state()"
      
      * 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        cpu/hotplug: Clarify description of __cpuhp_setup_state() return value
        clocksource/dummy_timer: Move hotplug callback after the real timers
      98da295b
    • Linus Torvalds's avatar
      Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · eb3a3c07
      Linus Torvalds authored
      Pull irq fix from Thomas Gleixner:
       "A fix for the irq affinity spread algorithm so it handles non linear
        node numbering nicely"
      
      * 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        genirq/affinity: Fix node generation from cpumask
      eb3a3c07
    • Thomas Gleixner's avatar
      x86/tsc: Limit the adjust value further · 8c9b9d87
      Thomas Gleixner authored
      Adjust value 0x80000000 and other values larger than that render the TSC
      deadline timer disfunctional.
      
      We have not yet any information about this from Intel, but experimentation
      clearly proves that this is a 32/64 bit and sign extension issue.
      
      If adjust values larger than that are actually required, which might be the
      case for physical CPU hotplug, then we need to disable the deadline timer
      on the affected package/CPUs and use the local APIC timer instead.
      
      That requires some surgery in the APIC setup code, so we just limit the
      ADJUST register value into the known to work range for now and revisit this
      when Intel comes forth with proper information.
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: Roland Scheidegger <rscheidegger_lists@hispeed.ch>
      Cc: Bruce Schlobohm <bruce.schlobohm@intel.com>
      Cc: Kevin Stanton <kevin.b.stanton@intel.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Borislav Petkov <bp@alien8.de>
      8c9b9d87
    • Thomas Gleixner's avatar
      x86/tsc: Annotate printouts as firmware bug · 16588f65
      Thomas Gleixner authored
      Make it more obvious that the BIOS is screwed up.
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: Roland Scheidegger <rscheidegger_lists@hispeed.ch>
      Cc: Bruce Schlobohm <bruce.schlobohm@intel.com>
      Cc: Kevin Stanton <kevin.b.stanton@intel.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Borislav Petkov <bp@alien8.de>
      16588f65
    • Kees Cook's avatar
      x86/floppy: Use designated initializers · ffc7dc8d
      Kees Cook authored
      Prepare to mark sensitive kernel structures for randomization by making
      sure they're using designated initializers. These were identified during
      allyesconfig builds of x86, arm, and arm64, with most initializer fixes
      extracted from grsecurity.
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Link: http://lkml.kernel.org/r/20161217213705.GA1248@beastSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
      ffc7dc8d
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net · 52f40e9d
      Linus Torvalds authored
      Pull networking fixes and cleanups from David Miller:
      
       1) Revert bogus nla_ok() change, from Alexey Dobriyan.
      
       2) Various bpf validator fixes from Daniel Borkmann.
      
       3) Add some necessary SET_NETDEV_DEV() calls to hsis_femac and hip04
          drivers, from Dongpo Li.
      
       4) Several ethtool ksettings conversions from Philippe Reynes.
      
       5) Fix bugs in inet port management wrt. soreuseport, from Tom Herbert.
      
       6) XDP support for virtio_net, from John Fastabend.
      
       7) Fix NAT handling within a vrf, from David Ahern.
      
       8) Endianness fixes in dpaa_eth driver, from Claudiu Manoil
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (63 commits)
        net: mv643xx_eth: fix build failure
        isdn: Constify some function parameters
        mlxsw: spectrum: Mark split ports as such
        cgroup: Fix CGROUP_BPF config
        qed: fix old-style function definition
        net: ipv6: check route protocol when deleting routes
        r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected
        irda: w83977af_ir: cleanup an indent issue
        net: sfc: use new api ethtool_{get|set}_link_ksettings
        net: davicom: dm9000: use new api ethtool_{get|set}_link_ksettings
        net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings
        net: chelsio: cxgb3: use new api ethtool_{get|set}_link_ksettings
        net: chelsio: cxgb2: use new api ethtool_{get|set}_link_ksettings
        bpf: fix mark_reg_unknown_value for spilled regs on map value marking
        bpf: fix overflow in prog accounting
        bpf: dynamically allocate digest scratch buffer
        gtp: Fix initialization of Flags octet in GTPv1 header
        gtp: gtp_check_src_ms_ipv4() always return success
        net/x25: use designated initializers
        isdn: use designated initializers
        ...
      52f40e9d
    • Linus Torvalds's avatar
      Merge uncontroversial parts of branch 'readlink' of... · 231753ef
      Linus Torvalds authored
      Merge uncontroversial parts of branch 'readlink' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
      
      Pull partial readlink cleanups from Miklos Szeredi.
      
      This is the uncontroversial part of the readlink cleanup patch-set that
      simplifies the default readlink handling.
      
      Miklos and Al are still discussing the rest of the series.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs:
        vfs: make generic_readlink() static
        vfs: remove ".readlink = generic_readlink" assignments
        vfs: default to generic_readlink()
        vfs: replace calling i_op->readlink with vfs_readlink()
        proc/self: use generic_readlink
        ecryptfs: use vfs_get_link()
        bad_inode: add missing i_op initializers
      231753ef
    • Sudip Mukherjee's avatar
      net: mv643xx_eth: fix build failure · 3e3397e7
      Sudip Mukherjee authored
      The build of sparc allmodconfig fails with the error:
      "of_irq_to_resource" [drivers/net/ethernet/marvell/mv643xx_eth.ko]
      	undefined!
      
      of_irq_to_resource() is defined when CONFIG_OF_IRQ is defined. And also
      CONFIG_OF_IRQ can only be defined if CONFIG_IRQ is defined. So we can
      safely use #if defined(CONFIG_OF_IRQ) in the code.
      Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3e3397e7