- 20 Jun, 2014 35 commits
-
-
Johannes Stadlinger authored
This patch fixes all warnings of checkpatch about string splitting. Signed-off-by:
Johannes Stadlinger <Johannes.Stadlinger@fau.de> Signed-off-by:
Maximilian Eschenbacher <maximilian@eschenbacher.email> CC: linux-kernel@i4.cs.fau.de CC: Himangi Saraogi <himangi774@gmail.com> CC: Vitaly Osipov <vitaly.osipov@gmail.com> CC: devel@driverdev.osuosl.org CC: linux-kernel@vger.kernel.org Reviewed-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Johannes Stadlinger authored
This patch fixes all warnings of checkpatch about lines over 80 characters. Signed-off-by:
-
Stephan Gabert authored
Signed-off-by:
Stephan Gabert <stephan.gabert@fau.de> Signed-off-by:
Nicolas Pfeiffer <nicolas.pfeiffer@fau.de> Signed-off-by:
-
Stephan Gabert authored
Hereby the checkpatch message ERROR: spaces required around that '=' (ctx:VxV) gets resolved and the neighboring equal signs are positioned in the same column. Signed-off-by:
-
Stephan Gabert authored
As warned by checkpatch.pl, one should use #include <linux/io.h> instead of #include <asm/io.h> and #include <linux/bitops.h> instead of #include <asm/bitops.h>. Signed-off-by:
-
Anil Belur authored
- this fixes "WARNING: space prohibited between function name and open parenthesis '(" Signed-off-by:Anil Belur <askb23@gmail.com> Signed-off-by:
-
Anil Belur authored
- this change fixes "WARNING: braces {} are not necessary for single statement blocks" Signed-off-by: -
Anil Belur authored
fixed warning "WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable" Signed-off-by:
-
Anil Belur authored
fixed warning for line over 80 characters by moving the struct init onto a diff line. Signed-off-by:
-
Anil Belur authored
- this change fixes the warning "WARNING: simple_strtoul is obsolete, use kstrtoul instead" - removed the unused var 'end' as this is no longer required for kstrtoul() Signed-off-by:
-
Anil Belur authored
- this fixed the "WARNING: braces {} are not necessary for single statement blocks" Signed-off-by: -
Anil Belur authored
fixed warning for line over 80 characters by moving the initilation onto a diff line. Signed-off-by:
-
Andrey Skvortsov authored
Signed-off-by:
Andrey Skvortsov <Andrej.Skvortzov@gmail.com> Signed-off-by:
-
Andrey Skvortsov authored
Signed-off-by:
-
Andrey Skvortsov authored
Signed-off-by:
-
Paul Bolle authored
Two Kconfig entries default to (uppercase) "N". It was clearly intended to use "default n". But since (lowercase) "n" is the default anyway, these lines might as well be removed. Reported-by:
Martin Walch <walch.martin@web.de> Signed-off-by:
Paul Bolle <pebolle@tiscali.nl> Signed-off-by:
-
Benedict Boerger authored
Fix checkpatch.pl warnings: Missing blank line after Declarations Signed-off-by:
Benedict Boerger <benedict.boerger@cs.tu-dortmund.de> Signed-off-by:
-
Adithya Krishnamurthy authored
Fixed checkpatch "WARNING: Missing a blank line after declarations" Signed-off-by:
Adithya Krishnamurthy <linux.challenge1@gmail.com> Signed-off-by:
-
Wolfgang Ocker authored
Sparse spit out these warnings: drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for basic block The new functions musycc_dump_[rt]xbuffer_ring_locked() assume that the lock is held. musycc_dump_[rt]xbuffer_ring() take the lock. Signed-off-by:
Wolfgang Ocker <weo@weo1.de> Signed-off-by:
-
Rickard Strandqvist authored
Unsigned variable can't be negative so it is unnecessary to test it. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
A Raghavendra Rao authored
Replaced 'printk' with 'netdev_' function Signed-off-by:
A Raghavendra Rao <arrao@cdac.in> Signed-off-by:
-
Kees Cook authored
This makes sure a format string cannot leak into the work queue name nor the printk buffer. Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Masanari Iida authored
This patch removed trailing semicolon from macro in guestlinuxdebug.h Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Robin Schroer authored
speakup_key() used manual comparison of jiffies to determine the time since the last keypress, replaced it with time_after() Signed-off-by:
Robin Schroer <sulamiification@gmail.com> Signed-off-by:
-
Alexey Khoroshilov authored
There is a strange "return 0" in line6_probe() before any initialization of the module is done. It can lead to NULL pointer dereference in other functions. The patch proposes to return -ENODEV in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
Vincent Heuken authored
This is a patch to the dgnc_driver.c file that fixes the following error: ERROR: open brace '{' following function declarations go on the next line Signed-off-by:Vincent Heuken <me@vincentheuken.com> Signed-off-by:
-
Arnd Bergmann authored
Using an 'if()' inside of an 'extern inline' function causes a gcc warning when CONFIG_PROFILE_ALL_BRANCHES is set every time the function is called, which gets very noisy: In file included from /git/arm-soc/drivers/staging/wlags49_h2/wl_wext.c:73:0: drivers/staging/wlags49_h2/wl_internal.h:1035:216: warning: '______f' is static but declared in inline function 'wl_act_int_off' which is not static [enabled by default] if(lp->is_handling_int == WL_HANDLING_INT) { Fortunately there is a trivial workaround, so we can avoid the problem by making the functions in question 'static inline' rather than 'extern inline'. Signed-off-by:Arnd Bergmann <arnd@arndb.de> Cc: Henk de Groot <pe1dnn@amsat.org> Signed-off-by:
-
Arnd Bergmann authored
The LIRC support for sa1100 appears to have never worked because it relies on header files that have never been present in git history. Actually trying to build the driver on an ARM sa1100 kernel fails, so let's just remove the broken support. Signed-off-by:
-
Arnd Bergmann authored
If the USB code is a loadable module, this driver cannot be built-in. This adds an explicit dependency on CONFIG_USB so that Kconfig can force sn9c102 to be a module in this case. Signed-off-by:
-
Robin Schroer authored
Signed-off-by:
-
Robin Schroer authored
Signed-off-by:
-
Robin Schroer authored
Signed-off-by:
-
Masanari Iida authored
This patch remove unnecessary parentheses in PHSModule.c Signed-off-by:
-
Rickard Strandqvist authored
Array 'SigBuff' is filled incompletely. Someone forget to multiply for the sizeof type. This was partly found using a static code analysis program called cppcheck. Signed-off-by:
-
Chuong Ngo authored
Signed-off-by:
Chuong Ngo <cngo.linux@gmail.com> Signed-off-by:
-
- 19 Jun, 2014 5 commits
-
-
James A Shackleford authored
This patch fixes the following sparse warnings: skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static? skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static? skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static? skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static? skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static? skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static? skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static? skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static? skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static? skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static? skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static? skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static? skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static? by declaring the initialization vectors in question as static. The header skein_iv.h is only included by skein.c Signed-off-by:
James A Shackleford <shack@linux.com> Acked-by:
Jason Cooper <jason@lakedaemon.net> Signed-off-by:
-
Marcus Farkas authored
This commit fixes the following sparse warnings in ps.c: - 702: warning: symbol 'rtl_p2p_noa_ie' was not declared. Should it be static? - 802: warning: symbol 'rtl_p2p_action_ie' was not declared. Should it be static? Signed-off-by:
Marcus Farkas <marcus.farkas@finitebox.com> Signed-off-by:
-
Vitaly Osipov authored
As suggested by Andy Shevchenko on driverdev-devel, replace v = ... sizeof(struct type_of_v) -> sizeof(*v) Based on a cocci patch along the lines of @@ type T; expression E; identifier V; @@ T *V; ... - V = kmalloc(sizeof(T), E); + V = kmalloc(sizeof(*V), E); @@ type T; expression E; identifier V; @@ T *V; ... - V = kzalloc(sizeof(T), E); + V = kzalloc(sizeof(*V), E); Signed-off-by:
Vitaly Osipov <vitaly.osipov@gmail.com> Signed-off-by:
-
Rickard Strandqvist authored
The same code regardless of the outcome of the if statement. And clean up another duplicate line of code. Signed-off-by:
-
Arnd Bergmann authored
The rtl8712 driver has an 'extern inline' function that contains an 'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES overriding the definition of 'if': drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default] This changes the driver to use 'static inline' instead, which happens to be the correct annotation anyway. Signed-off-by:
-
