An error occurred fetching the project authors.
- 10 Aug, 2017 1 commit
-
-
Arvind Yadav authored
snd_pcm_ops are not supposed to change at runtime. All functions working with snd_pcm_ops provided by <sound/pcm.h> work with const snd_pcm_ops. So mark the non-const structs as const. Signed-off-by:
Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 09 Jun, 2017 1 commit
-
-
Takashi Iwai authored
snd_pcm_hw_constraint_list(), *_ratnums() and *_ratdens() receive the const pointers. Constify the corresponding static objects for better hardening. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 09 May, 2017 1 commit
-
-
Laura Abbott authored
set_memory_* functions have moved to set_memory.h. Switch to this explicitly. Link: http://lkml.kernel.org/r/1488920133-27229-14-git-send-email-labbott@redhat.comSigned-off-by:
Laura Abbott <labbott@redhat.com> Acked-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
- 06 Apr, 2016 1 commit
-
-
Takashi Iwai authored
intel8x0 driver has the inside_vm check for skipping a buggy hardware workaround in the PCM pointer callback in the commit [228cf793: ALSA: intel8x0: Improve performance in virtual environment]. This was originally applied to all devices on known VMs, but the code was switched to use the PCI ID matching for applying to only known devices (KVM and Parallels), in order to avoid applying wrongly to VT-d and other such cases, in the commit [7fb4f392: ALSA: intel8x0: improve virtual environment detection]. Meanwhile, the original VM check was kept even after switching to the PCI ID matching. It was partly because we weren't 100% sure whether we had covered all well, and partly because this would help identifying the issue once when a user of another VM hit the same problem or a regression. Currently the VM check is used only for showing the kernel message that the VM-optimization isn't applied, and the VM check itself doesn't change the actual driver behavior at all. Despite the relatively safe driver behavior, the code caught attention of developers badly and brought many confusion / misunderstanding. Since we've got neither regression nor enhancement report for other VMs for five years long, it's likely safe to drop this superfluous VM check now. The module option is still kept, so if a user still needs to adjust, it can be applied as was. Acked-by:
Konstantin Ozerkov <kozerkov@parallels.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 14 Mar, 2016 1 commit
-
-
Vittorio Gambaletta (VittGam) authored
The clock measurement on the AC'97 audio card found in the IBM ThinkPad X41 will often fail, so add a quirk entry to fix it. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=441087 Cc: <stable@vger.kernel.org> Signed-off-by:
Vittorio Gambaletta <linuxbugs@vittgam.net> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 09 Mar, 2016 1 commit
-
-
Robin H. Johnson authored
Introduce PCI_VENDOR/PCI_SUBVENDOR/PCI_SUBDEVICE defines to replace the constants scattered in the kernel already used to detect QEMU. They are defined in the QEMU codebase per docs/specs/pci-ids.txt. Signed-off-by:
Robin H. Johnson <robbat2@gentoo.org> Signed-off-by:
Bjorn Helgaas <bhelgaas@google.com> Reviewed-by:
Takashi Iwai <tiwai@suse.de> Reviewed-by:
Gerd Hoffmann <kraxel@redhat.com> Acked-by:
Michael S. Tsirkin <mst@redhat.com> Acked-by:
Daniel Vetter <daniel.vetter@ffwll.ch>
-
- 29 May, 2015 1 commit
-
-
Takashi Iwai authored
The compiler can optimize the unused code away, so we can drop ifdefs. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 16 Apr, 2015 1 commit
-
-
Scott Wood authored
DEVICE_ALI previously would jump to port_inited after calling pci_iomap(), bypassing the check for bmaddr being NULL. Signed-off-by:
Scott Wood <scottwood@freescale.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 05 Apr, 2015 1 commit
-
-
Joe Perches authored
Use const to reduce data by ~3Kb. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 28 Jan, 2015 1 commit
-
-
Takashi Iwai authored
Nowadays it's recommended. Replace all in a shot. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 09 Jan, 2015 1 commit
-
-
Takashi Iwai authored
This is a similar cleanup like the commit [3db084fd: ALSA: fm801: PCI core handles power state for us]. Since pci_set_power_state(), pci_save_state() and pci_restore_state() are already done in the PCI core side, so we don't need to it doubly. Also, pci_enable_device(), pci_disable_device() and pci_set_master() calls in PM callbacks are superfluous nowadays, too, so get rid of them as well. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 12 Aug, 2014 1 commit
-
-
Benoit Taine authored
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const struct pci_device_id i[] = z; // </smpl> [bhelgaas: add semantic patch] Signed-off-by:
Benoit Taine <benoit.taine@lip6.fr> Signed-off-by:
Bjorn Helgaas <bhelgaas@google.com>
-
- 12 Jun, 2014 1 commit
-
-
Thomas Gleixner authored
do_posix_clock_monotonic_gettime() is a leftover from the initial posix timer implementation which maps to ktime_get_ts() and returns the monotonic time in a timespec. Use ktime based ktime_get() and use the ktime_delta_us() function to calculate the delta instead of open coding the timespec math. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 26 Feb, 2014 1 commit
-
-
Takashi Iwai authored
Convert with dev_err() and co from snd_printk(), etc. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 12 Feb, 2014 1 commit
-
-
Takashi Iwai authored
Also remove superfluous snd_card_set_dev() calls. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 06 Nov, 2013 1 commit
-
-
Takashi Iwai authored
The playback chmap for multi-channel stream hasn't been properly added to intel8x0 devices due to the wrong condition. Reported-by:
Raymond Yau <superquad.vortex2@gmail.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 29 May, 2013 1 commit
-
-
Takashi Iwai authored
As drvdata is cleared to NULL at probe failure or at removal by the driver core, we don't have to call pci_set_drvdata(pci, NULL) any longer in each driver. The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in hda_intel.c. Since this function itself releases the card instance, we need to clear drvdata here as well, so that it won't be released doubly in the remove callback. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 25 Jan, 2013 1 commit
-
-
Takashi Iwai authored
Because currently snd_printd() and snd_printdd() macros are expanded to empty when CONFIG_SND_DEBUG=n, a compile warning like below appears sometimes, and we had to covert it by ugly ifdefs: sound/pci/hda/patch_sigmatel.c: In function ‘stac92hd71bxx_fixup_hp’: sound/pci/hda/patch_sigmatel.c:2434:24: warning: unused variable ‘spec’ [-Wunused-variable] For "fixing" these issues better, this patch replaces snd_printd() and snd_printdd() definitions with empty inline functions instead of macros. This should have the same effect but shut up warnings like above. But since we had already put ifdefs, changing to inline functions would trigger compile errors. So, such ifdefs is removed in this patch. In addition, snd_pci_quirk name field is defined only when CONFIG_SND_DEBUG_VERBOSE is set, and the reference to it in snd_printdd() argument triggers the build errors, too. For avoiding these errors, introduce a new macro snd_pci_quirk_name() that is defined no matter how the debug option is set. Reported-by:
Stratos Karafotis <stratosk@semaphore.gr> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 07 Dec, 2012 1 commit
-
-
Bill Pemberton authored
CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by:
Bill Pemberton <wfp5p@virginia.edu> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 06 Oct, 2012 1 commit
-
-
Peter Senna Tschudin authored
A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 06 Sep, 2012 1 commit
-
-
Takashi Iwai authored
Just set the channel maps depending on the hardware availability. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 14 Aug, 2012 1 commit
-
-
Takashi Iwai authored
Otherwise we may get compile warnings due to unused functions. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 03 Jul, 2012 1 commit
-
-
Takashi Iwai authored
Straightforward conversion to the new pm_ops from the legacy suspend/resume ops. Since we change vx222, vx_core and vxpocket have to be converted, too. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 24 Apr, 2012 1 commit
-
-
Takashi Iwai authored
Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 14 Feb, 2012 1 commit
-
-
Daniel T Chen authored
BugLink: https://bugs.launchpad.net/bugs/930842 The reporter states that audio is inaudible by default without muting 'External Amplifier'. Add a quirk to handle his SSID so that changing the control is not necessary. Reported-and-tested-by:
Benjamin Carlson <elderbubba0810@gmail.com> Cc: <stable@kernel.org> Signed-off-by:
Daniel T Chen <crimsun@ubuntu.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 12 Jan, 2012 1 commit
-
-
Rusty Russell authored
For historical reasons, we allow module_param(bool) to take an int (or an unsigned int). That's going away. A few drivers really want an int: they set it to -1 and a parameter will set it to 0 or 1. This sucks: reading them from sysfs will give 'Y' for both -1 and 1, but if we change it to an int, then the users might be broken (if they did "param" instead of "param=1"). Use a new 'bint' parser for them. (ntfs has a different problem: it needs an int for debug_msgs because it's also exposed via sysctl.) Cc: Steve Glendinning <steve.glendinning@smsc.com> Cc: Jean Delvare <khali@linux-fr.org> Cc: Guenter Roeck <guenter.roeck@ericsson.com> Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com> Cc: Christoph Raisch <raisch@de.ibm.com> Cc: Roland Dreier <roland@kernel.org> Cc: Sean Hefty <sean.hefty@intel.com> Cc: Hal Rosenstock <hal.rosenstock@gmail.com> Cc: linux390@de.ibm.com Cc: Anton Altaparmakov <anton@tuxera.com> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.de> Cc: lm-sensors@lm-sensors.org Cc: linux-rdma@vger.kernel.org Cc: linux-s390@vger.kernel.org Cc: linux-ntfs-dev@lists.sourceforge.net Cc: alsa-devel@alsa-project.org Acked-by: Takashi Iwai <tiwai@suse.de> (For the sound part) Acked-by: Guenter Roeck <guenter.roeck@ericsson.com> (For the hwmon driver) Signed-off-by:
Rusty Russell <rusty@rustcorp.com.au>
-
- 19 Dec, 2011 1 commit
-
-
Rusty Russell authored
module_param(bool) used to counter-intuitively take an int. In fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy trick. It's time to remove the int/unsigned int option. For this version it'll simply give a warning, but it'll break next kernel version. Signed-off-by:
Rusty Russell <rusty@rustcorp.com.au> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 09 Nov, 2011 2 commits
-
-
Konstantin Ozerkov authored
Detection code improved by PCI SSID usage. VM optimization now enabled only for known devcices (skip host devices forwarded to VM by VT-d or same kind of technology). For debug/troubleshooting purposes optimization can be forced (on/off) by module parameter: "inside_vm" (boolean). Known devices (PCI SSID): 1af4:1100: Reserved for KVM devices. Note this is not yet implemented for KVM's ICH/AC'97 emulation. 1ab8:xxxx: Parallels ICH/AC'97 emulated sound. [ fixed a minor coding-style issue by tiwai] Signed-off-by:
Konstantin Ozerkov <kozerkov@parallels.com> Signed-off-by:
Denis V. Lunev <den@openvz.org> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Konstantin Ozerkov authored
This is refactoring patch: preparation for add improved detection code. Now all detection code placed in one place. Signed-off-by:
Konstantin Ozerkov <kozerkov@parallels.com> Signed-off-by:
Denis V. Lunev <den@openvz.org> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 08 Nov, 2011 1 commit
-
-
Denis V. Lunev authored
The recently merged 228cf793 looks a bit hackish while it is not. The change was quite simple. In a virtualized environment the patch unhacks old kludge introduced for old broken AC97 hardware. This patch adds proper comment to "unkludge" code. Signed-off-by:
Denis V. Lunev <den@openvz.org> Signed-off-by:
Konstantin Ozerkov <kozerkov@parallels.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 01 Nov, 2011 1 commit
-
-
Takashi Iwai authored
<linux/kvm_para.h> should be included instead of <asm/...> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 31 Oct, 2011 2 commits
-
-
Paul Gortmaker authored
The implicit presence of module.h lured several users into incorrectly thinking that they only needed/used modparam.h but once we clean up the module.h presence, these will show up as build failures, so fix 'em now. Signed-off-by:
Paul Gortmaker <paul.gortmaker@windriver.com>
-
Konstantin Ozerkov authored
v3: detection code is x86 and KVM specific, hide it under ifdef v2: add detection for virtual environments (KVM and Parallels) This patch is intended to improve performance in virtualized environments like Parallels Desktop or KVM/VirtualBox/QEMU (virtual ICH/AC97 audio). I/O access is very time-expensive operation in virtual world: VCPU can be rescheduled and in the worst case we get more than 10ms delay on each I/O access. In the virtual environment loop exit rule (old_civ == current_civ && old_picb == current_picb) is never satisfied, because old_picb is never the same as current_picb due to delay inspired by reading current_civ. As a result loop ended by timeout and we get 10x more I/O operations. Experimental data from Prallels Desktop 7, RHEL6 guest (I/O ops per second): Original code: In Port Counter Callback f014 41550 fffff00000179d00 ac97_bm_read_civ+0x000 f018 41387 fffff0000017a580 ac97_bm_read_picb+0x000 With patch: In Port Counter Callback f014 4090 fffff00000179d00 ac97_bm_read_civ+0x000 f018 1964 fffff0000017a580 ac97_bm_read_picb+0x000 Signed-off-by:
Konstantin Ozerkov <kozerkov@parallels.com> Signed-off-by:
Denis V. Lunev <den@openvz.org> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 15 Jul, 2011 1 commit
-
-
Daniel T Chen authored
BugLink: https://bugs.launchpad.net/bugs/774895 The original reporter states that his volume keys do not change the desired Master and PCM mixer elements together, so apply the hp+mute led quirk for his PCI SSID. Reported-by: Jeffrey Finkelstein Signed-off-by:
Daniel T Chen <crimsun@ubuntu.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 10 Jun, 2011 2 commits
-
-
Takashi Iwai authored
The name argument of request_irq() appears in /proc/interrupts, and it's quite ugly when the name entry contains a space or special letters. In general, it's simpler and more readable when the module name appears there, so let's replace all entries with KBUILD_MODNAME. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Takashi Iwai authored
The convention for pci_driver.name entry in kernel drivers seem to be the module name or equivalent ones. But, so far, almost all PCI sound drivers use more verbose name like "ABC Xyz (12)", and these are fairly confusing when appearing as a file name. This patch converts the all pci_driver.name entries in sound/pci/* to use KBUILD_MODNAME for more unified appearance. Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 31 Mar, 2011 1 commit
-
-
Lucas De Marchi authored
Fixes generated by 'codespell' and manually reviewed. Signed-off-by:
Lucas De Marchi <lucas.demarchi@profusion.mobi>
-
- 22 Nov, 2010 1 commit
-
-
Daniel T Chen authored
BugLink: https://launchpad.net/bugs/669279 The original reporter states: "The Master mixer does not change the volume from the headphone output (which is affected by the headphone mixer). Instead it only seems to control the on-board speaker volume. This confuses PulseAudio greatly as the Master channel is merged into the volume mix." Fix this symptom by applying the hp_only quirk for the reporter's SSID. The fix is applicable to all stable kernels. Reported-and-tested-by:
Ben Gamari <bgamari@gmail.com> Cc: <stable@kernel.org> [2.6.32+] Signed-off-by:
Daniel T Chen <crimsun@ubuntu.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
- 18 Oct, 2010 1 commit
-
-
Justin P. Mattock authored
The patch below updates broken web addresses in the kernel Signed-off-by:
Justin P. Mattock <justinmattock@gmail.com> Cc: Maciej W. Rozycki <macro@linux-mips.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Finn Thain <fthain@telegraphics.com.au> Cc: Randy Dunlap <rdunlap@xenotime.net> Cc: Matt Turner <mattst88@gmail.com> Cc: Dimitry Torokhov <dmitry.torokhov@gmail.com> Cc: Mike Frysinger <vapier.adi@gmail.com> Acked-by:
Ben Pfaff <blp@cs.stanford.edu> Acked-by:
Hans J. Koch <hjk@linutronix.de> Reviewed-by:
Finn Thain <fthain@telegraphics.com.au> Signed-off-by:
Jiri Kosina <jkosina@suse.cz>
-
- 19 Aug, 2010 1 commit
-
-
Daniel T Chen authored
BugLink: https://bugs.launchpad.net/bugs/619439 This ThinkPad model needs External Amplifier muted for audible playback, so set the inv_eapd quirk for it. Reported-and-tested-by:
Dennis Bell <dennis.bell@parkerg.co.uk> Cc: <stable@kernel.org> Signed-off-by:
Daniel T Chen <crimsun@ubuntu.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-