- 21 Aug, 2014 40 commits
-
-
Philipp Zabel authored
Lock modification of the timestamp list with bitstream_mutex and do not try to remove a timestamp element if the list is empty. This can happen if the userspace feeds us garbage or multiple encoded frames in a single buffer. Signed-off-by:
Michael Olbrich <m.olbrich@pengutronix.de> Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
Kamil Debski <k.debski@samsung.com> Signed-off-by:
Mauro Carvalho Chehab <m.chehab@samsung.com>
-
Philipp Zabel authored
Produce some error messages when internal buffer allocation fails, for example because the CMA region is too small. Signed-off-by:
-
Philipp Zabel authored
Dumping all register accesses drowns other debugging messages in the log. Add a less verbose debug level. Signed-off-by:
-
Philipp Zabel authored
This patch increases the maximum vertical frame size reported by enum_fmt and accepted by try_fmt/s_fmt from 1080 to 1088. Since for 16x16-pixel macroblocks 1080p will be rounded up to this anyway, we may as well admit that we support it. Signed-off-by:
-
Philipp Zabel authored
Signed-off-by:
-
Philipp Zabel authored
We know that it will return NULL in this case, so we can just as well skip it altogether. Signed-off-by:
-
Philipp Zabel authored
This is needed to decrease the q->owned_by_drv_count to zero before __vb2_queue_cancel is called, to avoid the WARN_ON therein. Signed-off-by:
-
Philipp Zabel authored
Signed-off-by:
-
Philipp Zabel authored
Request the main coda interrupt using its name, "bit", if available. Fall back to requesting the first interrupt for backwards compatibility. Signed-off-by:
-
Philipp Zabel authored
The return value of this call to v4l2_m2m_next_dst_buf() is never used. Signed-off-by:
-
Philipp Zabel authored
coda_h264_padding uses memcpy, we should include string.h for that. Reported-by:
Ian Jamison <ian.dev@arkver.com> Signed-off-by:
-
Philipp Zabel authored
This patch moves the BIT processor specific coda_context_ops, the firmware upload and other related functions from coda-common.c into coda-bit.c. Signed-off-by:
-
Philipp Zabel authored
Currently there is only the coda_h264_padding function, but we will have to add more H.264 specific helpers later. Signed-off-by:
-
Philipp Zabel authored
This patch moves the context buffer allocation into the context start_streaming callbacks. The context buffer and internal framebuffer cleanup is moved into the context release callback. Signed-off-by:
-
Philipp Zabel authored
This adds a helper function to consolidate three occurences where the bitstream parameter stream end flag is set during operation. Signed-off-by:
-
Philipp Zabel authored
In preparation for the split, move the AXI_SRAM_USE register access and the PIC_RUN command execution out of pic_run_work into prepare_encode/decode. Signed-off-by:
-
Philipp Zabel authored
Add a struct coda_context_ops that encapsulates context specific operations. This will simplify adding JPEG support in the future and helps to avoid exporting all functions individually when they move out of the main code file. Signed-off-by:
-
Philipp Zabel authored
These will have to be shared between multiple code files. Signed-off-by:
-
Philipp Zabel authored
The coda driver has grown significantly and will continue to grow. Move the coda driver into its own directory so it can be split. Rename coda.h to coda_regs.h as it contains the register defines. Signed-off-by:
-
Philipp Zabel authored
The format and codec lists and the ops structures are read-only. Mark them as const. Acked-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
-
Philipp Zabel authored
If the user provides an invalid format, let the decoder device default to h.264. Acked-by:
-
Philipp Zabel authored
Let the decoder capture side and encoder output side only list uncompressed formats, and the decoder output and encoder capture side only list compressed formats. Acked-by:
-
Philipp Zabel authored
Userspace has a hard time making sense of format enumerations on V4L2 mem2mem devices if there are restrictions on which input and output formats can be used together. Alleviate the problem by splitting the video4linux device into separate encoder and decoder devices which list only raw formats on one side and only encoded formats on the other side. With this patch, the instance type (encoder or decoder) is already determined by the open file operation. Acked-by:
-
Philipp Zabel authored
As soon as the output queue is streaming, let try_fmt on the capture side only allow the frame size that was set on the output side. Acked-by:
-
Michael Olbrich authored
coda_fill_bitstream() calls v4l2_m2m_buf_done() which is no longer allowed before streaming was started. Delay coda_fill_bitstream() until coda_start_streaming() and explicitly set 'start_streaming_called' before calling coda_fill_bitstream() Signed-off-by:
-
Michael Olbrich authored
Without this changing CODA_MAX_FRAME_SIZE to anything other than 0x100000 can break the bitstram handling Signed-off-by:
-
Philipp Zabel authored
Disallow USERPTR buffers, videobuf2-dma-contig doesn't support them. Acked-by:
-
Philipp Zabel authored
This is a mem2mem driver, pure capture or output modes are not supported. Acked-by:
-
Philipp Zabel authored
If no firmware was found and the coda module is unloaded, coda_runtime_resume will be called without an allocated code buffer. Do not call coda_hw_init in this case. Signed-off-by:
-
Philipp Zabel authored
Do not try to read the CODA960 GDI status register on CODA7541. Signed-off-by:
-
Laurent Pinchart authored
When updating the crop rectangle during streaming, the IRQ handler will reprogram the resizer after the current frame. A race condition currently exists between the set selection operation and the IRQ handler: if the set selection operation is called twice in a row and the IRQ handler runs only during the second call, it could reprogram the hardware with partially updated values. Use a spinlock to protect against that. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Laurent Pinchart authored
The resizer_set_input_size() function prints a debugging message with the input width and height values. As the function is called from interrupt context, printing that message to the serial console could slow down the interrupt handler and cause it to miss the start of the next frame, causing image corruption. Fix this by reorganizing the resizer debug messages. The driver now prints the input size, the crop rectangle and the output size in the set selection handler instead of scattering debug messages in various places. Signed-off-by:
-
Laurent Pinchart authored
There's no need to initialize local variables to zero when they're explicitly assigned another value right after. Remove the needless initializations. Signed-off-by:
-
Laurent Pinchart authored
As the CCDC doesn't generate interrupts when stopped in BT.656 mode, restart it immediately when the next buffer after an underrun is queued instead of relying on the interrupt handler to restart the CCDC. Signed-off-by:
Enrico Butera <ebutera@users.sourceforge.net> Signed-off-by:
-
Laurent Pinchart authored
When the CCDC is already stopped due to a buffer underrun, the stop state machine won't advance in BT.656 mode as no interrupt are generated by the stopped CCDC in that mode. Handle this case explicitly in the ccdc_disable() function. Signed-off-by:
-
Laurent Pinchart authored
In BT.656 mode the synchronization signals are generated by the CCDC from the embedded sync codes. The VD0 and VD1 interrupts are thus only triggered when the CCDC is enabled, unlike external sync mode where the line counter runs even when the CCDC is stopped. We can't disable the CCDC at VD1 time, as no VD0 interrupt would be generated for a short frame, which would result in the CCDC being stopped and no VD interrupt generated anymore. The CCDC is stopped from the VD0 interrupt handler instead for BT.656. Signed-off-by:
-
Laurent Pinchart authored
We will stop using VD1 in BT.656 mode, move frame number increment to the VD0 interrupt handler. Signed-off-by:
-
Laurent Pinchart authored
Use a local variable to avoid the duplicate spin_unlock_irqrestore() call. Signed-off-by:
-
Laurent Pinchart authored
There's no need for a double underscore in the function name, remove it. Signed-off-by:
-
Laurent Pinchart authored
Checking that the captured field corresponds to the last required field depending on the requested field order before completing the buffer isn't enough. When the first field at stream start corresponds to the last required field, this would result in returning an interlaced buffer containing a single field. Fix this by keeping track of the fields captured in the buffer, and make sure that both fields are present for alternate field orders. Signed-off-by:
-
