1. 13 Dec, 2008 15 commits
    • Steve Hodgson's avatar
      sfc: Make reset_workqueue driver-global rather than per-NIC · 1ab00629
      Steve Hodgson authored
      Each reset is serialised by the rtnl_lock anyway, so there's no win
      per-NIC.
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1ab00629
    • Ben Hutchings's avatar
      sfc: Correct interpretation of second param to ethtool phys_id() · 65f667fb
      Ben Hutchings authored
      A value of 0 means indefinite repetition (until interrupted).
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      65f667fb
    • Ben Hutchings's avatar
      sfc: Remove unneeded register write · 2b2734dc
      Ben Hutchings authored
      This was only ever needed for an FPGA version of Falcon.
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2b2734dc
    • Ben Hutchings's avatar
      sfc: Change SPI lengths to type size_t · 23d30f02
      Ben Hutchings authored
      Based on a patch by Andrew Morton.
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      23d30f02
    • Ben Hutchings's avatar
      sfc: Board support fixes · a17102b1
      Ben Hutchings authored
      Set dummy monitor method for unrecognised boards.
      
      Clean up board resources if efx_pci_probe_main() fails after board has
      been initialised.
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a17102b1
    • Karsten Keil's avatar
      misdn: Fix lockdep warning · 702c7904
      Karsten Keil authored
      use correct dynamic spinlock init function.
      Signed-off-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      702c7904
    • Hannes Eder's avatar
      mISDN: hfcmulti: use __iomem address space modifier · c31655fc
      Hannes Eder authored
      Impact: make use of the __iomem address space modifier, and change u_char *,
      u_short * and u_int * to void *
      
      Fix more than 30 sparse warnings of this or similar type:
      
        drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: warning: incorrect type in argument 2 (different address spaces)
        drivers/isdn/hardware/mISDN/hfcmulti.c:261:31:    got unsigned char [usertype] *
        drivers/isdn/hardware/mISDN/hfcmulti.c:261:31:    expected void volatile [noderef] <asn:2>*addr
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c31655fc
    • Hannes Eder's avatar
      mISDN: timerdev: use __user for mISDN_read's buffer argument · c46f0a2d
      Hannes Eder authored
      Fix this warning:
      
        drivers/isdn/mISDN/timerdev.c:264:11: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
        drivers/isdn/mISDN/timerdev.c:264:11:    expected int ( *read )( ... )
        drivers/isdn/mISDN/timerdev.c:264:11:    got int ( static [toplevel] *<noident> )( ... )
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c46f0a2d
    • Hannes Eder's avatar
      mISDN: comment out unused symbols · 047ce8f2
      Hannes Eder authored
      Fix this sparse warnings:
      
        drivers/isdn/hardware/mISDN/hfcmulti.c:794: warning: 'vpm_check' defined but not used
        drivers/isdn/mISDN/dsp_cmx.c:1546: warning: 'dsp_start_jiffies' defined but not used
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      047ce8f2
    • Hannes Eder's avatar
      mISDN: fix sparse warning: symbol 'id' shadows an earlier one · 863a76e5
      Hannes Eder authored
      Impact: rename function scope variable
      
      Fix this warning:
      
        drivers/isdn/mISDN/l1oip_core.c:472:8: warning: symbol 'id' shadows an earlier one
        drivers/isdn/mISDN/l1oip_core.c:254:14: originally declared here
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      863a76e5
    • Hannes Eder's avatar
      mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one · bb68b1d9
      Hannes Eder authored
      Impact: define first occurence of variable 'nskb' in inner most possible scope
      
      Fix this sparse warning:
      
        drivers/isdn/mISDN/dsp_core.c:746:20: warning: symbol 'nskb' shadows an earlier one
        drivers/isdn/mISDN/dsp_core.c:634:19: originally declared here
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bb68b1d9
    • Hannes Eder's avatar
      mISDN: un-export symbol 'plx_lock' · 65a40516
      Hannes Eder authored
      'plx_lock' is only used within hfcmulti.c.
      
      Fix this warning:
      
        drivers/isdn/hardware/mISDN/hfcmulti.c:176:1: warning: symbol 'plx_lock' shadows an earlier one
        drivers/isdn/hardware/mISDN/hfcmulti.c:175:19: originally declared here
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      65a40516
    • Hannes Eder's avatar
      mISDN: make global symbols static or include header files · 5b834354
      Hannes Eder authored
      The warnings fixed by including an header file for the appropriate
      prototype are marked with "*", for all others the corresonponding
      symbol has been made static.  This patch fixes all such issues in
      mISDN.
      
      Fix this sparse warnings:
      
        drivers/isdn/hardware/mISDN/hfcmulti.c:174:5: warning: symbol 'plxsd_master' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:426:1: warning: symbol 'write_fifo_regio' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:447:1: warning: symbol 'write_fifo_pcimem' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:469:1: warning: symbol 'read_fifo_regio' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:491:1: warning: symbol 'read_fifo_pcimem' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:710:1: warning: symbol 'vpm_init' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:793:1: warning: symbol 'vpm_check' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:816:1: warning: symbol 'vpm_echocan_on' was not declared. Should it be static?
        drivers/isdn/hardware/mISDN/hfcmulti.c:848:1: warning: symbol 'vpm_echocan_off' was not declared. Should it be static?
      * drivers/isdn/mISDN/l1oip_codec.c:224:1: warning: symbol 'l1oip_law_to_4bit' was not declared. Should it be static?
      * drivers/isdn/mISDN/l1oip_codec.c:261:1: warning: symbol 'l1oip_4bit_to_law' was not declared. Should it be static?
      * drivers/isdn/mISDN/l1oip_codec.c:281:1: warning: symbol 'l1oip_alaw_to_ulaw' was not declared. Should it be static?
      * drivers/isdn/mISDN/l1oip_codec.c:294:1: warning: symbol 'l1oip_ulaw_to_alaw' was not declared. Should it be static?
      * drivers/isdn/mISDN/l1oip_codec.c:311:1: warning: symbol 'l1oip_4bit_free' was not declared. Should it be static?
      * drivers/isdn/mISDN/l1oip_codec.c:322:1: warning: symbol 'l1oip_4bit_alloc' was not declared. Should it be static?
        drivers/isdn/mISDN/core.c:29:1: warning: symbol 'device_lock' was not declared. Should it be static?
        drivers/isdn/mISDN/core.c:34:1: warning: symbol 'bp_lock' was not declared. Should it be static?
        drivers/isdn/mISDN/core.c:196:1: warning: symbol 'mISDNInit' was not declared. Should it be static?
        drivers/isdn/mISDN/core.c:227:6: warning: symbol 'mISDN_cleanup' was not declared. Should it be static?
        drivers/isdn/mISDN/stack.c:40:1: warning: symbol 'mISDN_queue_message' was not declared. Should it be static?
      * drivers/isdn/mISDN/layer1.c:388:1: warning: symbol 'l1_init' was not declared. Should it be static?
      * drivers/isdn/mISDN/layer1.c:400:1: warning: symbol 'l1_cleanup' was not declared. Should it be static?
        drivers/isdn/mISDN/layer2.c:469:1: warning: symbol 'iframe_error' was not declared. Should it be static?
        drivers/isdn/mISDN/layer2.c:487:1: warning: symbol 'super_error' was not declared. Should it be static?
        drivers/isdn/mISDN/layer2.c:496:1: warning: symbol 'unnum_error' was not declared. Should it be static?
        drivers/isdn/mISDN/layer2.c:509:1: warning: symbol 'UI_error' was not declared. Should it be static?
        drivers/isdn/mISDN/layer2.c:522:1: warning: symbol 'FRMR_error' was not declared. Should it be static?
        drivers/isdn/mISDN/layer2.c:1069:1: warning: symbol 'enquiry_cr' was not declared. Should it be static?
      * drivers/isdn/mISDN/layer2.c:2196:1: warning: symbol 'Isdnl2_Init' was not declared. Should it be static?
      * drivers/isdn/mISDN/layer2.c:2210:1: warning: symbol 'Isdnl2_cleanup' was not declared. Should it be static?
        drivers/isdn/mISDN/tei.c:397:1: warning: symbol 'random_ri' was not declared. Should it be static?
      * drivers/isdn/mISDN/timerdev.c:277:1: warning: symbol 'mISDN_inittimer' was not declared. Should it be static?
      * drivers/isdn/mISDN/timerdev.c:288:6: warning: symbol 'mISDN_timer_cleanup' was not declared. Should it be static?
        drivers/isdn/mISDN/dsp_core.c:164:12: warning: symbol 'mISDN_dsp_revision' was not declared. Should it be static?
        drivers/isdn/mISDN/dsp_cmx.c:1543:5: warning: symbol 'samplecount' was not declared. Should it be static?
        drivers/isdn/mISDN/dsp_cmx.c:1546:5: warning: symbol 'dsp_start_jiffies' was not declared. Should it be static?
        drivers/isdn/mISDN/dsp_cmx.c:1547:16: warning: symbol 'dsp_start_tv' was not declared. Should it be static?
        drivers/isdn/mISDN/dsp_tones.c:239:3: warning: symbol 'pattern' was not declared. Should it be static?
        drivers/isdn/mISDN/dsp_audio.c:33:4: warning: symbol 'dsp_audio_ulaw_to_alaw' was not declared. Should it be static?
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5b834354
    • Hannes Eder's avatar
      mISDN: consistently define 'debug' as '*u_int' · dfa96ec1
      Hannes Eder authored
      Impact: change data type for variable 'debug' from *int to *u_int,
      same for the argument type of mISDN_inittimer
      
      In "core.h" mISDN_inittimer is declared with the argument type "*u_int", make
      the definition in "timerdev.c" match this.
      
      This fixes also this warnings:
      
        drivers/isdn/mISDN/layer1.c:391:8: warning: incorrect type in assignment (different signedness)
        drivers/isdn/mISDN/layer1.c:391:8:    expected int *static [toplevel] debug
        drivers/isdn/mISDN/layer1.c:391:8:    got unsigned int [usertype] *deb
        drivers/isdn/mISDN/layer2.c:2200:8: warning: incorrect type in assignment (different signedness)
        drivers/isdn/mISDN/layer2.c:2200:8:    expected int *static [toplevel] debug
        drivers/isdn/mISDN/layer2.c:2200:8:    got unsigned int [usertype] *deb
        drivers/isdn/mISDN/socket.c:769:8: warning: incorrect type in assignment (different signedness)
        drivers/isdn/mISDN/socket.c:769:8:    expected int *static [toplevel] debug
        drivers/isdn/mISDN/socket.c:769:8:    got unsigned int [usertype] *deb
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      dfa96ec1
    • Hannes Eder's avatar
      mISDN: use NULL pointer instead of plain integer · bcf91745
      Hannes Eder authored
      Fix more than 100 (all remaining in mISDN) sparse warnings:
      
        drivers/isdn/hardware/mISDN/hfcmulti.c:***:**: warning: Using plain integer as NULL pointer
        drivers/isdn/mISDN/dsp_tones.c:***:**: warning: Using plain integer as NULL pointer
        drivers/isdn/mISDN/dsp_pipeline.c:***:**: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bcf91745
  2. 12 Dec, 2008 4 commits
  3. 11 Dec, 2008 10 commits
  4. 10 Dec, 2008 11 commits