An error occurred fetching the project authors.
- 08 Jul, 2008 18 commits
-
-
Christophe Jaillet authored
1) replace kmalloc/memset with equivalent kzalloc. Signed-off-by:
Christophe Jaillet <jaillet.christophe@wanadoo.fr> Cc: cj <jaillet.christophe@wanadoo.fr> Cc: petero2@telia.com Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Paolo Ciarrocchi authored
Before: total: 91 errors, 73 warnings, 2850 lines checked After: total: 1 errors, 47 warnings, 2848 lines checked Compile tested: paolo@paolo-desktop:/tmp$ size io* text data bss dec hex filename 13836 1756 11104 26696 6848 io_apic_32.o.after 13836 1756 11104 26696 6848 io_apic_32.o.before Signed-off-by:
Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Cyrill Gorcunov authored
This patch replaces some hard-coded numbers with predefined names. Signed-off-by:
Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Cyrill Gorcunov authored
Not sure but maybe it is better to use NMI_DISABLED, will take a look. But for now this patch is not change anything in logic so it will not hurt/broke the kernel. For most cases nmi_watchdog assignment is by one of NMI_* macro so I think there it make sense too. Signed-off-by:
Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Some systems incorrectly report the ExtINTA pin of the I/O APIC as the genuine target of the timer interrupt. Here is a change that copies timer pin information found to the other pin if one has been found only. This way both a direct and a through-8259A route is tested with the pin letting these problematic systems work well enough. If no timer pin information has been found for the I/O APIC, then local APIC variations are tried only, similarly to what is done without the change (except without the misleading messages). Obviously if we try the first-chance path without being told by the BIOS to do so, we should not complain either, so do not print the message in this case. The 64-bit variation should be updated with a call to replace_pin_at_irq() which can be done with the upcoming merge. Since add_pin_to_irq() is now always called in the first-chance path, the condition to require it in the second-chance path no longer happens. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Keep the timer interrupt line masked when reconfiguring its interrupt redirection entry in the I/O APIC. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Unmask the timer interrupt line set up in the through-8259A mode explicitly after setup_timer_IRQ0_pin() has set up the I/O APIC interrupt redirection entry to let the two operations be unbound from each other. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Rename setup_ExtINT_IRQ0_pin() to setup_timer_IRQ0_pin() to better reflect the upcoming role of a function setting up a (semi-)arbitrary I/O APIC pin appropriately for the 8254 timer. By "appropriate" the following settings are meant: edge-triggered, active-high, all the other settings per-architecture. Adjust comments to reflect code appropriately. No functional changes. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
The LINT0 line of the local APIC is masked in the LVT0 entry in check_timer() before this function is ever called. Removed the redundant unmasking for better control. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
For a better control the masking and unmasking of the timer interrupt line in the 8259A operating in the 'Virtual Wire' mode has been moved out of setup_ExtINT_IRQ0_pin() now, so remove the redundant calls from the function. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
When the through-8259A mode is used for the timer, the call to set_irq_handler() will register a NULL handler name, resulting in "IO-APIC-<NULL>" reported. Fix by calling ioapic_register_intr() as done for all the other I/O APIC interrupts. The 64-bit variation calls set_irq_chip_and_handler_name() here needlessly and should get fixed with the upcoming merge. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
The local APIC interrupt handler gets registered with set_irq_chip_and_handler_name(), which results in "local-APIC-edge-fasteoi" reported as the name of the handler. Fix by removing the type of the handler left over from before the generic handlers were introduced. The 64-bit variation should get fixed with the upcoming merge. NB It should really use the "edge" handler and not the "fasteoi" one, but that's a separate issue. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
There is no point in keeping the 8259A enabled if the I/O APIC NMI watchdog has failed and the 8259A is not used to pass through regular timer interrupts. This fixes problems with some systems where some logic gets confused. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Disable the 8259A acting in the "virtual wire" mode to keep the interrupt line inactive while fiddling with local APIC interrupt vector registers associated with its destination inputs. To be on the safe side, especially concerning flipping the trigger mode. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Disable the 8259A when routing of the timer interrupt through the chip to the local APIC of the primary processor has failed. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
Remove the "disable_8254_timer" and "enable_8254_timer" kernel parameters. Now that AEOI acknowledgements are no longer needed for correct timer operation, the 8259A can be kept disabled unconditionally unless interrupts, either timer or watchdog ones, are actually passed through it. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Maciej W. Rozycki authored
The code that used to be in do_slow_gettimeoffset() that relied on the IRR bit of the master 8259A PIC for IRQ0 to check the state of the output timer 0 of the PIT is no longer there. As a result, there is no need to use the POLL command to acknowledge the timer interrupt in the "8259A Virtual Wire", except for the NMI watchdog when the i82489DX APIC is used (this is because this particular APIC treats NMIs as level-triggered and keeping the input asserted would keep motherboard NMI sources held off for too long). Remove the unneeded bits and adjust comments accordingly. Signed-off-by:
Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Ingo Molnar authored
This reverts commit 0b6a39f7. The changes in tip/x86/apic solve this better. Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
- 12 Jun, 2008 1 commit
-
-
Ingo Molnar authored
This reverts commit 6e908947. Németh Márton reported: | there is a problem in 2.6.26-rc3 which was not there in case of | 2.6.25: the CPU wakes up ~90,000 times per sec instead of ~60 per sec. | | I also "git bisected" the problem, the result is: | | 6e908947 is first bad commit | commit 6e908947 | Author: Ingo Molnar <mingo@elte.hu> | Date: Fri Mar 21 14:32:36 2008 +0100 | | x86: fix ioapic bug again the original problem is fixed by Maciej W. Rozycki in the tip/x86/apic branch (confirmed by Márton), but those changes are too intrusive for v2.6.26 so we'll go for the less intrusive (repeated) revert now. Reported-and-bisected-by:
Németh Márton <nm127@freemail.hu> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
- 10 Jun, 2008 1 commit
-
-
Andreas Herrmann authored
Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
- 12 May, 2008 2 commits
-
-
Alan Mayer authored
Fixes the build error introduced by my FIRST_SYSTEM_VECTOR patch Signed-off-by:
Alan Mayer <ajm@sgi.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-
Alan Mayer authored
The SGI UV system needs several more system vectors than a vanilla x86_64 system. Rather than burden the other archs with extra system vectors that they don't use, change FIRST_SYSTEM_VECTOR to a variable, so that it can be dynamic. Signed-off-by:
Alan Mayer <ajm@sgi.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-
- 28 Apr, 2008 1 commit
-
-
PJ Waskiewicz authored
This bug was introduced in the 2.6.24 i386/x86_64 tree merge, where MSI-X vector allocation will eventually fail. The cause is the new bit array tracking used vectors is not getting cleared properly on IRQ destruction on the 32-bit APIC code. This can be seen easily using the ixgbe 10 GbE driver on multi-core systems by simply loading and unloading the driver a few times. Depending on the number of available vectors on the host system, the MSI-X allocation will eventually fail, and the driver will only be able to use legacy interrupts. I am generating the same patch for both stable trees for 2.6.24 and 2.6.25. Signed-off-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
- 26 Apr, 2008 1 commit
-
-
Jacek Luczak authored
Fix following warning: WARNING: arch/x86/kernel/built-in.o(.text+0x12cc9): Section mismatch in reference from the function unlock_ExtINT_logic() unlock_ExtINT_logic() is only used by __init check_timer(). Annotate unlock_ExtINT_logic() witch __init. Signed-off-by:
Jacek Luczak <luczak.jacek@gmail.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-
- 17 Apr, 2008 14 commits
-
-
Akinobu Mita authored
There is no reason to use obscurer name. Signed-off-by:
Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Akinobu Mita authored
Remove duplicate code by using ioapic_read_entry() and ioapic_write_entry() in io_apic_{32,64}.c Signed-off-by:
Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Jack Steiner authored
Introduce a function to read the local APIC_ID. This change is in preparation for additional changes to the APICID functions that will come in a later patch. Signed-off-by:
Jack Steiner <steiner@sgi.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Ingo Molnar authored
un-revert: commit 4960c9df Author: Thomas Gleixner <tglx@linutronix.de> Date: Tue Jan 22 10:23:01 2008 +0100 Revert "x86: fix NMI watchdog & 'stopped time' problem" This reverts commit d4d25dec. needs a proper fix though ... Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Adrian Bunk authored
This patch removes the write-only timer_uses_ioapic_pin_0 (gsi can't be <= 15 in the line of it's fake usage in mpparse_32.c). Spotted by the GNU C compiler. Signed-off-by:
Adrian Bunk <bunk@kernel.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
[ mingo@elte.hu: fix boot regression. ] Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
Alexey Starikovskiy authored
Signed-off-by:
Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-
- 30 Jan, 2008 2 commits
-
-
Julia Lawall authored
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @ change_compare_np @ expression E; @@ ( - jiffies <= E + time_before_eq(jiffies,E) | - jiffies >= E + time_after_eq(jiffies,E) | - jiffies < E + time_before(jiffies,E) | - jiffies > E + time_after(jiffies,E) ) @ include depends on change_compare_np @ @@ #include <linux/jiffies.h> @ no_include depends on !include && change_compare_np @ @@ #include <linux/...> + #include <linux/jiffies.h> // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Ingo Molnar <mingo@elte.hu> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-
Jan Beulich authored
Its previous use in a call to on_each_cpu() was pointless, as at the time that code gets executed only one CPU is online. Further, the function can be __cpuinit, and for this to work without CONFIG_HOTPLUG_CPU setup_nmi() must also get an attribute (this one can even be __init; on 64-bits check_timer() also was lacking that attribute). Signed-off-by:
Jan Beulich <jbeulich@novell.com> Signed-off-by:
Ingo Molnar <mingo@elte.hu> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-