- 31 Aug, 2010 40 commits
-
-
Jarod Wilson authored
On Fri, Aug 13, 2010 at 03:38:40PM +0200, Dan Carpenter wrote: > Speak of left over stuff, it's weird that I didn't notice this before > but gcc complains about an unitialized variable in > imon_incoming_packet(). > > drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’: > drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used > uninitialized in this function > > I don't know how to fix that, but it looks important. Ew. Yeah, that doesn't look so hot like it is right now. The old lirc_imon driver had chunk_num = buf[7], and made much more extensive use of chunk_num. Simply removing chunk_num and using buf[7] should be fine. Signed-off-by:
Jarod Wilson <jarod@redhat.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device. Signed-off-by:
Kulikov Vasiliy <segooon@gmail.com> Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Dan Carpenter authored
acpi_bus_register_driver() returns an int, not acpi_status. It returns zero on success and negative error codes on failure, but acpi_status is unsigned. We can just use "ret" here. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Dan Carpenter authored
In the original source it would write past the end of the array before returning the error code. Signed-off-by:
-
Dan Carpenter authored
In the original code there was some extra semicolons after the if statement: if (!channel_map[ieee->current_network.channel]); ^^^ >From the indenting it looked like that should be curly braces instead. Also I made some white space changes to stop checkpatch.pl from complaining. Signed-off-by:
-
Dan Carpenter authored
We never use control_req so I removed it. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Kulikov Vasiliy authored
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by:
-
Javier Martinez Canillas authored
Use DEFINE_PCI_DEVICE_TABLE() to make xgifb_pci_table const and marked as __devinitconst Signed-off-by:
Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by:
-
Javier Martinez Canillas authored
This is the first of a patch series that uses PCI_DEVICE() macro for pci table entries on comedi drivers and thus improving readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Javier Martinez Canillas authored
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by:
-
Neil Munro authored
Fixed the single spacing error in oid.h. Signed-off-by:
Neil Munro <neilmunro@gmail.com> Signed-off-by:
-
Neil Munro authored
Fixed two coding style errors in the form of pointer style issues in eeprom.h. Signed-off-by:
-
Roberto Rodriguez Alkala authored
In today linux-next I got a compile warning in staging/otus driver. This patch solves the issue and also improves the coding style. Signed-off-by:
Roberto Rodriguez Alcala <rralcala@gmail.com> Signed-off-by:
-
Denis Kirjanov authored
Remove explicit arch dependencies Signed-off-by:
Denis Kirjanov <dkirjanov@kernel.org> Signed-off-by:
-
Manuel Stahl authored
this one completes my last patch set to compile fine for all drivers. Signed-off-by:
Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
Datta, Shubhrajyoti <shubhrajyoti@ti.com> Signed-off-by:
-
Manuel Stahl authored
g -> ms/s^2 deg -> rad deg/s -> rad/s some temperatures still broken Signed-off-by:
-
Manuel Stahl authored
Signed-off-by:
-
Manuel Stahl authored
Signed-off-by:
-
Manuel Stahl authored
tested with sca3000, adis16400 Signed-off-by:
-
Manuel Stahl authored
Now fits other driver's structure for easier modification. Signed-off-by:
-
Manuel Stahl authored
bps -> bytes_per_datum ring_enable -> enable Signed-off-by:
-
Dan Carpenter authored
i2c_smbus_read_byte_data() returns an s32 type. We need to change "rate" to signed for the error handling to work. Also I changed it to propogate the error code instead of just returning -EINVAL. Other error codes could be -EAGAIN for example. Signed-off-by:
-
Julia Lawall authored
Adjust the error handling code so that it benefits from the call to mutex_unlock at the end of the function. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @rcu exists@ position p1; expression E; @@ mutex_lock@p1(E); ... mutex_unlock(E); @exists@ position rcu.p1; expression E; @@ *mutex_lock@p1(E); ... when != mutex_unlock(E); ?*return ...; // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Acked-by:
-
Dan Carpenter authored
The first kfree(pDevice) is pointless because pDevice is NULL. The second kfree(pDevice) is a double free because pDevice is the driver's private data and that is already freed by free_netdev(netdev). Also the free_netdev() error path doesn't call usb_put_dev(). Signed-off-by:
-
