- 16 Dec, 2010 23 commits
-
-
Timo Teräs authored
No one calls it anymore, so remove it. Reviewed-By:
Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Timo Teräs <timo.teras@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Timo Teräs authored
The additional abstraction is unneeded. The three calls are assumed to not be pending simultaneously: - vmbus_onoffer queues work exactly once when a new channel is created, the channel is not attached to lists until the work is executed - vmbus_onoffer_rescind is received only when the channel is active it is enough to process the work once - free_channel is called exactly once when the channel is getting destroyed; I assumed that vmbus_process_rescind_offer cannot be pending while free_channel is called Reviewed-By:
-
Timo Teräs authored
The additional abstraction is unneeded. This also fixes a sleeping while atomic issue as osd_schedule_callback can sleep which is not allowed for vmbus_on_msg_dpc running in a tasklet. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16701Reviewed-By:
-
Joe Perches authored
These macros use the equivalent of "#define WL_<type>(x) printk x" which requires an extra level of parentheses. Convert the macros to use the normal WL_<type>(fmt, args...) style and remove the extra parentheses from the uses. Add format argument verification using no_printk as appropriate. Couple of spelling typo fixes in the formats and argument alignment at the same time. Also coalesced long formats. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Michael Hennerich authored
Changes since RFC/v1: IIO: Apply list review feedback Apply list review feedback: Rename attributes to fit IIO convention used in other drivers. Fix typos. Provide ddsX_out_enable as opposed to ddsX_out_disable. Use proper __devexit marking. Use strict_strtoul() to avoid negatives. Changes since v2: IIO: ad9834.c: Apply more list review feedback Update use of dds convenience macros. Fix tabbing. Remove superfluous brackets. Keep output disabled after probe. Remove unnecessary code. Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Reviewed-by:
Datta Shubhrajyoti <shubhrajyoti@ti.com> Acked-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Michael Hennerich authored
Changes since RFC/v1: IIO: Apply list review feedback Apply list review feedback: Rename attributes to fit IIO convention used in other drivers. Provide ddsX_out_enable as opposed to ddsX_out_disable. Fix typos. Changes since v2: IIO: dds.h: Apply more list review feedback Fix mixture of X and [n] notation for indices. Remove duplicated descriptions. Add store methods to some dds convenience macros. Signed-off-by:
-
Michael Hennerich authored
Changes since RFC/v1: IIO: Apply list review feedback: Apply list review feedback: Restructure documentation according to list feedback. Rename attributes to fit IIO convention used in other drivers. Fix typos. Provide ddsX_out_enable as opposed to ddsX_out_disable Changes since v2: IIO: sysfs-bus-iio-dds: Apply more list review feedback Fix mixture of X and [n] notation for indices. Fix some wording in the descriptions. Signed-off-by:
-
Joe Perches authored
Remove now unused #define. Signed-off-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Add an #include of <linux/if_ether.h> to include/proto/ethernet.h Convert ETHER_ADDR_LEN, remove the #define for ETHER_ADDR_LEN. Signed-off-by:
-
Joe Perches authored
Use the normal kernel calls and remove the #defines for ETHER_IS_BCAST and ETHER_IS_NULLADDR. Add #include for etherdevice.h where necessary. Signed-off-by:
-
Joe Perches authored
These are unused, just remove them. Signed-off-by:
-
Joe Perches authored
Use the standard kernel function. Change callers to add .octet to addressing to avoid warnings. Add #include <linux/etherdevice.h> where necessary. Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Xenofon Foukas authored
This patch fixes the following issues in s526.c: WARNING: printk() should include KERN_ facility level WARNING: line over 80 characters ERROR: do not use C99 // comments WARNING: space prohibited between function name and open parenthesis '(' WARNING: braces {} are not necessary for any arm of this statement WARNING: suspect code indent for conditional statements (16, 16) Signed-off-by:Xenofon Foukas <foukas.xenofon@gmail.com> Signed-off-by:
-
Xenofon Foukas authored
This patch fixes the following issues in file ii_pci20kc.c: WARNING: please, no space before tabs WARNING: unnecessary whitespace before a quoted newline WARNING: line over 80 characters Signed-off-by:
-
Marek Belisko authored
During ioctl testing was observed kernel panic beuase file->private_data pointer was not correctly set when debugfs file was created. Add correct pointer setup. Signed-off-by:
Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Name of old file was misleading because it is currently updated to debugfs so change also file name. Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
L. Alberto Giménez authored
Cleaner implementation. Avoids the need of the double parenthesis to call the macro. Signed-off-by:
L. Alberto Giménez <agimenez@sysvalve.es> Signed-off-by:
-
L. Alberto Giménez authored
Fix checkpatch complains. Signed-off-by:
-
- 13 Dec, 2010 12 commits
-
-
Haiyang Zhang authored
Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
Haiyang Zhang authored
Signed-off-by:
-
L. Alberto Giménez authored
rt28xx_close and rt28xx_open are already declared in a file included in rt_config.h, so there is no need to declare them again. Signed-off-by:
-
L. Alberto Giménez authored
Fix checkpatch complains Signed-off-by:
-
Ruben Smits authored
add DEVICE_ID to table Signed-off-by:
Ruben Smits <ruben.smits@mech.kuleuven.be> Cc: stable <stable@kernel.org> Signed-off-by:
-
Xenofon Foukas authored
This patch fixes the following issues in ni_tiocmd.c: WARNING: braces {} are not necessary for any arm of this statement WARNING: braces {} are not necessary for single statement blocks WARNING: printk() should include KERN_ facility level WARNING: line over 80 characters __func__ should be used instead of gcc specific __FUNCTION__ ERROR: that open brace { should be on the previous line WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: -
Marek Belisko authored
Using gCardIndex as global variable was not correctly used because for every plugged device was set to 0 in init_ft1000_netdev. Remove global definition. Use it locally and for every plugged device extract number from net device name. Signed-off-by:
-
- 10 Dec, 2010 5 commits
-
-
Greg Kroah-Hartman authored
You should not be able to write to sysfs files from any user. Cc: Graf Yang <graf.yang@analog.com> Cc: Michael Hennerich <michael.hennerich@analog.com> Cc: Jonathan Cameron <jic23@cam.ac.uk> Cc: Mike Frysinger <vapier@gentoo.org> Signed-off-by: -
Greg Kroah-Hartman authored
You should not be able to write to a debugfs file from any user. Cc: Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by: -
Greg Kroah-Hartman authored
The driver should not have such a generic global variable name. Reported-by:
Zimny Lech <napohybelskurwysynom2010@gmail.com> Cc: Bob Beers <bob.beers@gmail.com> Signed-off-by:
-
Mark Allyn authored
Original comments were inaccurate Signed-off-by:
Mark Allyn <mark.a.allyn@intel.com> Signed-off-by:
-
Dan Carpenter authored
The if condition was ignored in the original code and we just used the default channel. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
