- 16 Aug, 2015 40 commits
-
-
Joonyoung Shim authored
The struct exynos_drm_gem_obj can have fields of the struct exynos_drm_gem_buf then don't need to use exynos_drm_buf.c file. Signed-off-by:
Joonyoung Shim <jy0922.shim@samsung.com> Signed-off-by:
Inki Dae <inki.dae@samsung.com>
-
Joonyoung Shim authored
The dma-buf codes of exynos drm is almost same with prime helpers. A difference is that consider DMA_NONE when import dma-buf, but it's wrong and we don't consider it any more, so we can use prime interface. Signed-off-by:
-
Joonyoung Shim authored
The function roundup_gem_size can be merged in exynos_drm_gem_create. Signed-off-by:
-
Joonyoung Shim authored
The function update_vm_cache_attr can be merged in exynos_drm_gem_mmap. Signed-off-by:
-
Joonyoung Shim authored
The function check_gem_flags is too simple, so it's better to move codes in each consumer functions. Signed-off-by:
-
Joonyoung Shim authored
For more correct error information. Signed-off-by:
-
Joonyoung Shim authored
The userptr, write and pfnmap of struct exynos_drm_gem_buf are not used anywhere. Signed-off-by:
-
Joonyoung Shim authored
Already struct exynos_drm_gem_buf has pages of the buffer, so we don't need to copy from sg table of the buffer to sg table of dma-buf attachment, just can make sg table from pages of the buffer. Signed-off-by:
-
Joonyoung Shim authored
The exynos_drm_gem_map_buf can be merged in exynos_drm_gem_fault. Signed-off-by:
-
Joonyoung Shim authored
There is no reason to use mutex locking in pagefault handler. Signed-off-by:
-
Joonyoung Shim authored
The convert_to_vm_err_msg is called just once by exynos_drm_gem_fault, so it's simple not to use the function. Signed-off-by:
-
Joonyoung Shim authored
Already struct exynos_drm_gem_buf has pages of the buffer when buffer is created, so just can use pages in page fault handler, we don't have to make sgtable of the buffer. But this needs to construct pages of the buffer that is imported from dma-buf prime. Signed-off-by:
-
Gustavo Padovan authored
struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal exynos_drm_encoders ops that was directly mapped to the drm_encoder helper funcs. So now exynos DRM uses struct drm_encoder directly, this removes completely the struct exynos_drm_encoder. v2: add empty .mode_fixup() and .mode_set() to DSI and DPI to avoid null pointer. Signed-off-by:
Gustavo Padovan <gustavo.padovan@collabora.co.uk> Signed-off-by:
-
Gustavo Padovan authored
As we are removing the exynos encoder move the encoder setup operation directly inside the exynos_drm_load() Signed-off-by:
-
Gustavo Padovan authored
This functions was just hiding the encoder and connector creation in a way that was less clean than if we get rid of it. For example, exynos_encoder ops had .create_connector() defined only because we were handing off the encoder and connector creation to exynos_drm_create_enc_conn(). Without this function we can directly call the create_connector function internally in the code, without the need of any vtable access. It also does some refactoring in the code like creating a bind function for dpi devices. Signed-off-by:
-
Gustavo Padovan authored
.commit() is not used anymore, Exynos encoders now follow the .enable()/.disable() semantics from drm atomic core, so remove this callback. Signed-off-by:
-
Gustavo Padovan authored
exynos_dp_commit() was getting called twice by exynos encoder core, once inside the .enable() call and another time by .commit() itself. The remove of the second call caused the wake of a bug, the operations orders inside exynos_dp_commit was wrong and we had to move exynos_dp_start_video() to be the last operation in there. Signed-off-by:
-
Gustavo Padovan authored
hdmi_commit() was getting called twice by exynos encoder core, once inside the .enable() call and another time by .commit() itself. Signed-off-by:
-
Gustavo Padovan authored
This struct was just representing encoder information, it was a member of struct exynos_drm_encoder, so any code trying to access encoder data would have to go through the encoder struct, get the display struct and then get the data it want. During this patchset we also realized that the only data exynos_drm_encoder needs to store is the drm_encoder parent and the exynos_drm_encoder_ops. Signed-off-by:
-
Gustavo Padovan authored
All CRTCs can only be LCD, HDMI or VIDI, so basically all CRTCs will be a possible CRTCs. This patch removes an extra function with switch that was only checking if the CRTC type was one of those three above. Signed-off-by:
-
Gustavo Padovan authored
These two display_ops are not used anywhere, remove them. Signed-off-by:
-
Gustavo Padovan authored
phy_power_on() and phy_power_off() already checks for NULL pointer. This patch removes the wrappers exynos_dp_phy_init() and exynos_dp_phy_exit() since the only think they were doing was a check for NULL phy. Signed-off-by:
-
Gustavo Padovan authored
The DRM Core doesn't have a dpms() operation anymore, everything now is enable() or disable(). Signed-off-by:
-
Gustavo Padovan authored
Instead of blindly ignore the return value of enable_vblank return it to the upper DRM layer for error handling. Suggested-by:
-
Gustavo Padovan authored
Rename crtc_{widht,height} to crtc_{w,h} and src_{width,height} to src_{w,h} to make it similar to the atomic state names. Signed-off-by: -
Gustavo Padovan authored
Now after the move to use drm_plane_state directly struct drm_plane_state has many unused fields, along with others that weren't used before the plane state change. Thus remove them all. Signed-off-by:
-
Gustavo Padovan authored
For some fields the use of struct exynos_drm_plane filled with data from the plane state just creates a source of duplicated information and overhead. Here we change the crtc drivers to access the plane state directly simplifying the code by not relying on a exynos internal struct. Signed-off-by:
-
Gustavo Padovan authored
We already have the plane pointer in before calling .update_plane() or disable_plane() so pass it directly to those calls avoiding a new conversion from zpos to struct exynos_drm_plane. v2: don't remove check for suspended in FIMD (comment by Joonyoung) Signed-off-by:
-
Gustavo Padovan authored
Rename win_commit() helper to update_plane() and win_disable() to disable_plane(). Signed-off-by:
-
Gustavo Padovan authored
The same check is placed twice in fimd/decon_update_plane(), remove one of them. Signed-off-by:
-
Gustavo Padovan authored
Get rid of legacy DRM vblank function that are less clear to use. The new ones basically requires only the crtc as parameters. It also clean ups exynos_drm_crtc_finish_pageflip() parameters as a consequence. Signed-off-by:
-
Gustavo Padovan authored
Instead of giving -1 to as arg to drm_send_vblank_event() pass the correct pipe number to it. Signed-off-by:
-
Joonyoung Shim authored
This is simplest solution about reported problem[1]. It's no problem to clear channel only when iommu is enabled, if we consider that we cannot recognize iommu errors when iommu is disabled and it have been valid until now. But this cannot be nice solution. [1] https://lkml.org/lkml/2015/7/21/404Reported-by:
Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by:
-
Joonyoung Shim authored
Already drm_iommu_attach_device checks whether support iommu internally. It should clear channels always regardless iommu support. We didn't know because we can detect the problem when iommu is enabled, so we don't have to use drm_iommu_attach_device_if_possible and then we can remove drm_iommu_attach_device_if_possible and clear_channels function pointer. Signed-off-by:
Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:
-
Joonyoung Shim authored
The vidi is virtual kms driver and now it is registered earlier than actual hw kms drivers, so it will occupy crtc index 0. Some users assume the condition yet that actual hw kms driver has crtc index 0. It may or may not be matter but let's arrange register order. Signed-off-by:
-
Andrzej Hajda authored
Driver uses only VSYNC interrupts, so we need to cache VSYNC bit state only. Signed-off-by:
Andrzej Hajda <a.hajda@samsung.com> Reviewed-by:
-
Andrzej Hajda authored
The driver uses bool protected by mutex to track power state. The patch replaces this combo with single bit and atomic bitops. Signed-off-by:
-
Joonyoung Shim authored
Already drm_iommu_attach_device and drm_iommu_detach_device check whether support iommu internally, so we don't have to call is_drm_iommu_supported before call them. Signed-off-by:
-
Joonyoung Shim authored
If CONFIG_ARM_DMA_USE_IOMMU is disable, CONFIG_DRM_EXYNOS_IOMMU also is disable. When CONFIG_DRM_EXYNOS_IOMMU is disable, is_drm_iommu_supported() returns always false, so we can remove to use ifdef CONFIG_ARM_DMA_USE_IOMMU in is_drm_iommu_supported(). Signed-off-by:
-
Hyungwon Hwang authored
The unique results of all the combination of rotation and flip can be represented by just 8 states. This patch handles all the combination correctly. Signed-off-by:
Hyungwon Hwang <human.hwang@samsung.com> Signed-off-by:
-
