- 11 Jun, 2012 7 commits
-
-
Nitin Gupta authored
Documentation of various struct page fields used by zsmalloc. Changes for v2: - Regroup descriptions as suggested by Konrad Signed-off-by:
Nitin Gupta <ngupta@vflare.org> Acked-by:
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by:
Minchan Kim <minchan@kernel.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Minchan Kim authored
xvmalloc can't handle PAGE_SIZE page so that zram have to handle it specially but zsmalloc can do it so let's remove unnecessary special handling code. Quote from Nitin "I think page vs handle distinction was added since xvmalloc could not handle full page allocation. Now that zsmalloc allows full page allocation, we can just use it for both cases. This would also allow removing the ZRAM_UNCOMPRESSED flag. The only downside will be slightly slower code path for full page allocation but this event is anyways supposed to be rare, so should be fine." 1. This patch reduces code very much. drivers/staging/zram/zram_drv.c | 104 +++++-------------------------------- drivers/staging/zram/zram_drv.h | 17 +----- drivers/staging/zram/zram_sysfs.c | 6 +-- 3 files changed, 15 insertions(+), 112 deletions(-) 2. change pages_expand with bad_compress so it can count bad compression(above 75%) ratio. 3. remove zobj_header which is for back-reference for defragmentation because firstly, it's not used at the moment and zsmalloc can't handle bigger size than PAGE_SIZE so zram can't do it any more without redesign. Cc: Seth Jennings <sjenning@linux.vnet.ibm.com> Signed-off-by:
-
Minchan Kim authored
fd1a30de makes a bug that it uses (struct page *) as zsmalloc's handle although it's a uncompressed page so that it can access random page, return random data or even crashed by get_first_page in zs_map_object. Cc: Seth Jennings <sjenning@linux.vnet.ibm.com> Cc: Jerome Marchand <jmarchan@redhat.com> Signed-off-by:
-
Minchan Kim authored
We should use unsigned long as handle instead of void * to avoid any confusion. Without this, users may just treat zs_malloc return value as a pointer and try to deference it. This patch passed compile test(zram, zcache and ramster) and zram is tested on qemu. changelog * from v2 - remove hval pointed out by Nitin - based on next-20120607 * from v1 - change zcache's zv_create return value - baesd on next-20120604 Cc: Dan Magenheimer <dan.magenheimer@oracle.com> Acked-by:
Seth Jennings <sjenning@linux.vnet.ibm.com> Acked-by:
-
Dan Carpenter authored
These two places seem like they should be using bitwise OR instead of bitwise AND. The first one is a noop which is equivalent to: imr |= (0x0100 & 0x0004 & 0x0001); The second is sets lcr2 to zero instead of just clearing the high bits. lcr2 &= (0x00F0 & 0x000F); Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Adnan Ali authored
This commit fixes coding style issues including braces position and line wrapping. Signed-off-by:
Adnan Ali <adnan.ali@codethink.co.uk> Reviewed-by:
Jannis Pohlmann <jannis.pohlmann@codethink.co.uk> Acked-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Andy Gross authored
Failures during the dmm probe can cause the kernel to crash. Moved the spinlock to a global and moved list initializations immediately after the allocation of the dmm private structure. Signed-off-by:
Andy Gross <andy.gross@ti.com> Reviewed-by:
Rob Clark <rob.clark@linaro.org> Signed-off-by:
-
- 09 Jun, 2012 9 commits
-
-
Miguel Gómez authored
Use DEFINE_PCI_DEVICE_TABLE() to create the device table and add MODULE_DEVICE_TABLE() to export it. Signed-off-by:
Miguel Gómez <magomez@igalia.com> Signed-off-by:
-
Miguel Gómez authored
Signed-off-by:
-
Miguel Gómez authored
Remove the error_flag field from the ipoctal structure, as the error code is handled through the tty abstraction. Remove the values definition as well. Signed-off-by:
-
Miguel Gómez authored
The configuration of the communication channel is handled by the tty abstraction, so the ipoctal_config structure has become useless and it's only used to store values that are never accesed. Remove it. Signed-off-by:
-
Miguel Gómez authored
Remove the gotos when handling error conditions, as the code gets clearer and the gotos are not really avoiding code replication. Signed-off-by:
-
Miguel Gómez authored
Remove the "out" label from tpci200_request_irq(), as it can directly return the error code instead of jumping. Signed-off-by:
-
Miguel Gómez authored
Signed-off-by:
-
Miguel Gómez authored
Remove the "out" label from tpci200_slot_map_space(), as it can directly return the error code instead of jumping. Signed-off-by:
-
Miguel Gómez authored
Handle error conditions with simple returns instead of usig gotos. Signed-off-by:
-
- 07 Jun, 2012 21 commits
-
-
Leed Aguilar authored
The raw data reading process (ak8975_read_axis) sets the single measurement mode to take a sample and once the conversion is completed the device enters into power-down mode automatically, therefore there is no need to enable a flag for this to happen. Signed-off-by:
Leed Aguilar <leed.aguilar@ti.com> Acked-by:
Jonathan Cameron <jic23@kernel.org> Acked-by:
Laxman Dewangan <ldewangan@nvidia.com> Signed-off-by:
-
Leed Aguilar authored
Use gpio_request_one api, it looks cleaner. Signed-off-by:
-
Leed Aguilar authored
Fuse ROM data access mode is the only mode which does not transition to power-down mode automatically. As per the AK8975 data sheet, it is recomended to set the power-down mode first before attempting to change into another mode. Signed-off-by:
-
Lars-Peter Clausen authored
Use scnprint instead of snprintf, because snprintf returns the number of bytes that would have been written to the buffer if there was enough space, and as a result writing to buf[len-1] might cause a access beyond the buffers limits. Reported-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
-
Michael Hennerich authored
drivers/iio/frequency/adf4350.c:316:32: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Reported-by:
-
Samuel Iglesias Gonsalvez authored
Signed-off-by:
Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
When uninstalling a device, the call to the ipack_bus_ops remove() frees resources in the ipack device driver but without unregistering the device. It generates a kernel oops when somebody wants to unregister the device. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
tpci200->info is used later when uninstalling the module. As there is another kfree in the proper place, this patch removes the wrong one. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
When uninstalling a device, there is a loop of calls that produces, at the end, two calls to __ipoctal_remove() function with the same ipack_device argument. The first time works fine, but the second will fail in tty_unregister_driver() To avoid this situation, the call to __ipoctal_remove() it is done only from the ipack bus driver and not from the ipack device driver. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
When a bus driver calls ipack_driver_register(), it should manages the returning NULL value to undo all the operations it did before this call, and print the corresponding trace. It is not a task for the ipack driver to call the remove() function here. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
Use idr interface to give the bus number. That way, we remove the limitation of 64 buses. The mutex is removed because the ida interface uses spinlocks inside, so it is not needed an extra lock. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
When ipack_device_register() is called, the variable tpci200->slots[dev->slot].dev has not assigned a value and it gives an error when the mezzanine driver is reading a register from the board for the match() function, as all the I/O functions call check_slot(). Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
This field is not needed at all, as the IRQ is registered for the carrier not for the mezzanine. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
To avoid a dereference of a NULL pointer, the availability of the function is checked before its use. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
tpci200_slot_map_space() should return 0 if the operation was properly done. If not, the caller will think that something wrong happened. This patch establish the returned value to 0. It is overwritten in case of error. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
tpci200_slot_unmap_space() should return 0 if the operation was properly done. If not, the caller will think that something wrong happened. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
It should return the same value given by the match function of the ipack_driver that has been called. Returning 0 here, means that the match has failed and it could be succeed. Signed-off-by:
-
Samuel Iglesias Gonsalvez authored
To perform the installation of a mezzanine it was needed to write on these files, now it is not needed at all as the device model is properly implemented. Signed-off-by:
-
Sachin Kamat authored
version.h header file is no longer required. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
-
- 05 Jun, 2012 3 commits
-
-
Shubhrajyoti D authored
The memory regions of the probe and remove are move to __devinit and __devexit respectively. Acked-by:
Shubhrajyoti D <shubhrajyoti@ti.com> Signed-off-by:
-
Shubhrajyoti D authored
The memory regions of the probe and remove are move to __devinit and __devexit respectively. Acked-by:
-
Lars-Peter Clausen authored
The IIO DAC drivers are in a reasonably good shape. They all make use of channel spec and non of them provides non-documented sysfs attributes. Code style should be OK as well, both checkpatch and coccicheck only report trivial issues. So lets move the whole folder out of staging. Signed-off-by:
-
