1. 07 Apr, 2003 11 commits
    • Greg Kroah-Hartman's avatar
      USB: set port->tty to NULL after we have closed the port · 2dfc4234
      Greg Kroah-Hartman authored
        
      This lets any of the many checks for this contition actually have a
      chance of working :)
      2dfc4234
    • Al Borchers's avatar
      [PATCH] USB: patch for oops in io_edgeport.c · 4340e885
      Al Borchers authored
      I tracked down a problem that caused an oops in io_edgeport.c.
      
      The oops is reliably reproduced by using an EdgePort USB serial
      port in dosemu and then exiting dosemu.  When dosemu closed
      the port the oops would occur.  (Tested in RH 7.3 2.4.18-10.)
      
      The problem was that a USB cmd callback would come in after the
      close with the tty struct freed, and the edge_bulk_out_cmd_callback
      function would do a wakeup on the tty->write_wait queue.  The
      tty struct was gone (I checked that tty->magic was bad) and the
      wakeup would oops.
      
      As you did in other places in io_edgeport.c, I added a check that
      edge_port->open was true before using the edge_port->port->tty
      struct.
      
      I added a similar check in edge_bulk_out_data_callback, though
      I never actually saw the problem here.
      
      I notice that in 2.4.20 a check has been added to be sure that
      edge_port->port->tty is not null--however, this is not enough
      because the tty pointer is not set to null when the port is
      closed.  An alternate solution in 2.4.20 would be to set the
      usb_serial_port->tty pointer to null in usbserial.c serial_close().
      This seems like a good thing to do in general, since the tty
      struct should not be used after a close which frees it.  If
      you would like I investigate this a bit more--it could affect
      other usb serial drivers and reveal some hidden bugs.
      4340e885
    • Greg Kroah-Hartman's avatar
      Merge kroah.com:/home/greg/linux/BK/bleed-2.5 · 6c7a3c95
      Greg Kroah-Hartman authored
      into kroah.com:/home/greg/linux/BK/gregkh-2.5
      6c7a3c95
    • Matthew Dharm's avatar
      [PATCH] usb-storage: add info to /proc interface · 3fe52eb6
      Matthew Dharm authored
      This patch adds some information about the quirks of the device to the
      /proc interface.
      3fe52eb6
    • Matthew Dharm's avatar
      [PATCH] usb-storage: remove BUG/BUG_ON · bee95701
      Matthew Dharm authored
      This patch changes BUG and BUG_ON to print error messages.  It is done to
      be (a) a little more robust, and (b) complies with Linus' idea of no BUGs
      unless absolutely necessary.
      bee95701
    • Matthew Dharm's avatar
      [PATCH] usb-storage: variable renames · 684fa462
      Matthew Dharm authored
      This patch changes the struct us_data 'ss' to 'us' to be consistent with
      the rest of the code.  The old name was a legacy artifact.
      
      There are no functional changes here.
      684fa462
    • Matthew Dharm's avatar
      [PATCH] usb-storage: fix CB/CBI · aa397ac4
      Matthew Dharm authored
      When we fixed the error handling, we accidentally made a mistake.  A STALL
      on a control endpoint isn't necessarily a fatal thing -- it can be used to
      indicate a command failure.
      
      This fixes bugzilla bug #510.
      
       - A control endpoint stall when sending the command to a CB/CBI device is
         legal.  Our error handling was just a little too agressive.
      aa397ac4
    • Krzysztof Halasa's avatar
      [PATCH] generic HDLC update · 80d316b7
      Krzysztof Halasa authored
      This version fixes:
      - missing rtnl_lock()/rtnl_unload() bug on unregister_hdlc_device
      - N2, C101: interrupt handler now works under high IRQ load from other
        devices (with previous versions, the IRQ processing for the card could
        sometimes stop after reaching "work limit")
      
      This is production-tested on devices I have access to (N2, C101, PC300,
      PCI200SYN).
      80d316b7
    • Zwane Mwaikambo's avatar
      [PATCH] Disable irqbalance for single cpu SMP configurations · 00c6dc1c
      Zwane Mwaikambo authored
      This patch disables irqbalance and doesn't spawn a kernel thread for
      systems which run SMP kernels and only have one online cpu.
      00c6dc1c
    • Jens Axboe's avatar
      [PATCH] kill blk_queue_empty() · 68132d89
      Jens Axboe authored
      This finally kills of blk_queue_empty().  This is similar to the patch I
      recently sent to fix the SCSI logic as well.  A lot of drivers are doing
      this in our core, mainly because that is the way they always did it:
      
      start_queue:
      	if (blk_queue_empty(q))
      		return;
      
      	rq = elv_next_request(q);
      	if (!rq)
      		return;
      
      Patch simply removes the blk_queue_empty() check, and adds a check for
      !rq return from elv_next_request() if the driver didn't already do that.
      
      Additionally, the AS io scheduler can return NULL from
      elv_next_request() if it thinks this is best. This way we are also
      prepared for that to work well.
      
      Patch was done by Nick Piggin.
      68132d89
    • Zwane Mwaikambo's avatar
      [PATCH] rng_vendor_ops init.data is referenced after being freed · a5509dae
      Zwane Mwaikambo authored
      Bug report from J Sanchez in #kernelnewbies
      a5509dae
  2. 06 Apr, 2003 1 commit
  3. 07 Apr, 2003 2 commits
  4. 06 Apr, 2003 3 commits
  5. 05 Apr, 2003 1 commit
    • Andi Kleen's avatar
      [PATCH] x86-64 merge · 2ba74897
      Andi Kleen authored
      Make it compile again and various cleanups and a few bug fixes.  Only
      changes x86-64 specific files.
      
      Most of it are S3 suspend changes from Pavel and comment spelling fixes
      from Steven Cole.
      
      - Remove now obsolete check_cpu function
      - Fix sys_ioctl prototype
      - Small optimization - use SYSCALL for 32bit signal handling.
      - Fix S3 suspend handling and split into individual files like i386 (Pavel)
      - Merge from i386 (pci fixes etc.)
      - Set correct paging attributes for IOMMU aperture
      - Fix disable apic option
      2ba74897
  6. 04 Apr, 2003 22 commits