- 30 Nov, 2011 16 commits
-
-
Sean MacLennan authored
The rtl8192e driver had a natural split between the more generic rtllib code and the more specific rtl8192e code. This patch exports all the symbols needed by the r8192 specific code from the rtllib generic code. Signed-off-by:
Sean MacLennan <seanm@seanm.ca> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Sean MacLennan authored
Rename rtl_debug.h to rtllib_debug.h. Source files should include rtllib.h if they are generic and rtl_core.h if they are r8192e specific. Files should never include both. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Sean MacLennan authored
The RTL_DEBUG enum is used for rt_global_debug_component global variable and RT_TRACE. It should be in rtl_debug.h and not rtl_core.h. The rtl8192_proc_* functions are r8192 specific and should not be in rtl_debug.h. Move them to rtl_core.h. Signed-off-by:
-
Sean MacLennan authored
This patch cleans up rtl_debug.h by removing all the unused defines and stub functions. The changes to rtl_core.c are just to remove the deleted stub function calls. The changes to rtl_debug.c are functions that are never called. Signed-off-by:
-
Andreas Ruprecht authored
The lis3l02dq_read_event_config() function returned an ssize_t up to now, which lead to a compiler warning in line 660 (initialization from incompatible pointer type). The iio_info struct is defined to accept an int-returning function as the read_event_config parameter. Also it seems odd to have the check for (ret < 0) and return ret in this case, when the return type is signed. Signed-off-by:
Andreas Ruprecht <rupran@einserver.de> Acked-by:
Jonathan Cameron <jic23@kernel.org> Signed-off-by:
-
Martyn Welch authored
The loop used to reset the interrupt masks has faulty logic. There are 4 banks of 8 I/O, however each mask is comprised of 2 bits and thus there are 8 sets of registers to clear. Driver was wrongly equating this with 8 banks leading to a us writing past the end of the "bank" array (used to store mask configuration as these registers are write only) and thus causing memory corruption. Clear both registers of masks for each bank and half iterations. Reported-by:
Martyn Welch <martyn.welch@ge.com> Signed-off-by:
-
Andreas Ruprecht authored
The function ad7280_store_balance_timer() parses data from a char* buffer into a long variable, but uses the the function strict_strtoul which expects a pointer to an unsigned long variable as its third parameter. As Dan Carpenter mentioned, the values are capped a few lines later, but a check if val is negative is missing. Now this function will return -ERANGE if there is a representation of a negative number in buf. Additionally the checkpatch.pl considers strict_strtoul as obsolete. I replaced its call with the suggested kstrtoul. Signed-off-by:
-
Thomas Meyer authored
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107Signed-off-by:
Thomas Meyer <thomas@m3y3r.de> Signed-off-by:
-
Xi Wang authored
There are two potential integer overflows in private_ioctl() if userspace passes in a large sList.uItem / sNodeList.uItem. The subsequent call to kmalloc() would allocate a small buffer, leading to a memory corruption. Reported-by:
Dan Rosenberg <drosenberg@vsecurity.com> Signed-off-by:
Xi Wang <xi.wang@gmail.com> Signed-off-by:
-
Xi Wang authored
There are two potential integer overflows in private_ioctl() if userspace passes in a large sList.uItem / sNodeList.uItem. The subsequent call to kmalloc() would allocate a small buffer, leading to a memory corruption. Reported-by:
-
Marcos Paulo de Souza authored
In all locations that call this function ignore your returna, so remove it. Signed-off-by:
Marcos Paulo de Souza <marcos.mage@gmail.com> Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by:
-
Marcos Paulo de Souza authored
This patch removes a lot of commented code, and some return calls of void functions. Signed-off-by:
-
Marcos Paulo de Souza authored
Remved some commented code, and fixed some style issues. was removed too a redundant if statement. Signed-off-by:
-
Marcos Paulo de Souza authored
Removed return call of void functions. Removed some code style issues. Signed-off-by:
-
Marcos Paulo de Souza authored
Signed-off-by:
-
Marcos Paulo de Souza authored
Removed the function iwctl_giwnwid, that just return a error code. Changes v1 to v2: Removed same functions of vt6655 and vt6656. Signed-off-by:
-
- 29 Nov, 2011 24 commits
-
-
Haiyang Zhang authored
hv_netvsc has been reviewed on netdev mailing list on 6/09/2011. All recommended changes have been made. We are requesting to move it out of staging area. Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
KY Srinivasan <kys@microsoft.com> Signed-off-by:
Mike Sterling <Mike.Sterling@microsoft.com> Acked-by:
Stephen Hemminger <shemminger@vyatta.com> Acked-by:
David S. Miller <davem@davemloft.net> Signed-off-by:
-
Andreas Ruprecht authored
The code in sca3000_store_measurement_mode() uses the variable val to do bitwise operations with an int mask and or-s it into st->rx[0] which is an entry in a u8 array (see sca3000.h). This means up to now values larger than a u8 were silently ignored and just the lower 8 bits counted into the value that was written into st->rx[0]. This code will return -ERANGE if the value in buf was too large to fit into a u8. Signed-off-by:
-
Andreas Ruprecht authored
In lis3102dq_write_frequency() we used a long variable to store the value parsed from the char* buffer buf, as there only was a strict_strtol() function to parse values. Now we have got kstrto* which allows us to convert to the right data type in most cases. In this particular function we want to write a frequency value, and it doesn't make sense to allow negative values here (as Dan Carpenter pointed out in a previous email). This means we can now parse the value into an unsigned long and get an error for invalid (e.g. negative) values. Signed-off-by:
-
Andreas Ruprecht authored
In the adis16220_write_16bit() function we used a long value to store parsed data from the char* buffer buf. The called function to actually write the data, adis16220_spi_write_reg_16(), takes a u16 value as a parameter, so up to now a value larger than u16 was silently ignored as it was only truncated when passing the parameter. Now this function will only accept values fitting into a u16. Additionally the parsing function was changed to overcome the now obsolete strict_strtol() function. Signed-off-by:
-
Kevin McKinney authored
This patch reorders the semaphore locking. It makes better sense to first evaluate fw_download_sema semaphore then NVMRdmWrmLocl semaphore. The fw_download_sema is suppose to be acquired in the START ioctl. If this is not true, then it does not make sense to continue. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
This is a cleanup patch. I've shuffled the code around to move the error handling closer to the calls. I've removed some indent levels. I've replaced break statements with direct returns. Signed-off-by:
-
Kevin McKinney authored
This patch evaluates/calls the down_trylock locking function directly, instead of storing the results in a variable and evaluating the variable. These changes were made in: IOCTL_BCM_BUFFER_DOWNLOAD_STOP and IOCTL_BCM_BUFFER_DOWNLOAD_START. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Implement the LTTng probe callbacks. One notable file here is lttng-events.h, which is the core implementation of the LTTng TRACE_EVENT macros for generation of probes and tracepoint decription from the TRACE_EVENT declarations. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Add the "lttng" virtual file to debugfs and procfs. All operations are performed through ioctls (LTTng ioctl range is already reserved upstream) on this virtual file and on anonymous file descriptors returned by these ioctls. Each file descriptor is associated with a tracer "object" (session, channel, stream, event, context). Signed-off-by:
-
Mathieu Desnoyers authored
This calibration feature is fairly limited for now, but provides an example of how this can be performed. Signed-off-by:
-
Mathieu Desnoyers authored
Events can be augmented with context information. This is dynamically configurable from the command line. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Each lttng buffer configuration (discard mode, overwrite mode, mmap support, splice support, per-cpu buffers, global buffer for metadata) is a lib ring buffer client. Signed-off-by:
-
Mathieu Desnoyers authored
x86-32 and x86-64 system call instrumentation, along with the lttng-syscalls-generate-headers.sh script that generates the headers from the system call list. See README for details. Signed-off-by:
-
Mathieu Desnoyers authored
Modifications to the in-kernel TRACE_EVENT are needed to generate the compact event descriptions and the probe code LTTng generates. These changes could apply to upstream TRACE_EVENT, but requires changing the in-kernel API. Signed-off-by:
-
Mathieu Desnoyers authored
Implement wrappers for compatibility with older kernel versions and kernels with had the libringbuffer (old) patchset applied. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
