- 18 Dec, 2011 13 commits
-
-
Gustavo F. Padovan authored
It's pointless, we aren't protecting anything since btusb_notify() schedules a work to run, then all it operation happens without protection. If protection is really needed here, we will fix it further. Acked-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
Gustavo F. Padovan <padovan@profusion.mobi>
-
Gustavo F. Padovan authored
Handling hci_conn_hash with RCU make us avoid some locking and disable tasklets. Acked-by:
-
Gustavo F. Padovan authored
Instead of using tasklet_disable() to prevent acess to the channel use, we can use RCU and improve the performance of our code. Acked-by:
-
Gustavo F. Padovan authored
spin lock doesn't fit ok anymore on the new code based on workqueues. Acked-by:
-
Gustavo F. Padovan authored
Now we can sleep in any path inside Bluetooth core, so mutex can make sense here. Acked-by:
-
Gustavo F. Padovan authored
We run everything in the same lock now. The backlog queue is useless now Acked-by:
-
Gustavo F. Padovan authored
We now run everything in process context, so the mutex lock is the best option. But in some places we still need the bh_lock_sock() Acked-by:
-
Gustavo F. Padovan authored
L2CAP timers also need to run in process context. As the works in l2cap are small we are using the system worqueue. Acked-by:
-
Gustavo F. Padovan authored
It doesn't really touch any sensitive information about hdev. So no need to lock here. Acked-by:
-
Gustavo F. Padovan authored
As HCI rx path is now done in process context it makes sense to do all the timer in process context as well. Acked-by:
-
Gustavo F. Padovan authored
Bluetooth rx task runs now in a workqueue, so it a good approach run any timer that share locking with process context code also in a workqueue. Acked-by:
-
Gustavo F. Padovan authored
Now we run everything in HCI in process context, so it's a better idea use mutex instead spin_lock. The macro remains hci_dev_lock() (and I got rid of hci_dev_lock_bh()), of course. Acked-by:
-
Marcel Holtmann authored
Run recv process in workqueue helps a lot with our processing as the recv path will also be in the process context, i.e., now all our tx and rx are in process context. Signed-off-by:
-
- 16 Dec, 2011 6 commits
-
-
Gustavo F. Padovan authored
It isn't used outside hci_conn.c Signed-off-by: -
Gustavo F. Padovan authored
Signed-off-by: -
Gustavo F. Padovan authored
Signed-off-by: -
Gustavo F. Padovan authored
le_num needs to be set to zero. Signed-off-by: -
Gustavo F. Padovan authored
It isn't used anywhere. Signed-off-by: -
Gustavo F. Padovan authored
Only the list member of the struct was used, so we now fold it into hci_conn. Signed-off-by:
-
- 02 Dec, 2011 9 commits
-
-
Andrei Emeltchenko authored
Make sure that code match exactly what comment says about pre 1.2 bluetooth version. Since this is HCI detail lmp_ver changed to hci_ver. Signed-off-by:
Andrei Emeltchenko <andrei.emeltchenko@intel.com> Acked-by:
-
Andrei Emeltchenko authored
Use bluetooth names instead of BT SIG assigned numbers Signed-off-by:
-
-
Andrei Emeltchenko authored
Check for hci_ver instead of lmp_ver Signed-off-by:
-
Cong Wang authored
This patch fixes the following memory leak reported by kmemleak: unreferenced object 0xffff880060a53840 (size 192): comm "softirq", pid 0, jiffies 4320571771 (age 1406.569s) hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff81138a1c>] create_object+0x187/0x28b [<ffffffff814be12e>] kmemleak_alloc+0x73/0x98 [<ffffffff811289d3>] __kmalloc+0xfc/0x123 [<ffffffff81386546>] usb_alloc_urb+0x1e/0x48 [<ffffffffa0130274>] btusb_send_frame+0x86/0x385 [btusb] [<ffffffffa02d8230>] hci_send_frame+0xa0/0xa5 [bluetooth] [<ffffffffa02d8a4e>] hci_cmd_task+0xa0/0xfb [bluetooth] [<ffffffff81058548>] tasklet_action+0x8f/0xef [<ffffffff81058a4c>] __do_softirq+0xf4/0x1db [<ffffffff81058bb7>] run_ksoftirqd+0x84/0x129 [<ffffffff8106f1c4>] kthread+0xa0/0xa8 [<ffffffff814dd144>] kernel_thread_helper+0x4/0x10 [<ffffffffffffffff>] 0xffffffffffffffff The problem is that when inc_tx() returns non-zero, we forgot to call usb_free_urb(). Cc: Marcel Holtmann <marcel@holtmann.org> Cc: "Gustavo F. Padovan" <padovan@profusion.mobi> Signed-off-by:WANG Cong <amwang@redhat.com> Acked-by:
-
Andrei Emeltchenko authored
Remove old code not touched for several years. Signed-off-by:
-
Andre Guedes authored
This patch adds the parameter struct and the command complete event handler to the LE Set Scan Parameter HCI command. Signed-off-by:
Andre Guedes <andre.guedes@openbossa.org> Acked-by:
-
Andre Guedes authored
This patch adds the dev_flags field to struct hci_dev. This new flags variable should be used to define flags related to BR/EDR and/or LE controller itself. It should be used to define flags which represents states from the controller. The dev_flags is cleared in case the controller sends a Reset Command Complete Event to the host. Also, this patch adds the HCI_LE_SCAN flag which was created to track if the controller is performing LE scan or not. The flag is set/cleared when the controller starts/stops scanning. This is an initial effort to stop using hdev->flags to define internal flags since it is exported to userspace by an ioctl. Signed-off-by:
-
Andrei Emeltchenko authored
Upstream Code Aurora function with minor trivial fixes. Origin: git://codeaurora.org/kernel/msm.gitSigned-off-by:
-
- 01 Dec, 2011 4 commits
-
-
Brian Gix authored
Signed-off-by:
Brian Gix <bgix@codeaurora.org> Signed-off-by:
-
Brian Gix authored
The blkcipher must be freed to avoid memory leak. Signed-off-by:
-
Brian Gix authored
Some MITM scenarios require handling of the User Passkey Request event, by querying the user, and passing the response back. Signed-off-by:
-
Brian Gix authored
For some MITM protection pairing scenarios, the user is required to enter or accept a 6 digit passkey. Signed-off-by:
-
- 23 Nov, 2011 1 commit
-
-
Gustavo F. Padovan authored
I did this as a part of a testing course at university, but it might be useful upstream as well. Signed-off-by:
-
- 21 Nov, 2011 7 commits
-
-
Andrei Emeltchenko authored
Use queue instead of stack discipline for device list. When processing dev_list with list_for_each* devices will be prosessed in order they were added (Usually BR/EDR first and AMP later). Also output from hciconfig looks nicer :-) Signed-off-by:
-
Brian Gix authored
Low Energy (LE) pairing responses must be recognized and handled differently from BR/EDR pairing responses. BR/EDR responses are handled via HCI commands by the LMP layer, and LE responses are handled by the Host. Signed-off-by:
-
Brian Gix authored
There are 4 possible User Responses to pairing requests, and they all share the same checks and handling. This restructures the handling of the two Confirm responses in preperation for the second two. Signed-off-by:
-
Andrei Emeltchenko authored
Fixes bluetooth compiling when CONFIG_BT_L2CAP is not enabled net/built-in.o: In function `hci_dev_open': (.text+0xdce9a): undefined reference to `enable_hs' Reported-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
-
Brian Gix authored
Signed-off-by:
-
David Herrmann authored
We cannot call module_put(THIS_MODULE) if this is our last reference. Otherwise, this call may cleanup our module before it returns. Gladly, the kthread API provides a simple wrapper for us. So lets use module_put_and_exit() to avoid a race condition with the module cleanup code. Signed-off-by:
David Herrmann <dh.herrmann@googlemail.com> Acked-by:
-
David Herrmann authored
We cannot call module_put(THIS_MODULE) if this is our last reference. Otherwise, this call may cleanup our module before it returns. Gladly, the kthread API provides a simple wrapper for us. So lets use module_put_and_exit() to avoid a race condition with the module cleanup code. Signed-off-by:
-
