- 08 Sep, 2014 40 commits
-
-
Ian Abbott authored
`TRIG_WAKE_EOS` is one of the values that can be OR-ed into the `flags` member of `struct comedi_cmd`. It's intended action is tune the asynchronous command to interrupt at the end of every "scan". The name is a bit of a left-over from earlier times. A better name would be `CMDF_WAKE_EOS` to match various other command flags. Define `CMDF_WAKE_EOS` with the same numeric value as the old `TRIG_WAKE_EOS` and redefine `TRIG_WAKE_EOS` as a synonym of it. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ian Abbott authored
Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Signed-off-by:
-
Ian Abbott authored
Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Also replace "TRIG_RT" with "CMDF_PRIORITY" in the kernel messages. Signed-off-by:
-
Ian Abbott authored
Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Signed-off-by:
-
Ian Abbott authored
Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Also replace "TRIG_RT" with "CMDF_PRIORITY" in kernel log messages. Signed-off-by:
-
Ian Abbott authored
Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Signed-off-by:
-
Paul Bolle authored
There's a check for CONFIG_MACH_EMGR. But the Kconfig symbol MACH_EMGR doesn't exist. Remove that check and the single #define it hides. Note that this macro isn't used by this driver anyway. Signed-off-by:
Paul Bolle <pebolle@tiscali.nl> Signed-off-by:
-
An Ha authored
Add a missing blank line after declaration to fix coding style issue. Signed-off-by:
An Ha <zero579911@gmail.com> Signed-off-by:
-
Mark Einon authored
Fix occurrences in et131x.c of: CHECK: Alignment should match open parenthesis Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Mark Einon authored
The driver supports auto-negotiation and 100BaetT_Half but doesn't advertise or list it in it's phydev. Fix that. Signed-off-by:
-
Mark Einon authored
The spinlock fbr_lock is only used in a single call sequence staring from et131x_poll. As this call is already locked by napi->poll_lock, we can remove it. Signed-off-by:
-
Mark Einon authored
Dan Carpenter reports: The patch c2ebf58b: "staging: et131x: Implement NAPI support" from Aug 21, 2014, leads to the following static checker warning: drivers/staging/et131x/et131x.c:4004 et131x_isr() warn: we tested 'status' before and it was 'true' We don't actually need the dead code, as we're now using NAPI to handle enabling interrupts - but we do need to enable interrupts if NAPI is not scheduled - so enable interrupts if this is the case. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
An Ha authored
Fix coding style issue which requires a blank line after declarations. Signed-off-by:
-
An Ha authored
Fix coding style issue where the if statement unnecessarily uses curly braces for one line statements and where the else conditional statement should follow the closing curly brace '}'. Also, the open curly brace '{' should be on the same line as the if statement. Signed-off-by: -
An Ha authored
Fix pointer placement coding style issue, where using "foo *" is preferable over "foo*". Signed-off-by:
-
An Ha authored
Fix coding style issue which requires a space before the open curly brace '{', after the open parenthesis '(', after a comma, and after the equal sign '=' in an assignment. Also, remove unnecessary whitespace after open parenthesis '(' and before a quoted newline. Signed-off-by: -
An Ha authored
Fix commenting style from C99 comments to C89 comments Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Greg Donald authored
Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by:Greg Donald <gdonald@gmail.com> Signed-off-by:
-
H Hartley Sweeten authored
The comedi skeleton driver is one of the few "hybrid" drivers with both legacy and PCI attach mechanisms. Instead of splitting this driver, just remove it. There are many other comedi drivers that provide better examples. Signed-off-by:
-
Ian Abbott authored
The "ni_at_a2150" driver determines the board type by calling `a2150_probe()`. This reads a register and converts it to a board index in the range 0 to 3. However, the board table array it indexes into (`a2150_boards[]`) only has 2 entries. Return an error from the Comedi driver "attach" handler `a2150_attach()` if the probed board index is beyond the end of the array. Signed-off-by:
-
Dmitry Voytik authored
Fix coding style issues: * put braces in all if-else branches; * limit the length of changed lines to 80 columns. checkpatch.pl warning count reduces by 3. Signed-off-by:
Dmitry Voytik <voytikd@gmail.com> Signed-off-by:
-
William Panlener authored
Kernel coding style. Breaking long lines and strings. Signed-off-by:
William Panlener <wpanlener@gmail.com> Signed-off-by:
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
Adrian Nicoara <anicoara@uwaterloo.ca> Signed-off-by:
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
-
Adrian Nicoara authored
Cleanup checkpatch.pl warnings. Signed-off-by:
-
Sudip Mukherjee authored
fixed sparse warning : context imbalance in 'pause_device' unexpected unlock this patch will generate warning from checkpatch for lines over 80 character , but since those are user-visible strings so it was not modified. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Tested-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Sudip Mukherjee authored
1) removed unused variables 2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block 3) removed the call to visor_signalqueue_empty() , this function is checking whether a signal queue is empty, but the return value of the function is not beeing used, so it is safe to remove. Signed-off-by: -
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl,rc,f; constant c; @@ - GOTO(lbl,\(rc\|rc->f\|c\)); - break; + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); - break; + rc; + goto lbl; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; @@ if (...) GOTO(lbl,...); +else GOTO(lbl,...); @@ identifier lbl; expression e,e1,e2; @@ if (e) - GOTO(lbl,e1); -else GOTO(lbl,e2); + e1; +else e2; +goto lbl; @@ identifier lbl1,lbl2; expression e,e1,e2; @@ + e1=e2; if (e) - GOTO(lbl1,e1=e2); -GOTO(lbl2,e1=e2); + goto lbl1; +goto lbl2; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
-
Julia Lawall authored
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by:
-
Mostyn Bramley-Moore authored
Annotate the lock/unlock pair in lov_stripe_lock/lov_stripe_unlock to avoid sparse warning about a context imbalance. Part of the eudyptula challenge: http://eudyptula-challenge.org/Signed-off-by:
Mostyn Bramley-Moore <mbmcode@gmail.com> Signed-off-by:
-
John L. Hammond authored
Remove the unused files lustre/obdclass/local_storage.[ch]. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Signed-off-by:
-
John L. Hammond authored
Remove the unused function llog_ioctl() and the file lustre/obdclass/llog_ioctl.c. Signed-off-by:
-
John L. Hammond authored
Remove the unused function sptlrpc_conf_target_get_rules() and its supporting functions. Signed-off-by:
-
John L. Hammond authored
In mgc_process_cfg_log() remove code to handle LLOG_CONFIG_ORIG_CTXT. This context is not setup on clients. Signed-off-by:
-
