An error occurred fetching the project authors.
- 28 Jun, 2012 2 commits
-
-
Sven Eckelmann authored
Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 25 Jun, 2012 1 commit
-
-
Sven Eckelmann authored
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 24 Jun, 2012 3 commits
-
-
Sven Eckelmann authored
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 20 Jun, 2012 6 commits
-
-
Sven Eckelmann authored
batman-adv doesn't follow the style for multiline comments that David S. Miller prefers. All comments should be reformatted to follow this consistent style to make the code slightly more readable. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
batman-adv can be compiled as part of the kernel instead of an module. In that case the linker will see all non-static symbols of batman-adv and all other non-static symbols of the kernel. This could lead to symbol collisions. A prefix for the batman-adv symbols that defines their private namespace avoids such a problem. Reported-by:
David Miller <davem@davemloft.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
batman-adv can be compiled as part of the kernel instead of an module. In that case the linker will see all non-static symbols of batman-adv and all other non-static symbols of the kernel. This could lead to symbol collisions. A prefix for the batman-adv symbols that defines their private namespace avoids such a problem. Reported-by:
David Miller <davem@davemloft.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
batman-adv can be compiled as part of the kernel instead of an module. In that case the linker will see all non-static symbols of batman-adv and all other non-static symbols of the kernel. This could lead to symbol collisions. A prefix for the batman-adv symbols that defines their private namespace avoids such a problem. Reported-by:
David Miller <davem@davemloft.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
batman-adv can be compiled as part of the kernel instead of an module. In that case the linker will see all non-static symbols of batman-adv and all other non-static symbols of the kernel. This could lead to symbol collisions. A prefix for the batman-adv symbols that defines their private namespace avoids such a problem. Reported-by:
David Miller <davem@davemloft.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
batman-adv can be compiled as part of the kernel instead of an module. In that case the linker will see all non-static symbols of batman-adv and all other non-static symbols of the kernel. This could lead to symbol collisions. A prefix for the batman-adv symbols that defines their private namespace avoids such a problem. Reported-by:
David Miller <davem@davemloft.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 18 Jun, 2012 2 commits
-
-
Matthias Schiffer authored
The primary entry and the corresponding secondary entries are missing when there are no neighbors on the primary interface. This also causes the TT entries to miss and makes nodes with multiply secondary interface fall apart since there is no way to see they are related without a primary entry. Fix this by always emitting a primary entry. Signed-off-by:
Matthias Schiffer <mschiffer@universe-factory.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 18 Apr, 2012 1 commit
-
-
Antonio Quartulli authored
Instead of using sizeof(struct ethhdr) it is strongly recommended to use the kernel macro ETH_HLEN. This patch substitute each occurrence of the former expressione with the latter one. Signed-off-by:
Antonio Quartulli <ordex@autistici.org>
-
- 16 Feb, 2012 3 commits
-
-
Sven Eckelmann authored
Signed-off-by:
Sven Eckelmann <sven@narfation.org> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
To increase readability the has_timed_out() functions has been introduced. This patch converts existing time_after() calls to use this wrapper function (if applicable). This patch also converts all timeouts to miliseconds to be consistent. Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de> Signed-off-by:
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
-
Sven Eckelmann authored
All batman-adv packets have a common 3 byte header. It can be used to share some code between different code paths, but it was never explicit stated that this header has to be always the same for all packets. Therefore, new code changes always have the problem that they may accidently introduce regressions by moving some elements around. A new structure is introduced that contains the common header and makes it easier visible that these 3 bytes have to be the same for all on-wire packets. Signed-off-by:
Sven Eckelmann <sven@narfation.org> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
- 20 Nov, 2011 2 commits
-
-
Antonio Quartulli authored
Several functions in the translation table management code assume that the tt_global_entry and tt_local_entry structures have the same initial fields such as 'addr' and 'hash_entry'. To improve the code readability and to avoid mistakes in later changes, a common substructure that substitute the shared fields has been introduced (struct tt_common_entry). Thanks to this modification, it has also been possible to slightly reduce the code length by merging some functions like compare_ltt/gtt() and tt_local/global_hash_find() Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Antonio Quartulli authored
There are two reasons for this fix: - the result of choose_orig() and vis_choose() is an index and therefore it can't be negative. Hence it is correct to make the return type unsigned too. - sizeof(int) may not be the same on ALL the architectures. Since we plan to use choose_orig() as DHT hash function, we need to guarantee that, given the same argument, the result is the same. Then it is correct to explicitly express the size of the return type (and the second argument). Since the expected length is currently 4, uint32_t is the most convenient choice. Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 08 Sep, 2011 1 commit
-
-
Joe Perches authored
Removing unnecessary messages saves code and text. Site specific OOM messages are duplications of a generic MM out of memory message and aren't really useful, so just delete them. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
- 22 Aug, 2011 2 commits
-
-
Antonio Quartulli authored
Several typos have been corrected and some sentences have been rephrased Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Antonio Quartulli authored
hash_add() returns 0 on success while returns -1 either on error and on entry already present. The caller could use such information to select its behaviour. For this reason it is useful that hash_add() returns -1 in case on error and returns 1 in case of entry already present. Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
- 20 Jun, 2011 1 commit
-
-
Antonio Quartulli authored
The local and the global translation-tables are now lock free and rcu protected. Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Acked-by:
Simon Wunderlich <siwu@hrz.tu-chemnitz.de> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 30 May, 2011 4 commits
-
-
Antonio Quartulli authored
smallest_signed_int(), seq_before() and seq_after() are very useful functions that help to handle comparisons between sequence numbers. However they were only defined in vis.c. With this patch every batman-adv function will be able to use them. Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
Documentation/CodingStyle recommends to use the form p = kmalloc(sizeof(*p), ...); to calculate the size of a struct and not the version where the struct name is spelled out to prevent bugs when the type of p changes. This also seems appropriate for manipulation of buffers when they are directly associated with p. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
Casting from pointer like 'struct orig_node*' to 'struct orig_node *' doesn't provide any additional functionality and can be savely removed. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
Sven Eckelmann authored
batman-adv uses pointers which are marked as const and should not violate that type qualifier by passing it to functions which force a cast to the non-const version. Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 08 May, 2011 1 commit
-
-
Antonio Quartulli authored
To be coherent, all the functions/variables/constants have been renamed to the TranslationTable style Signed-off-by:
Antonio Quartulli <ordex@autistici.org> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 01 May, 2011 1 commit
-
-
Marek Lindner authored
The rcu protected macros rcu_dereference() and rcu_assign_pointer() for the bat_priv->primary_if need to be used, as well as spin/rcu locking. Otherwise we might end up using a primary_if pointer pointing to already freed memory. Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 17 Apr, 2011 1 commit
-
-
Linus Lüssing authored
The rcu protected macros rcu_dereference() and rcu_assign_pointer() for the orig_node->router need to be used, as well as spin/rcu locking. Otherwise we might end up using a router pointer pointing to already freed memory. Therefore this commit introduces the safe getter method orig_node_get_router(). Signed-off-by:
Linus Lüssing <linus.luessing@web.de> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 05 Mar, 2011 7 commits
-
-
Marek Lindner authored
Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
It might be possible that 2 threads access the same data in the same rcu grace period. The first thread calls call_rcu() to decrement the refcount and free the data while the second thread increases the refcount to use the data. To avoid this race condition all refcount operations have to be atomic. Reported-by:
Sven Eckelmann <sven@narfation.org> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
Note: The function compare_ether_addr() provided by the Linux kernel requires aligned memory. Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
It might be possible that 2 threads access the same data in the same rcu grace period. The first thread calls call_rcu() to decrement the refcount and free the data while the second thread increases the refcount to use the data. To avoid this race condition all refcount operations have to be atomic. Reported-by:
Sven Eckelmann <sven@narfation.org> Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
Marek Lindner authored
Signed-off-by:
Marek Lindner <lindner_marek@yahoo.de>
-
- 31 Jan, 2011 1 commit
-
-
Sven Eckelmann authored
Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-
- 30 Jan, 2011 1 commit
-
-
Sven Eckelmann authored
The batman-adv vis server has to a stack which stores all information about packets which should be send later. This stack is protected with a spinlock that is used to prevent concurrent write access to it. The send_vis_packets function has to take all elements from the stack and send them to other hosts over the primary interface. The send will be initiated without the lock which protects the stack. The implementation using list_for_each_entry_safe has the problem that it stores the next element as "safe ptr" to allow the deletion of the current element in the list. The list may be modified during the unlock/lock pair in the loop body which may make the safe pointer not pointing to correct next element. It is safer to remove and use the first element from the stack until no elements are available. This does not need reduntant information which would have to be validated each time the lock was removed. Reported-by:
Russell Senior <russell@personaltelco.net> Signed-off-by:
Sven Eckelmann <sven@narfation.org>
-