- 03 Apr, 2009 40 commits
-
-
Julia Lawall authored
SPIN_LOCK_UNLOCKED is deprecated. The following makes the change suggested in Documentation/spinlocks.txt The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ declarer name DEFINE_SPINLOCK; identifier xxx_lock; @@ - spinlock_t xxx_lock = SPIN_LOCK_UNLOCKED; + DEFINE_SPINLOCK(xxx_lock); // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Julia Lawall authored
ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING and ME_IO_STREAM_CONFIG_WRAPAROUND both hanve 0 as the rightmost bit, and thus eg !flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING is always 0. I assume that !(flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING) and !(flags & ME_IO_STREAM_CONFIG_WRAPAROUND) were intended. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E; constant C; @@ ( !E & !C | - !E & C + !(E & C) ) // </smpl> Signed-off-by:
-
Greg Kroah-Hartman authored
VID_TYPE_CAPTURE is a v4l1 thing only. Reported-by:
Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by:
-
Julia Lawall authored
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S | x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S ) <... when != x when != if (...) { <+...x...+> } x->f = E ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by:
-
Julia Lawall authored
In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/). The result has been modified to move the initialization of usb down closer to where it is used. // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
Erik Andrén <erik.andren@gmail.com> Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Erik Andrén authored
Signed-off-by:
-
Herton Ronaldo Krzesinski authored
Adapt agnx after commit "mac80211: introduce hw config change flags", detected by following build warning: drivers/staging/agnx/pci.c:426: warning: initialization from incompatible pointer type Signed-off-by:
Herton Ronaldo Krzesinski <herton@mandriva.com.br> Signed-off-by:
-
Roel Kluin authored
Signed-off-by: -
Julia Lawall authored
If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by:
-
Huang Weiyi authored
Removed duplicated #include's in drivers/staging/altpciechdma/altpciechdma.c drivers/staging/comedi/comedidev.h drivers/staging/rt2860/rt_linux.h drivers/staging/rt2870/rt_linux.h Signed-off-by:
Huang Weiyi <weiyi.huang@gmail.com> Signed-off-by:
-
Andre Haupt authored
This eliminates checkpatch.pl warnings, that struct file_operations is usually const. The structs me4000_ai_fops_array and me4000_ao_fops_array are not modified and thus also made const. Signed-off-by:
Andre Haupt <andre@bitwigglers.org> Signed-off-by:
-
Andre Haupt authored
Signed-off-by:
-
Andre Haupt authored
Signed-off-by:
-
Andre Haupt authored
Signed-off-by:
-
Andre Haupt authored
Signed-off-by:
-
Andre Haupt authored
checkpatch.pl triggered those as false positives for trailing statements, but those lines also triggered some other warnings. Signed-off-by:
-
Andre Haupt authored
fixes some checkpatch.pl errors complaining about wrong position of the inline keyword Signed-off-by:
-
Andre Haupt authored
fixes some checkpatch.pl errors about unneccessary parentheses. Signed-off-by:
-
Andre Haupt authored
This fixes the following checkpatch.pl warnings: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> WARNING: Use #include <linux/io.h> instead of <asm/io.h> Signed-off-by:
-
Richard Kennedy authored
Add a mutex to block ioctls before the card is fully initialised and only allow one ioctl at a time. This stops udev trying to load the firmware before to card is fully up. patch ported from wlan-ng-devel Karl Relton <karllinuxtest.relton@ntlworld.com> spotted that this was missing from the staging version, http://lists.linux-wlan.com/pipermail/linux-wlan-devel/2009-February/003890.htmlSigned-off-by:
Richard Kennedy <richard@rsk.demon.co.uk> Cc: Karl Relton <karllinuxtest.relton@ntlworld.com> Signed-off-by:
-
Moritz Muehlenhoff authored
Replace hfa384x2host_16(), hfa384x2host_32(), host2hfa384x_16() and host2hfa384x_32() with standard byteorder macros. Signed-off-by:
Moritz Muehlenhoff <jmm@debian.org> Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
Moritz Muehlenhoff authored
Signed-off-by:
-
