1. 29 Apr, 2019 33 commits
  2. 19 Apr, 2019 5 commits
  3. 16 Apr, 2019 2 commits
    • Li Zhong's avatar
      scsi: core: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT · 948e922f
      Li Zhong authored
      commit 84961f28 ("[SCSI] Don't add scsi_device for devices that return
      PQ=1, PDT=0x1f") returns SCSI_SCAN_TARGET_PRESENT if inquiry returns PQ=1,
      and PDT = 0x1f. However, from the scsi spec, it seemed setting PQ=1, and
      PDT to the type it is capable to support, can also mean the device is not
      connected. E.g. we see an IBM/2145 returns PQ=1 and PDT=0 for a non-mapped
      lun (details attached at the end).
      
      This patch changes the check condition a bit, so the check don't require
      PTD to be 0x1f when PQ=1.
      
      $ echo 0 0 1 > /sys/class/scsi_host/host1/scan
      [ 2483.722186] scsi 1:0:0:1: scsi scan: INQUIRY pass 1 length 36
      [ 2483.725687] scsi 1:0:0:1: scsi scan: INQUIRY successful with code 0x0
      [ 2483.729171] scsi 1:0:0:1: scsi scan: INQUIRY pass 2 length 109
      [ 2483.732481] scsi 1:0:0:1: scsi scan: INQUIRY successful with code 0x0
      [ 2483.735911] scsi 1:0:0:1: Direct-Access     IBM      2145             0000 PQ: 1 ANSI: 6
      [ 2483.741282] scsi 1:0:0:1: Attached scsi generic sg2 type 0
      
      $ tail /proc/scsi/scsi
      Attached devices:
      Host: scsi1 Channel: 00 Id: 00 Lun: 00
        Vendor: IBM      Model: 2145             Rev: 0000
        Type:   Direct-Access                    ANSI  SCSI revision: 06
      Host: scsi0 Channel: 00 Id: 00 Lun: 00
        Vendor: IBM      Model: 2145             Rev: 0000
        Type:   Direct-Access                    ANSI  SCSI revision: 06
      Host: scsi1 Channel: 00 Id: 00 Lun: 01
        Vendor: IBM      Model: 2145             Rev: 0000
        Type:   Direct-Access                    ANSI  SCSI revision: 06
      
      $ lsscsi
      [0:0:0:0]    disk    IBM      2145             0000  /dev/sdb
      [1:0:0:0]    disk    IBM      2145             0000  /dev/sda
      [1:0:0:1]    disk    IBM      2145             0000  -
      Signed-off-by: default avatarLi Zhong <lizhongfs@gmail.com>
      Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      948e922f
    • YueHaibing's avatar
      scsi: megaraid_sas: Make megasas_host_device_list_query() static · 7c3f8ca8
      YueHaibing authored
      Fix sparse warning:
      
      drivers/scsi/megaraid/megaraid_sas_base.c:4652:1: warning:
       symbol 'megasas_host_device_list_query' was not declared. Should it be static?
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      7c3f8ca8