1. 27 Feb, 2017 2 commits
    • Manasi Navare's avatar
      drm: Add a new connector atomic property for link status · 40ee6fbe
      Manasi Navare authored
      At the time userspace does setcrtc, we've already promised the mode
      would work. The promise is based on the theoretical capabilities of
      the link, but it's possible we can't reach this in practice. The DP
      spec describes how the link should be reduced, but we can't reduce
      the link below the requirements of the mode. Black screen follows.
      
      One idea would be to have setcrtc return a failure. However, it
      already should not fail as the atomic checks have passed. It would
      also conflict with the idea of making setcrtc asynchronous in the
      future, returning before the actual mode setting and link training.
      
      Another idea is to train the link "upfront" at hotplug time, before
      pruning the mode list, so that we can do the pruning based on
      practical not theoretical capabilities. However, the changes for link
      training are pretty drastic, all for the sake of error handling and
      DP compliance, when the most common happy day scenario is the current
      approach of link training at mode setting time, using the optimal
      parameters for the mode. It is also not certain all hardware could do
      this without the pipe on; not even all our hardware can do this. Some
      of this can be solved, but not trivially.
      
      Both of the above ideas also fail to address link degradation *during*
      operation.
      
      The solution is to add a new "link-status" connector property in order
      to address link training failure in a way that:
      a) changes the current happy day scenario as little as possible, to
      avoid regressions, b) can be implemented the same way by all drm
      drivers, c) is still opt-in for the drivers and userspace, and opting
      out doesn't regress the user experience, d) doesn't prevent drivers
      from implementing better or alternate approaches, possibly without
      userspace involvement. And, of course, handles all the issues presented.
      In the usual happy day scenario, this is always "good". If something
      fails during or after a mode set, the kernel driver can set the link
      status to "bad" and issue a hotplug uevent for userspace to have it
      re-check the valid modes through GET_CONNECTOR IOCTL, and try modeset
      again. If the theoretical capabilities of the link can't be reached,
      the mode list is trimmed based on that.
      
      v7 by Jani:
      * Rebase, simplify set property while at it, checkpatch fix
      v6:
      * Fix a typo in kernel doc (Sean Paul)
      v5:
      * Clarify doc for silent rejection of atomic properties by driver (Daniel Vetter)
      v4:
      * Add comments in kernel-doc format (Daniel Vetter)
      * Update the kernel-doc for link-status (Sean Paul)
      v3:
      * Fixed a build error (Jani Saarinen)
      v2:
      * Removed connector->link_status (Daniel Vetter)
      * Set connector->state->link_status in drm_mode_connector_set_link_status_property
      (Daniel Vetter)
      * Set the connector_changed flag to true if connector->state->link_status changed.
      * Reset link_status to GOOD in update_output_state (Daniel Vetter)
      * Never allow userspace to set link status from Good To Bad (Daniel Vetter)
      Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
      Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
      Acked-by: default avatarTony Cheng <tony.cheng@amd.com>
      Acked-by: default avatarHarry Wentland <harry.wentland@amd.com>
      Cc: Jani Nikula <jani.nikula@linux.intel.com>
      Cc: Daniel Vetter <daniel.vetter@intel.com>
      Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Cc: Sean Paul <seanpaul@chromium.org>
      Signed-off-by: default avatarManasi Navare <manasi.d.navare@intel.com>
      Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
      Acked-by: Eric Anholt <eric@anholt.net> (for the -modesetting patch)
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/0182487051aa9f1594820e35a4853de2f8747b4e.1481883920.git.jani.nikula@intel.com
      40ee6fbe
    • Archit Taneja's avatar
      drm/doc: Fix up some kms function names · 7adbd209
      Archit Taneja authored
      A couple of the kms functions didn't have the correct/newest names.
      This prevented them to be identified as refs in the html doc.
      Reviewed-by: default avatarEric Engestrom <eric.engestrom@imgtec.com>
      Tested-by: default avatarEric Engestrom <eric.engestrom@imgtec.com>
      Signed-off-by: default avatarArchit Taneja <architt@codeaurora.org>
      Link: http://patchwork.freedesktop.org/patch/msgid/20170222084741.8485-1-architt@codeaurora.org
      7adbd209
  2. 26 Feb, 2017 7 commits
  3. 24 Feb, 2017 4 commits
  4. 23 Feb, 2017 9 commits
  5. 22 Feb, 2017 1 commit
  6. 21 Feb, 2017 8 commits
  7. 18 Feb, 2017 7 commits
  8. 17 Feb, 2017 2 commits
    • Jim Qu's avatar
      drm/amd/amdgpu: post card if there is real hw resetting performed · c836fec5
      Jim Qu authored
      Check whether we need to post rather than whether the asic is
      posted.  There are some cases (e.g., GPU reset or resume from
      hibernate) where we need to force post even if the asic has
      been posted.
      Signed-off-by: default avatarJim Qu <Jim.Qu@amd.com>
      Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      c836fec5
    • Dave Airlie's avatar
      Merge tag 'drm-intel-next-fixes-2017-02-17' of... · 601109c5
      Dave Airlie authored
      Merge tag 'drm-intel-next-fixes-2017-02-17' of git://anongit.freedesktop.org/git/drm-intel into drm-next
      
      i915 and GVT fixes for v4.11 merge window
      
      * tag 'drm-intel-next-fixes-2017-02-17' of git://anongit.freedesktop.org/git/drm-intel: (32 commits)
        drm/i915: Fix not finding the VBT when it overlaps with OPREGION_ASLE_EXT
        drm/i915: Pass timeout==0 on to i915_gem_object_wait_fence()
        drm/i915/gvt: Disable access to stolen memory as a guest
        drm/i915: Avoid spurious WARNs about the wrong pipe in the PPS code
        drm/i915: Check for timeout completion when waiting for the rq to submitted
        drm/i915: A hotfix for making aliasing PPGTT work for GVT-g
        drm/i915: Restore context and pd for ringbuffer submission after reset
        drm/i915: Let execlist_update_context() cover !FULL_PPGTT mode.
        drm/i915/lspcon: Fix resume time initialization due to unasserted HPD
        drm/i915/gen9+: Enable hotplug detection early
        drm/i915: Reject set-tiling-ioctl with stride==0 and a tiling mode
        drm/i915: Recreate internal objects with single page segments if dmar fails
        drm/i915/gvt: return error code if dma map iova failed
        drm/i915/gvt: optimize the inhibit context mmio load
        drm/i915/gvt: add sprite plane flip done support.
        drm/i915/gvt: add missing display part reset for vGPU reset
        drm/i915/gvt: Fix shadow context descriptor
        drm/i915/gvt: Fix alignment for GTT allocation
        drm/i915/gvt: fix crash at function release_shadow_wa_ctx
        drm/i915/gvt: enable IOMMU for gvt
        ...
      601109c5