- 08 Sep, 2014 40 commits
-
-
Greg Donald authored
Fix checkpatch.pl "space required before that '*'" errors Signed-off-by:
Greg Donald <gdonald@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Eli Billauer authored
Suggested-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Eli Billauer <eli.billauer@gmail.com> Signed-off-by:
-
Eli Billauer authored
* Blank lines between a function call and its return status check were removed. * Double blank lines were removed. * Blank lines were added and removed as to silence checkpatch.pl --strict Suggested-by:
-
Eli Billauer authored
Signed-off-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Trivial comments removed, and one comment clarified Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Rather than checking the wait condition, the return value of wait_event_interruptible() and wait_event_interruptible_timeout() is used. Suggested-by:
-
Eli Billauer authored
"rc" is often used to hold the return value of a function call. This patch removes unnecessary assignments to this variable, and makes a few related execution flow improvements. Suggested-by:
-
Eli Billauer authored
The -EAGAIN status is passed through an "rc" variable instead of a less common flow. Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
xilly_scan_idt() now returns an error status code, rather than being a void function and hint the status through an entry in a data structure. Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Responding to an interrupt while handling the "release" method can't end well anyhow. In practical cases, this can force the user to wait up to one second while flushing remaining data is attempted (a timeout on the flush mechanism limits the time for flushing). Suggested-by:
-
Eli Billauer authored
Suggested-by:
-
Eli Billauer authored
Replace devm_kzalloc where it applies. Suggested-by:
-
H Hartley Sweeten authored
For aesthetics, move the analog input (*insn_read) function so it is not located in the middle of the async command support functions. Also, rename it for consistency. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
Signed-off-by:
-
H Hartley Sweeten authored
The analog input FIFO is reset at the start of every (*insn_read) and (*do_cmd) operation. It's also reset for the analog input (*cancel). There's no reason to reset the FIFO if an (*insn_read) times out or after all the samples have been acquired. Signed-off-by:
-
H Hartley Sweeten authored
Introduce a helper function to program the AMCC master write address and transfer count registers to setup a DMA transaction. Signed-off-by:
-
H Hartley Sweeten authored
Introduce a helper function to program the AMCC master control/status register to enable/disable dma. Signed-off-by:
-
H Hartley Sweeten authored
Introduce a helper function to program the AMCC interrupt control/ status register to enable/disable interrupts. Fix the analog input (*cancel). The analog input async command support is the only interrupt generator. The (*cancel) should always disable interrupts. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase member of the private data. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase member of the private data. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase member of the private data. Signed-off-by:
-
H Hartley Sweeten authored
Currently the analog input range and aref are set in setup_channel_list(). This works for the (*insn_read) but the (*do_cmd) has a problem. In (*do_cmd) the ai control register is reset to 0 before the function works out the bits needed to control the acquisition. This happens after the setup_channel_list() call so the range is reset to bipolar and the aref to single-ended. Introduce a helper function, pci9118_ai_set_range_aref(), to handle the programming of the range and aref bits. This function first clears the cached value of the ai control register in the private data then sets the appropriate bits. The (*insn_read) and (*do_cmd) can then set the other bits needed to control the acquisition. Then setup_channel_list() just needs to program the chanlist scan data. Signed-off-by:
-
H Hartley Sweeten authored
The analog input (*insn_read) in this driver is done as a software-triggered, polled operation. The PCI9118_AI_CTRL_INT bit in the control register, which is actually set in setup_channel_list(), should not be set. Signed-off-by:
-
H Hartley Sweeten authored
Change the return type to void, this function always succeeds and the callers never check the return value. According to the The User Manual for the PCI-9118, the hardware does not require any particular "reset" in order to function. Simplify the reset so it justs gets the board info a known state with interrupts disabled. There is no reason to initialize the private data members in this function. They all default to '0' due to the kzalloc() of the private data and the subdevice operations all initialize them as needed. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, move the analog output (*insn_write) function so it is not located in the middle of the analog input functions. Also, rename it for consistency. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. The board is "reset" prior to the subdevice init. Part of this reset sets all the analog output channels to 0V. Move the initialization of the 'readback' values after the 'readback' member has been allocated. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, move the digital inputs (*insn_bits) function so it is not located in the middle of the analog input functions. Also, rename it for consistency. Signed-off-by:
-
H Hartley Sweeten authored
Currently this driver resets the digital output channels to a low state when the driver is attached and detached. Since the digital output state can be read, initialize the subdevice state when the driver is attached and don't reset them. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, move the digital outputs (*insn_bits) function so it is not located in the middle of the analog input functions. Also, rename it for consistency. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase defines used for the interrupt control/status register bits and convert them to bit shifts. Signed-off-by:
-
H Hartley Sweeten authored
The register at offset 0x38 is the "interrupt control" register when written and the "interrupt status" register when read. Both registers use the same bit defines. For aesthetics, use a common define for this register. Signed-off-by:
-
H Hartley Sweeten authored
Introduce a helper function to reset the analog input FIFO. For aesthetics, rename the register used to reset the FIFO. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase defines used for the analog input config register bits and convert them to bit shifts. Signed-off-by:
-
