1. 08 May, 2012 1 commit
  2. 07 May, 2012 2 commits
  3. 06 May, 2012 1 commit
    • Mark Hills's avatar
      ALSA: echoaudio: Remove incorrect part of assertion · c914f55f
      Mark Hills authored
      This assertion seems to imply that chip->dsp_code_to_load is a pointer.
      It's actually an integer handle on the actual firmware, and 0 has no
      special meaning.
      
      The assertion prevents initialisation of a Darla20 card, but would also
      affect other models. It seems it was introduced in commit dd7b254d.
      
      ALSA sound/pci/echoaudio/echoaudio.c:2061 Echoaudio driver starting...
      ALSA sound/pci/echoaudio/echoaudio.c:1969 chip=ebe4e000
      ALSA sound/pci/echoaudio/echoaudio.c:2007 pci=ed568000 irq=19 subdev=0010 Init hardware...
      ALSA sound/pci/echoaudio/darla20_dsp.c:36 init_hw() - Darla20
      ------------[ cut here ]------------
      WARNING: at sound/pci/echoaudio/echoaudio_dsp.c:478 init_hw+0x1d1/0x86c [snd_darla20]()
      Hardware name: Dell DM051
      BUG? (!chip->dsp_code_to_load || !chip->comm_page)
      Signed-off-by: default avatarMark Hills <mark@pogo.org.uk>
      Cc: <stable@kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c914f55f
  4. 05 May, 2012 3 commits
  5. 04 May, 2012 1 commit
  6. 30 Apr, 2012 3 commits
  7. 25 Apr, 2012 1 commit
  8. 24 Apr, 2012 2 commits
  9. 23 Apr, 2012 3 commits
  10. 20 Apr, 2012 1 commit
  11. 19 Apr, 2012 6 commits
  12. 18 Apr, 2012 2 commits
  13. 17 Apr, 2012 1 commit
  14. 13 Apr, 2012 2 commits
    • Jesper Juhl's avatar
      ASoC: cs42l73: don't use negative array index · 86fc4998
      Jesper Juhl authored
      If cs42l73_get_mclkx_coeff() returns < 0 (which it can) in
      sound/soc/codecs/cs42l73.c::cs42l73_set_mclk(), then we'll be using
      the (negative) return value as array index on the very next line of
      code - that's bad.
      
      Catch the negative return value and propagate it to the caller (which
      checks for it) and things are a bit more sane :-)
      Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
      Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      86fc4998
    • Jesper Juhl's avatar
      ALSA: hda/realtek - Fix mem leak (and rid us of trailing whitespace). · 7d7eb9ea
      Jesper Juhl authored
      In sound/pci/hda/patch_realtek.c::alc_auto_fill_dac_nids(), in the
      'for (;;)' loop, if the 'badness' value returned from
      fill_and_eval_dacs() is negative, then we'll return from the function
      without freeing the memory we allocated for 'best_cfg', thus leaking.
      Fix the leak by kfree()'ing the memory when badness is negative.
      
      While I was there I also noticed some trailing whitespace in the
      function that I removed (along with all other trailing whitespace in
      the file) - it didn't seem worth-while to do that as two patches, so I
      hope it's OK that I just did it all as one patch.
      Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      7d7eb9ea
  15. 12 Apr, 2012 4 commits
  16. 11 Apr, 2012 1 commit
  17. 10 Apr, 2012 3 commits
  18. 07 Apr, 2012 3 commits