- 16 Nov, 2017 1 commit
-
-
git://people.freedesktop.org/~agd5f/linuxDave Airlie authored
Various fixes for DC for 4.15. * 'drm-next-4.15-dc' of git://people.freedesktop.org/~agd5f/linux: drm/amd/display: fix MST link training fail division by 0 drm/amd/display: Fix formatting for null pointer dereference fix drm/amd/display: Remove dangling planes on dc commit state drm/amd/display: add flip_immediate to commit update for stream drm/amd/display: Miss register MST encoder cbs drm/amd/display: Fix warnings on S3 resume drm/amd/display: use num_timing_generator instead of pipe_count drm/amd/display: use configurable FBC option in dm drm/amd/display: fix AZ clock not enabled before program AZ endpoint amdgpu/dm: Don't use DRM_ERROR in amdgpu_dm_atomic_check
-
- 14 Nov, 2017 6 commits
-
-
Eric Yang authored
When link training fail in MST case, we will divide by 0 when calculating avg_time_slots_per_mtp, so we cannot proceed. Signed-off-by:
Eric Yang <Eric.Yang2@amd.com> Reviewed-by:
Harry Wentland <Harry.Wentland@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Harry Wentland authored
Signed-off-by:
-
Leo (Sunpeng) Li authored
When disabling pipe splitting, we need to make sure we disable both planes used. This should be done for Linux as well. Signed-off-by:
Leo (Sunpeng) Li <sunpeng.li@amd.com> Reviewed-by:
Tony Cheng <Tony.Cheng@amd.com> Acked-by:
-
Bhawanpreet Lakha authored
This struct is not updated on page flip and causes vblank_mode to not work as expected Signed-off-by:
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> Signed-off-by:
-
Jerry (Fangzhi) Zuo authored
It is to fix: MST display failed to resume from S3 Need to properly setup MST encoder cbs. Otherwise drm_device encoder doesn't register its own cbs, leading to NULL encoder->funcs in drm_atomic_helper_resume(). Signed-off-by:
Jerry (Fangzhi) Zuo <Jerry.Zuo@amd.com> Reviewed-by:
Roman Li <Roman.Li@amd.com> Acked-by:
-
Leo (Sunpeng) Li authored
This is a followup to the following revert: Rex Zhu Revert "drm/amd/display: Match actual state during S3 resume." Three things needed to be addressed: 1. Potential memory leak on dc_state creation in atomic_check during s3 resume 2. Warnings are now seen in dmesg during S3 resume 3. Since dc_state is now created in atomic_check, what the reverted patch was addressing needs to be reevaluated. This change addresses the above: 1. Since the suspend procedure calls drm_atomic_state_clear, our hook for releasing the dc_state is called. This frees it before atomic_check creates it during resume. The leak does not occur. 2. The dc_crtc/plane_state references kept by the atomic states need to be released before calling atomic_check, which warns if they are non-null. This is because atomic_check is responsible for creating the dc_*_states. This is a special case for S3 resume, since the atomic state duplication that occurs during suspend also copies a reference to the dc_*_states. 3. See 2. comments are also updated to reflect this. Reviewed-by:Andrey Grodzovsky <andrey.grodzovsky@amd.com> Signed-off-by:
-
- 13 Nov, 2017 3 commits
-
-
Ken Chalmers authored
The two are not necessarily the same. Signed-off-by:
Ken Chalmers <ken.chalmers@amd.com> Reviewed-by:
-
Roman Li authored
Replace ENABLE_FBC macro with config option CONFIG_DRM_AMD_DC_FBC in dm. DC code has been already updated the same way. Signed-off-by:
Shirish Shankarappa <Shirish.S@amd.com> Acked-by:
-
Charlene Liu authored
Signed-off-by:
Charlene Liu <charlene.liu@amd.com> Reviewed-by:
Anthony Koo <Anthony.Koo@amd.com> Acked-by:
-
- 09 Nov, 2017 2 commits
-
-
Michel Dänzer authored
The atomic_check hook is expected to fail in some cases, e.g. if the modeset operation requested by userspace cannot be performed, so it must not spam dmesg on failure. Fixes spurious [drm:amdgpu_dm_atomic_check [amdgpu]] *ERROR* Atomic state validation failed with error :-35 ! error messages on DPMS off with CONFIG_DEBUG_WW_MUTEX_SLOWPATH enabled. While we're at it, fix up the existing DRM_DEBUG_DRIVER strings. Signed-off-by:
-
git://people.freedesktop.org/~agd5f/linuxDave Airlie authored
A bunch of smatch fixes for the dc code. * 'drm-next-4.15-dc' of git://people.freedesktop.org/~agd5f/linux: amd/display: Fix potential null dereference in dce_calcs.c amdgpu/dm: Remove unused forward declaration drm/amdgpu: Remove unused dc_stream from amdgpu_crtc amdgpu/dc: Fix double unlock in amdgpu_dm_commit_planes amdgpu/dc: Fix missing null checks in amdgpu_dm.c amdgpu/dc: Fix potential null dereferences in amdgpu_dm.c amdgpu/dc: fix more indentation warnings amdgpu/dc: handle allocation failures in dc_commit_planes_to_stream. amdgpu/dc: fix indentation warning from smatch. amdgpu/dc: fix non-ansi function decls. drm/amd/display: remove some unneeded code drm/amd/display: checking for NULL instead of IS_ERR() drm/amd/display: small cleanup in destruct()
-
- 08 Nov, 2017 3 commits
-
-
Ernst Sjöstrand authored
Reported by smatch: bw_calcs() error: potential null dereference 'data' Reviewed-by:
Ernst Sjöstrand <ernstp@gmail.com> Signed-off-by:
-
Harry Wentland authored
dc_stream has long been renamed to dc_stream_state, so this forward declaration hasn't been used at all. Signed-off-by:
-
Harry Wentland authored
It's no longer used. In fact, there is no more dc_stream object. Signed-off-by:
-
- 07 Nov, 2017 10 commits
-
-
Ernst Sjöstrand authored
Reported by smartch: amdgpu_dm_commit_planes() error: double unlock 'spin_lock:&crtc->dev->event_lock' amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags' The error path doesn't return so we only need a single unlock. Reviewed-by:
-
Ernst Sjöstrand authored
From smatch: error: we previously assumed X could be null Acked-by:
Christian König <christian.koenig@amd.com> Reviewed-by:
-
Ernst Sjöstrand authored
Acked-by:
-
Ernst Sjöstrand authored
More "warn: inconsistent indenting" fixes from smatch. Acked-by:
-
Dave Airlie authored
Reported-by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:966 dc_commit_planes_to_stream() error: potential null dereference 'flip_addr'. (kcalloc returns null) drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:968 dc_commit_planes_to_stream() error: potential null dereference 'plane_info'. (kcalloc returns null) drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:978 dc_commit_planes_to_stream() error: potential null dereference 'scaling_info'. (kcalloc returns null) Reviewed-by:
Dave Airlie <airlied@redhat.com> Signed-off-by:
-
Dave Airlie authored
This fixes all the current smatch: warn: inconsistent indenting Reviewed-by:
-
Dave Airlie authored
smatch reported: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func' This fixes them. Reviewed-by:
-
Dan Carpenter authored
We assign "v_init = asic_blank_start;" a few lines earlier so there is no need to do it again inside the if statements. Also "v_init" is unsigned so it can't be less than zero. Acked-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
backlight_device_register() never returns NULL, it returns error pointers on error so the check here is wrong. Acked-by:
-
Dan Carpenter authored
Static analysis tools get annoyed that we don't indent this if statement. Actually, the if statement isn't required because kfree() can handle NULL pointers just fine. The DCE110STRENC_FROM_STRENC() macro is a wrapper around container_of() but it's basically a no-op or a cast. Anyway, it's not really appropriate here so it should be removed as well. Acked-by:
-
- 02 Nov, 2017 13 commits
-
-
git://people.freedesktop.org/~agd5f/linuxDave Airlie authored
A few fixes for DC for 4.15. * 'drm-next-4.15-dc' of git://people.freedesktop.org/~agd5f/linux: drm/amdgpu/display: fix integer arithmetic problem drm/amdgpu/display: remove unused REG_OFFSET macro drm/amdgpu/display: provide ASSERT macros unconditionally drm/amd/display: Read resource_straps from registers for DCE12 drm/amd: Add DCE12 resource strap registers drm/amd/display: Explicitly call ->reset for each object drm/amd/display: Use single fail label in init_drm_dev drm/amd/display: Use plane pointer to avoid line breaks drm/amd/display: fix null pointer dereference amdgpu/dc: Avoid dereferencing NULL pointer drm/amd/display: Don't print error when bo_pin is interrupted drm/amd/display: Use constants from atom.h for HDMI caps read drm/amd/display: check if modeset is required before adding plane drm/amd/display: fix high part address in dm_plane_helper_prepare_fb() drm/amd/display : add high part address calculation for underlay drm/amd/display: Fix no display on Fiji Revert "drm/amd/display: Match actual state during S3 resume."
-
Arnd Bergmann authored
gcc warns about an ambiguous integer calculation: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function 'calculate_bandwidth': drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:534:5: error: this decimal constant is unsigned only in ISO C90 [-Werror] data->lb_line_pitch = bw_ceil2(bw_mul(bw_div(bw_frc_to_fixed(2401171875, 100000000), bw_int_to_fixed(3)), bw_ceil2(data->source_width_in_lb, bw_int_to_fixed(8))), bw_int_to_fixed(48)); ^~~~ Marking the constant as explicitly unsigned makes it work fine everywhere without warnings. Reviewed-by:Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Arnd Bergmann authored
The name conflicts with another macro of the same name on the ARM ixp4xx platform, leading to build errors. Neither of the users actually should use a name that generic, but the other one was here first and the dc driver doesn't actually use it. Reviewed-by:
-
Arnd Bergmann authored
It seems impossible to build this driver without setting either CONFIG_DEBUG_KERNEL or CONFIG_DEBUG_DRIVER: drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h: In function 'set_reg_field_value_ex': drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:132:2: error: implicit declaration of function 'ASSERT'; did you mean 'IS_ERR'? [-Werror=implicit-function-declaration] This moves the ASSERT() macro and related helpers outside of the #ifdef to get it to build again. Reviewed-by:
-
Leo (Sunpeng) Li authored
Now that the registers exist, assign them to the resource_straps struct. v2: Fix indentation v3: Fix trailing whitespace and checkpatch warnings. bug: https://bugs.freedesktop.org/show_bug.cgi?id=103404Reviewed-by:
-
Leo (Sunpeng) Li authored
We need them for initializing audio properly. Signed-off-by:
-
Harry Wentland authored
We need to avoid calling reset after detection because the next commit adds freesync properties on the atomic_state which are set during detection. Calling reset after this clears them. The easiest way to accomplish this right now is to call ->reset on the connector right after creation but before detection. To stay consistent call ->reset on every other object as well after creation. v2: Provide better reason for this change in commit msg. Signed-off-by:
-
Harry Wentland authored
No need for multiple labels as kfree will always do a NULL check before freeing the memory. Signed-off-by:
-
Harry Wentland authored
Signed-off-by:
Mikita Lipski <Mikita.Lipski@amd.com> Reviewed-by:
-
Shirish S authored
While setting cursor position in case of mpo, input_pixel_processor is not available for underlay, hence add check of the same to avoid null pointer access issue. Signed-off-by:
-
Drew Davenport authored
crtc is dereferenced from within drm_atomic_get_new_crtc_state, so check for NULL before initializing new_crtc_state. Signed-off-by:
Drew Davenport <ddavenport@chromium.org> Reviewed-by:
-
Harry Wentland authored
v2: Also don't print for ERESTARTSYS or EAGAIN v3: Best practice is to only ignore ERESTARTSYS Signed-off-by:
-
Andrew Jiang authored
Get rid of the constant we copied over before and just directly use the constants from the file. Signed-off-by:
Andrew Jiang <Andrew.Jiang@amd.com> Reviewed-by:
-
- 27 Oct, 2017 2 commits
-
-
Shirish S authored
Adding affected planes without checking if modeset is requested from the user space causes performance regression in video p/b scenarios when full screen p/b is not composited. Hence add a check before adding a plane as affected. bug: https://bugs.freedesktop.org/show_bug.cgi?id=103408Acked-by:
-
Shirish S authored
The high part calculation of luma and chroma address' was missing in dm_plane_helper_prepare_fb(). This fix brings uniformity in the address' at atomic_check and atomic_commit for both RGB & YUV planes. Signed-off-by:
-
