1. 15 Aug, 2012 16 commits
  2. 14 Aug, 2012 19 commits
  3. 13 Aug, 2012 5 commits
    • David Härdeman's avatar
      [media] rc-core: move timeout and checks to lirc · f8e00d5f
      David Härdeman authored
      The lirc TX functionality expects the process which writes (TX) data to
      the lirc dev to sleep until the actual data has been transmitted by the
      hardware.
      
      Since the same timeout calculation is duplicated in more than one driver
      (and would have to be duplicated in even more drivers as they gain TX
      support), it makes sense to move this timeout calculation to the lirc
      layer instead.
      
      At the same time, centralize some of the sanity checks.
      Signed-off-by: default avatarDavid Härdeman <david@hardeman.nu>
      Cc: Jarod Wilson <jwilson@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f8e00d5f
    • Malcolm Priestley's avatar
      [media] lmedm04: fix data usage past the end of the buffer · 0a67fe45
      Malcolm Priestley authored
      On Mon, 2012-08-13 at 19:58 +0300, Dan Carpenter wrote:
      > Hello Mauro Carvalho Chehab,
      >
      > The patch db6651a9: "[media] lmedm04: fix build" from Aug 12,
      > 2012, leads to the following warning:
      > drivers/media/dvb/dvb-usb-v2/lmedm04.c:769 lme2510_download_firmware()
      > 	 error: usb_control_msg() 'data' too small (128 vs 265)
      >
      >    737          data = kzalloc(128, GFP_KERNEL);
      >                                ^^^
      > data is 128 bytes.
      
      Control isn't used, so remove it.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      0a67fe45
    • Michael Krufky's avatar
      [media] DVB: improve handling of TS packets containing a raised TEI bit · ae530205
      Michael Krufky authored
      When the TEI bit is raised, we should not trust any of the contents of
      the packet in question, including but not limited to its PID number.
      
      Considering that we don't trust the PID number of this packet, we should
      not proceed to check the packet counter (if dvb_demux_tscheck is set).
      
      We should expect to see at least one discontinuity after a bad packet is
      received, so any time a TEI is detected, a following TS packet counter
      mismatch is to be expected.
      
      There is no real reason to ever allow bad packets to pass through the
      kernel demux, other than for purposes of attempting error correction via
      software or statistical information.
      
      However, since we have always passed these bad packets though the demux,
      we should not change this default behavior.
      
      Without altering module options, this patch merely prevents the
      TS packet counter check on packets containing a raised TEI.
      
      If module option dvb_demux_feed_err_pkts is set to 0, the kernel demux
      will drop these error packets entirely, preventing any possibility of
      corruption caused by userspace programs that are expecting valid data.
      Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ae530205
    • Emil Goode's avatar
      [media] cx88: Remove duplicate const · d9bc8510
      Emil Goode authored
      This patch fixes the following sparse warnings
      by removing use of duplicate const.
      
      drivers/media/video/cx88/cx88.h:152:40:
      	warning: duplicate const
      drivers/media/video/cx88/cx88-core.c:256:33:
      	warning: duplicate const
      drivers/media/video/cx88/cx88-alsa.c:769:41:
      	warning: duplicate const
      
      As commented by Jonathan Nieder:
      
      	These double "const" were introduced in v2.6.37-rc1~64^2~464 (V4L/DVB:
      	drivers/media: Make static data tables and strings const, 2010-08-25).
      
      	The address of an array is already immutable by definition, so for
      	what it's worth, with or without a clarified commit message,
      
      [mchehab@redhat.com: Tested with "gcc -s" (version 4.7.0):
       the produced asm is indeed equal before and after this patch]
      Signed-off-by: default avatarEmil Goode <emilgoode@gmail.com>
      Acked-by: default avatarJonathan Nieder <jrnieder@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      d9bc8510
    • Mauro Carvalho Chehab's avatar
      [media] frontend.h, Docbook: Improve status documentation · 0d27bbfe
      Mauro Carvalho Chehab authored
      No functional changes. It just improves the description of the frontend
      status, using Documentation/kernel-doc-nano-HOWTO.txt for the status
      enumeration, and a table inside the DocBook.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      0d27bbfe