- 01 Mar, 2014 26 commits
-
-
Liang Zhen authored
If a ptlrpc_request is already on imp::imp_replay_list, when it's replayed and replied, after_reply() will call req::rq_commit_cb for the request, then call it again in ptlrpc_free_committed. Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-on: http://review.whamcloud.com/8815 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3618Reviewed-by:
Alex Zhuravlev <alexey.zhuravlev@intel.com> Reviewed-by:
Bobi Jam <bobijam@gmail.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Peng Tao authored
ptl_send_rpc is not dealing with -ENOMEM in some situations. When the ptl_send_rpc fails we need set error and skip further processing or trigger and LBUG Signed-off-by:
Keith Mannthey <keith.mannthey@intel.com> Signed-off-by:
Peng Tao <bergwolf@gmail.com> Reviewed-on: http://review.whamcloud.com/7411 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3698Reviewed-by:
Mike Pershin <mike.pershin@intel.com> Reviewed-by:
-
Liang Zhen authored
osc_extent_wait can be stuck in scenario like this: 1) thread-1 held an active extent 2) thread-2 called flush cache, and marked this extent as "urgent" and "sync_wait" 3) thread-3 wants to write to the same extent, osc_extent_find will get "conflict" because this extent is "sync_wait", so it starts to wait... 4) cl_writeback_work has been scheduled by thread-4 to write some other extents, it has sent RPCs but not returned yet. 5) thread-1 finished his work, and called osc_extent_release()-> osc_io_unplug_async()->ptlrpcd_queue_work(), but found cl_writeback_work is still running, so it's ignored (-EBUSY) 6) thread-3 is stuck because nobody will wake him up. This patch allows ptlrpcd_work to be rescheduled, so it will not miss request anymore Signed-off-by:
Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-by:
-
Sebastien Buisson authored
Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by:
Sebastien Buisson <sebastien.buisson@bull.net> Reviewed-on: http://review.whamcloud.com/6575 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2744Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Niu Yawei authored
In osc_quota_chkdq(), we should never try to access oqi found from hash, since it could have been freed by osc_quota_setdq(). Signed-off-by:
Niu Yawei <yawei.niu@intel.com> Reviewed-on: http://review.whamcloud.com/8460 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4336Reviewed-by:
Johann Lombardi <johann.lombardi@intel.com> Reviewed-by:
Fan Yong <fan.yong@intel.com> Signed-off-by:
-
Ann Koehler authored
The extent is active so we need to abort and let the caller re-dirty the page. If we continued on here, and we were the one making the extent active, we could deadlock waiting for the page writeback to clear but it won't because the extent is active and won't be written out. Signed-off-by:
Ann Koehler <amk@cray.com> Reviewed-on: http://review.whamcloud.com/8278 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4253Reviewed-by:
Alexey Lyashkov <alexey_lyashkov@xyratex.com> Reviewed-by:
-
Oleg Drokin authored
libcfs cpu partition can't support CPU hotplug, but it is safe when plug-in new CPU or enabling/disabling hyper-threading. It has potential risk only if plug-out CPU because it may break CPU affinity of Lustre threads. Current libcfs will print warning for all CPU notification, this patch changed this behavior and only output warning when we lost all HTs in a CPU core which may have broken affinity of Lustre threads. Signed-off-by:
-
Bruno Faccini authored
In case layout has been packed into server reply when not requested, lock l_lvb_type must be set accordingly. Signed-off-by:
Bruno Faccini <bruno.faccini@intel.com> Reviewed-on: http://review.whamcloud.com/8270 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4194Reviewed-by:
-
Lai Siyao authored
Lustre client dentry validation is protected by LDLM lock, so any time a dentry is found, it's valid and no need to revalidate from MDS, and even it does, there is race that it may be invalidated after revalidation is finished. Signed-off-by:
Lai Siyao <lai.siyao@intel.com> Reviewed-on: http://review.whamcloud.com/7475 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3544Reviewed-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
-
Hongchao Zhang authored
- For the non-create open or committed open, the open request should be freed along with the close request as soon as the close done, despite that the transno of open/close is greater than the last committed transno known by client or not. - Move the committed open request into another dedicated list, that will avoid scanning a huge replay list on receiving each reply (when there are many open files). Signed-off-by:
Hongchao Zhang <hongchao.zhang@intel.com> Reviewed-on: http://review.whamcloud.com/6665 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2613Reviewed-by:
-
John L. Hammond authored
In mdc_intent_open_pack() return an ERR_PTR() rather than NULL when ldlm_prep_enqueue_req() fails. In mdc_intent_getattr_async() check the return value of mdc_intent_getattr_pack() using IS_ERR(). Clean up the includes in mdc_locks.c. Signed-off-by:
Nathaniel Clark <nathaniel.l.clark@intel.com> Signed-off-by:
-
John L. Hammond authored
Add a ci_noatime bit to struct cl_io. In ll_io_init() set this bit if O_NOATIME is set in f_flags. Ensure that this bit is propagated down to lower layers. In osc_io_read_start() don't update atime if this bit is set. Add sanity test 39n to check that passing O_NOATIME to open() is honored. Signed-off-by:
Maloo <whamcloud.maloo@gmail.com> Reviewed-by:
-
Alexey Lyashkov authored
Before revalidating a lock on the client, mask the lock bits against the lock bits supported by the server (ibits_known), so newer clients will find valid locks given by older server versions. Signed-off-by:
Patrick Farrell <paf@cray.com> Signed-off-by:
-
wang di authored
Add more comments for MDS_INODELOCK_PERM and MDS_INODELOCK_LOOKUP Signed-off-by:
wang di <di.wang@intel.com> Reviewed-on: http://review.whamcloud.com/7937 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3240Reviewed-by:
-
Oleg Drokin authored
Sending getattr by fid in this case is pointless, as the parent might havelong changed and we have no control over it, but it's irrelevant anyway, since we already have the child fid. Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
-
Oleg Drokin authored
GETATTR needs to return attributes protected by different bits, so we need to ensure all we have locks with all of those bits, not just UPDATE bit Signed-off-by:
-
John L. Hammond authored
In ll_md_blocking_ast() match open locks before all others, ensuring that MDS_INODELOCK_OPEN is not cleared from bits by another open lock with a different mode. Change the int flags parameter of ll_md_real_close() to fmode_t fmode. Clean up verious style issues in both functions. Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
-
Malcolm Priestley authored
Clean up white and camel case. Camel case change pDevice -> priv Signed-off-by:
-
Malcolm Priestley authored
Clean up white space and camel case. Camel case changes pDevice -> priv pTxContext -> tx_context Signed-off-by:
-
Malcolm Priestley authored
cleanup white space and camel case. Camel case changes pDevice -> priv pRCB -> rcb Signed-off-by:
-
Malcolm Priestley authored
Clean up white space, comments and camel case. pDevice -> priv pTxContext -> tx_context pRCB -> rcb Signed-off-by:
-
Malcolm Priestley authored
Remove code that points to netdev (pDevice/priv->dev) Signed-off-by:
-
Malcolm Priestley authored
Clean up white space, comments and camel case. Camel case changes pRCB -> rcb bReAllocSkb -> re_alloc_skb pDevice -> priv Signed-off-by:
-
Malcolm Priestley authored
Remove white space and camel case. Camel case changes pDevice -> priv ntStatus -> status pRCB -> rcb Signed-off-by:
-
- 28 Feb, 2014 14 commits
-
-
Mark Hounschell authored
This patch fixes "do not use assignment in if condition" errors reported by checkpatch Signed-off-by:
Mark Hounschell <markh@compro.net> Signed-off-by:
-
Mark Hounschell authored
This patch fixes white space errors in dgap.c as reported by checkpatch. It also changes unnecessary mutliple empty lines with a single empty line Signed-off-by:
-
Mark Hounschell authored
This patch fixes bracing errors in dgap.c as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes all "include" related errors in dgap.c as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes "foo* bar should be foo *bar" errors in dgap.c as reported by checkpatch Signed-off-by:
-
Fabio Estevam authored
Use snprintf() in order to fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Fabio Estevam <fabio.estevam@freescale.com> Acked-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
-
Fabio Estevam authored
Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) As 'dmfc' could never be null, there is no need to do such check. Reported-by:
Fabio Estevam <festevam@gmail.com> Acked-by:
-
Mark Hounschell authored
This patch fixes all indent errs in dgap.c as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
Fix all return staments in err as reported by checkpatch Signed-off-by:
-
Masanari Iida authored
ws_nthreads is defined as unsigned int, but it was specified as int. Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Mark Hounschell authored
The original debug and tracing code is no longer required. This patch removes it Signed-off-by:
-
Chase Southwood authored
Nearly every variable in hwdrv_apci035.c is initialized to 0 when it is declared, and then set to some other value before ever being used. As such, we can remove all of these initializations. They are accomplishing nothing. Signed-off-by:
Chase Southwood <chase.southwood@yahoo.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in XGI_main_26.c: WARNING: Quoted string split across lines Signed-off-by:
Monam Agarwal <monamagarwal123@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Greg Kroah-Hartman authored
It's been marked BROKEN for over a year, and no one has stepped up to do anything with the code, and no one has complained. So just delete it. If someone wants to fix it up and merge it "properly", they can revert this commit. Cc: Jiri Slaby <jslaby@suse.cz> Cc: Steven Rostedt <rostedt@goodmis.org> Signed-off-by:
-
